From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Scott Wood <scott.wood@nxp.com>,
Hongtao Jia <hongtao.jia@nxp.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Scott Wood <oss@buserror.net>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
Hongtao Jia <hongtao.jia@freescale.com>,
"edubezval@gmail.com" <edubezval@gmail.com>
Subject: Re: 答复: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree
Date: Mon, 11 Jan 2016 22:13:06 +0100 [thread overview]
Message-ID: <13735438.Yvdu0suV1m@wuerfel> (raw)
In-Reply-To: <AM3PR04MB530F71205574CA86CADE93191C90@AM3PR04MB530.eurprd04.prod.outlook.com>
On Monday 11 January 2016 17:34:52 Scott Wood wrote:
> >>
> >> I think you need a 'depends on THERMAL' to prevent the driver from being
> >> built-in when THERMAL=m.
> >>
> >> Arnd
> >
> > Correct. I need to add following lines to the Kconfig file:
> > depends on !CPU_THERMAL || THERMAL=y
> >
> > Hi Rafael,
> > Should I send a new patch include this fix or send a fix patch?
>
> Why THERMAL=y and not just THERMAL, which would allow building this
> driver as a module?
Right, that would be better, and it is what all other drivers do.
For some reason, some drivers depend on !CPU_THERMAL and others
depend on !THERMAL_OF here, and I think the result is the same, but
we are a bit inconsistent here. CPU_THERMAL cannot be set if THERMAL_OF
is disabled, and the header file only uses the 'extern' declaration
if both are set.
Arnd
next prev parent reply other threads:[~2016-01-11 21:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 9:21 [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree Jia Hongtao
[not found] ` <1448529671-48216-1-git-send-email-hongtao.jia-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-12-14 23:58 ` Rafael J. Wysocki
[not found] ` <1697588.dLcbZBRWO4-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2015-12-18 22:32 ` Arnd Bergmann
2016-01-11 14:54 ` 答复: " Hongtao Jia
2016-01-11 17:34 ` Scott Wood
2016-01-11 21:13 ` Arnd Bergmann [this message]
2016-02-26 18:04 ` Li Yang
2016-02-26 20:20 ` Arnd Bergmann
2016-02-26 23:07 ` Li Yang
2016-02-26 23:16 ` Arnd Bergmann
2016-02-26 23:31 ` Li Yang
[not found] ` <CADRPPNSASmfxS=BWKvOxGKyCiqno9YvOuAfBaHwKL-Y=jQ2Dzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-27 0:04 ` Li Yang
2016-02-27 0:08 ` Scott Wood
[not found] ` <1456531704.5360.53.camel-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>
2016-02-27 0:41 ` Li Yang
2016-02-29 10:05 ` Arnd Bergmann
2016-02-29 14:33 ` Rafael J. Wysocki
2016-02-29 14:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13735438.Yvdu0suV1m@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=hongtao.jia@freescale.com \
--cc=hongtao.jia@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=rjw@rjwysocki.net \
--cc=scott.wood@nxp.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox