From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerhard Sittig Subject: [PATCH RFC 2/8] dma: mpc512x: fix start condition in execute() Date: Fri, 12 Jul 2013 17:26:15 +0200 Message-ID: <1373642781-32631-3-git-send-email-gsi@denx.de> References: <1373642781-32631-1-git-send-email-gsi@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1373642781-32631-1-git-send-email-gsi-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Alexander Popov Cc: Lars-Peter Clausen , Vinod Koul , Dan Williams List-Id: devicetree@vger.kernel.org adjust the conditions how submitted DMA jobs get started: memory transfers need to get initiated by an explicit software request, all transfers which involve peripherals need to reference the external requester line Signed-off-by: Gerhard Sittig --- drivers/dma/mpc512x_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c index f90b717..df10a48 100644 --- a/drivers/dma/mpc512x_dma.c +++ b/drivers/dma/mpc512x_dma.c @@ -272,10 +272,12 @@ static void mpc_dma_execute(struct mpc_dma_chan *mchan) mdma->tcd[cid].e_sg = 1; switch (cid) { - case 26: + default: + /* peripherals involved, use external request */ out_8(&mdma->regs->dmaserq, cid); break; case 32: + /* memory transfer, software provided start signal */ out_8(&mdma->regs->dmassrt, cid); break; } -- 1.7.10.4