* [PATCH] msm_serial: add missing iounmap() on error in msm_request_port()
@ 2013-07-17 5:34 Wei Yongjun
2013-07-17 11:28 ` Ivan T. Ivanov
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-07-17 5:34 UTC (permalink / raw)
To: davidb, dwalker, bryanh, gregkh, jslaby, grant.likely,
rob.herring
Cc: yongjun_wei, linux-arm-msm, linux-serial, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing iounmap() before return from msm_request_port()
in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/tty/serial/msm_serial.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 2c6cfb3..0b38b28 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -637,7 +637,7 @@ static int msm_request_port(struct uart_port *port)
if (!request_mem_region(gsbi_resource->start, size,
"msm_serial")) {
ret = -EBUSY;
- goto fail_release_port;
+ goto fail_release_port_membase;
}
msm_port->gsbi_base = ioremap(gsbi_resource->start, size);
@@ -651,6 +651,8 @@ static int msm_request_port(struct uart_port *port)
fail_release_gsbi:
release_mem_region(gsbi_resource->start, size);
+fail_release_port_membase:
+ iounmap(port->membase);
fail_release_port:
release_mem_region(port->mapbase, size);
return ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] msm_serial: add missing iounmap() on error in msm_request_port()
2013-07-17 5:34 [PATCH] msm_serial: add missing iounmap() on error in msm_request_port() Wei Yongjun
@ 2013-07-17 11:28 ` Ivan T. Ivanov
0 siblings, 0 replies; 2+ messages in thread
From: Ivan T. Ivanov @ 2013-07-17 11:28 UTC (permalink / raw)
To: Wei Yongjun
Cc: davidb, dwalker, bryanh, gregkh, jslaby, grant.likely,
rob.herring, yongjun_wei, linux-arm-msm, linux-serial,
devicetree-discuss
On Wed, 2013-07-17 at 13:34 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing iounmap() before return from msm_request_port()
> in the error handling case.
>
Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>
Regards,
Ivan
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/tty/serial/msm_serial.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index 2c6cfb3..0b38b28 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -637,7 +637,7 @@ static int msm_request_port(struct uart_port *port)
> if (!request_mem_region(gsbi_resource->start, size,
> "msm_serial")) {
> ret = -EBUSY;
> - goto fail_release_port;
> + goto fail_release_port_membase;
> }
>
> msm_port->gsbi_base = ioremap(gsbi_resource->start, size);
> @@ -651,6 +651,8 @@ static int msm_request_port(struct uart_port *port)
>
> fail_release_gsbi:
> release_mem_region(gsbi_resource->start, size);
> +fail_release_port_membase:
> + iounmap(port->membase);
> fail_release_port:
> release_mem_region(port->mapbase, size);
> return ret;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-17 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 5:34 [PATCH] msm_serial: add missing iounmap() on error in msm_request_port() Wei Yongjun
2013-07-17 11:28 ` Ivan T. Ivanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).