devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: gregkh@linuxfoundation.org, kyungmin.park@samsung.com,
	balbi@ti.com, kishon@ti.com, jg1.han@samsung.com,
	s.nawrocki@samsung.com, kgene.kim@samsung.com
Cc: grant.likely@linaro.org, tony@atomide.com, arnd@arndb.de,
	swarren@nvidia.com, devicetree-discuss@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
	linux-fbdev@vger.kernel.org, akpm@linux-foundation.org,
	balajitk@ti.com, george.cherian@ti.com, nsekhar@ti.com
Subject: [PATCH 07/15] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
Date: Thu, 18 Jul 2013 12:16:16 +0530	[thread overview]
Message-ID: <1374129984-765-8-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1374129984-765-1-git-send-email-kishon@ti.com>

Now that omap-usb2 is adapted to the new generic PHY framework,
*set_suspend* ops can be removed from omap-usb2 driver.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 drivers/usb/phy/phy-omap-usb2.c |   25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c
index 751b30f..3f2b125 100644
--- a/drivers/usb/phy/phy-omap-usb2.c
+++ b/drivers/usb/phy/phy-omap-usb2.c
@@ -97,29 +97,6 @@ static int omap_usb_set_peripheral(struct usb_otg *otg,
 	return 0;
 }
 
-static int omap_usb2_suspend(struct usb_phy *x, int suspend)
-{
-	u32 ret;
-	struct omap_usb *phy = phy_to_omapusb(x);
-
-	if (suspend && !phy->is_suspended) {
-		omap_control_usb_phy_power(phy->control_dev, 0);
-		pm_runtime_put_sync(phy->dev);
-		phy->is_suspended = 1;
-	} else if (!suspend && phy->is_suspended) {
-		ret = pm_runtime_get_sync(phy->dev);
-		if (ret < 0) {
-			dev_err(phy->dev, "get_sync failed with err %d\n",
-									ret);
-			return ret;
-		}
-		omap_control_usb_phy_power(phy->control_dev, 1);
-		phy->is_suspended = 0;
-	}
-
-	return 0;
-}
-
 static int omap_usb_power_off(struct phy *x)
 {
 	struct omap_usb *phy = phy_get_drvdata(x);
@@ -167,7 +144,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 
 	phy->phy.dev		= phy->dev;
 	phy->phy.label		= "omap-usb2";
-	phy->phy.set_suspend	= omap_usb2_suspend;
 	phy->phy.otg		= otg;
 	phy->phy.type		= USB_PHY_TYPE_USB2;
 
@@ -182,7 +158,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	phy->is_suspended	= 1;
 	omap_control_usb_phy_power(phy->control_dev, 0);
 
 	otg->set_host		= omap_usb_set_host;
-- 
1.7.10.4


  parent reply	other threads:[~2013-07-18  6:46 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18  6:46 [PATCH 00/15] PHY framework Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 01/15] drivers: phy: add generic " Kishon Vijay Abraham I
2013-07-18  7:20   ` Greg KH
     [not found]     ` <20130718072004.GA16720-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-07-18  8:59       ` Kishon Vijay Abraham I
2013-07-18 15:49         ` Greg KH
2013-07-19  5:37           ` Kishon Vijay Abraham I
2013-07-19  5:43             ` Greg KH
2013-07-19  5:55               ` Kishon Vijay Abraham I
     [not found]                 ` <51E8D4E0.8060200-l0cyMroinI0@public.gmane.org>
2013-07-19  6:29                   ` Greg KH
2013-07-19  6:36                     ` Kishon Vijay Abraham I
2013-07-19 15:54                       ` Stephen Warren
     [not found]                         ` <51E96135.9090108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-20  3:15                           ` Kishon Vijay Abraham I
2013-07-19 23:50                       ` Greg KH
2013-07-20  3:19                         ` Kishon Vijay Abraham I
     [not found]                           ` <51EA01C4.2010006-l0cyMroinI0@public.gmane.org>
2013-07-20 22:00                             ` Greg KH
     [not found]                               ` <20130720220006.GA7977-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-07-21  2:32                                 ` Alan Stern
2013-07-21  2:59                                   ` Greg KH
2013-07-21 10:22                                     ` Sascha Hauer
2013-07-21 15:48                                       ` Greg KH
2013-07-21 17:14                                         ` Sylwester Nawrocki
2013-07-21 19:22                                           ` Alan Stern
2013-07-22  7:25                                             ` Kishon Vijay Abraham I
     [not found]                                               ` <51ECDE5E.3050104-l0cyMroinI0@public.gmane.org>
2013-07-22 14:44                                                 ` Alan Stern
2013-07-23  7:29                                                   ` Tomasz Figa
2013-07-22 15:04                                               ` Greg KH
2013-07-23  5:34                                                 ` Kishon Vijay Abraham I
2013-07-21 10:31                                     ` Tomasz Figa
2013-07-21 11:07                                       ` Kishon Vijay Abraham I
2013-07-21 11:12                                         ` Tomasz Figa
2013-07-21 15:46                                           ` Greg KH
2013-07-30  7:11                                             ` Felipe Balbi
2013-07-31  5:44                                               ` Kishon Vijay Abraham I
2013-07-31  6:15                                                 ` Felipe Balbi
2013-08-13 10:44                                                   ` Kishon Vijay Abraham I
2013-08-13 11:37                                                     ` Tomasz Figa
2013-08-13 12:05                                                       ` Kishon Vijay Abraham I
2013-08-13 22:19                                                         ` Sylwester Nawrocki
2013-08-13 23:04                                                           ` Tomasz Figa
2013-08-14 15:05                                                             ` Kishon Vijay Abraham I
2013-08-19  5:28                                                               ` Kishon Vijay Abraham I
2013-08-20 12:26                                                                 ` Felipe Balbi
     [not found] ` <1374129984-765-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-07-18  6:46   ` [PATCH 02/15] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-07-18  7:21     ` Greg KH
     [not found]       ` <20130718072149.GB16720-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-07-18  9:00         ` Kishon Vijay Abraham I
2013-07-18  6:46   ` [PATCH 08/15] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-07-18  6:46   ` [PATCH 12/15] ARM: Samsung: Remove the MIPI PHY setup code Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 03/15] usb: phy: twl4030: use the new generic PHY framework Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 04/15] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
     [not found]   ` <1374129984-765-5-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-07-18  7:02     ` Tony Lindgren
2013-07-18  6:46 ` [PATCH 05/15] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-07-18  7:05   ` Tony Lindgren
2013-07-18  6:46 ` [PATCH 06/15] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-07-18  6:46 ` Kishon Vijay Abraham I [this message]
2013-07-18  6:46 ` [PATCH 09/15] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 10/15] video: exynos_mipi_dsim: Use the generic PHY driver Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 11/15] exynos4-is: Use the generic MIPI CSIS " Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 13/15] phy: Add driver for Exynos DP PHY Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 14/15] video: exynos_dp: remove non-DT support for Exynos Display Port Kishon Vijay Abraham I
2013-07-18  6:46 ` [PATCH 15/15] video: exynos_dp: Use the generic PHY driver Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374129984-765-8-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=balajitk@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=george.cherian@ti.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=s.nawrocki@samsung.com \
    --cc=swarren@nvidia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).