From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from am1ehsobe002.messaging.microsoft.com ([213.199.154.205]:8740 "EHLO am1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029Ab3GXToT convert rfc822-to-8bit (ORCPT ); Wed, 24 Jul 2013 15:44:19 -0400 Date: Wed, 24 Jul 2013 14:29:08 -0500 From: Scott Wood Subject: Re: [PATCH v5 2/4] DMA: Freescale: Add new 8-channel DMA engine device tree nodes References: <1374646870-5162-1-git-send-email-hongbo.zhang@freescale.com> <1374646870-5162-3-git-send-email-hongbo.zhang@freescale.com> In-Reply-To: <1374646870-5162-3-git-send-email-hongbo.zhang@freescale.com> (from hongbo.zhang@freescale.com on Wed Jul 24 01:21:07 2013) Message-ID: <1374694148.15592.61@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org To: hongbo.zhang@freescale.com Cc: vinod.koul@intel.com, djbw@fb.com, leoli@freescale.com, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: On 07/24/2013 01:21:07 AM, hongbo.zhang@freescale.com wrote: > From: Hongbo Zhang > > Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this > patch add > the device tree nodes for them. > > Signed-off-by: Hongbo Zhang > --- > .../devicetree/bindings/powerpc/fsl/dma.txt | 66 > ++++++++++++++++ > arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 4 +- > arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi | 81 > ++++++++++++++++++++ > arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi | 81 > ++++++++++++++++++++ > arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 4 +- > 5 files changed, 232 insertions(+), 4 deletions(-) > create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-0.dtsi > create mode 100644 arch/powerpc/boot/dts/fsl/elo3-dma-1.dtsi > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt > b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt > index ed703d9..54a023b2 100644 > --- a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt > +++ b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt > @@ -130,6 +130,72 @@ Example: > }; > }; > > +** Freescale Elo3 DMA Controller > + This is EloPlus controller with 8 channels, used in Freescale > Txxx and Bxxx > + series chips, such as t1040, t4240, b4860. > + > +Required properties: > + > +- compatible : should be "fsl,elo3-dma" Should include "fsl,elo3-dma". There's nothing different about elo3 versus elo/eloplus regarding whether fsl,CHIP-dma is allowed. I'd just drop the references to fsl,CHIP-dma throughout the binding, and phrase the compatible description as "must include" rather than "must be" so that additional strings are allowed. -Scott