From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
George Cherian <george.cherian@ti.com>,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Vivek Gautam <gautam.vivek@samsung.com>,
linux-omap@vger.kernel.org,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] of: provide of_platform_unpopulate()
Date: Mon, 29 Jul 2013 19:31:56 +1000 [thread overview]
Message-ID: <1375090316.3859.37.camel@pasglop> (raw)
In-Reply-To: <1374257691-31981-1-git-send-email-bigeasy@linutronix.de>
On Fri, 2013-07-19 at 20:14 +0200, Sebastian Andrzej Siewior wrote:
> The problem is that platform_device_del() "releases" each ressource in its
> tree. This does not work on platform_devices created by OF becuase they
> were never added via insert_resource(). As a consequence old->parent in
> __release_resource() is NULL and we explode while accessing ->child.
> So I either I do something completly wrong _or_ nobody here tested the
> rmmod path of their driver.
But that's wrong. I am not familar with all that new code, but from step
up, not having the resources in the resource tree is a bad idea to begin
with....
> This patch provides a common function to unregister / remove devices
> which added to the system via of_platform_populate(). While this works
> now on my test case I have not tested any of the driver I modify here so
> feedback is greatly appreciated.
Ben.
next prev parent reply other threads:[~2013-07-29 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 18:14 [PATCH] of: provide of_platform_unpopulate() Sebastian Andrzej Siewior
[not found] ` <1374257691-31981-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-21 14:42 ` Rob Herring
[not found] ` <51EBF33A.4050207-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-21 19:47 ` Sebastian Andrzej Siewior
2013-07-21 20:48 ` Rob Herring
[not found] ` <51EC4908.4040504-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-21 23:44 ` Grant Likely
2013-07-22 21:16 ` Rob Herring
2013-07-24 14:19 ` Grant Likely
2013-07-31 15:21 ` Sebastian Andrzej Siewior
2013-07-29 9:33 ` Benjamin Herrenschmidt
2013-07-31 16:28 ` Rob Herring
2013-07-29 9:31 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-20 5:03 NAVEEN KRISHNA CHATRADHI
2013-07-20 5:43 NAVEEN KRISHNA CHATRADHI
2013-07-22 8:25 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375090316.3859.37.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gautam.vivek@samsung.com \
--cc=george.cherian@ti.com \
--cc=grant.likely@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).