From: Bill Huang <bilhuang@nvidia.com>
To: Nishanth Menon <nm@ti.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"rob@landley.net" <rob@landley.net>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"broonie@linaro.org" <broonie@linaro.org>,
"j-keerthy@ti.com" <j-keerthy@ti.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"ian@slimlogic.co.uk" <ian@slimlogic.co.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH v2 1/1] mfd: palmas: Add power off control
Date: Thu, 1 Aug 2013 04:08:52 -0700 [thread overview]
Message-ID: <1375355332.32701.13.camel@bilhuang-vm1> (raw)
In-Reply-To: <51F8FBC4.1040009@ti.com>
On Wed, 2013-07-31 at 19:57 +0800, Nishanth Menon wrote:
>
> If you notice the reference code I send, atleast on TWL6035/37 variants
> of Palmas, USB IRQ unmask is mandatory for power on with USB cable -
> example usage scenario: extremely low battery, device powered off, plug
> in usb cable to restart charging - you'd like to initiate charging logic
> in bootloader, but that wont work if the device does not do OFF-ON
> transition with usb cable plugged in for vbus.
>
Why do we need to add Palmas USB_IRQ unmask logic in shutdown? Does that
mean for all platform using Palmas has to unmask USB IRQ (including
those do not power vbus through Palmas)? Can't we just have a simple
shutdown function but have the VBus programming been done in USB driver
or maybe platform driver since it is platform specific control?
next prev parent reply other threads:[~2013-08-01 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 7:17 [PATCH v2 1/1] mfd: palmas: Add power off control Bill Huang
2013-07-31 11:57 ` Nishanth Menon
2013-07-31 17:20 ` Stephen Warren
2013-07-31 18:31 ` Nishanth Menon
2013-08-01 11:08 ` Bill Huang [this message]
2013-08-01 13:08 ` Nishanth Menon
2013-08-02 5:45 ` Bill Huang
2013-08-02 14:39 ` Nishanth Menon
2013-08-05 10:32 ` Bill Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375355332.32701.13.camel@bilhuang-vm1 \
--to=bilhuang@nvidia.com \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkasoju@nvidia.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).