From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Archit Taneja <archit@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Nishanth Menon <nm@ti.com>, Felipe Balbi <balbi@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Tony Lindgren <tony@atomide.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [RFC 01/22] ARM: OMAP: remove DSS DT hack
Date: Fri, 9 Aug 2013 11:38:46 +0300 [thread overview]
Message-ID: <1376037547-10859-2-git-send-email-tomi.valkeinen@ti.com> (raw)
In-Reply-To: <1376037547-10859-1-git-send-email-tomi.valkeinen@ti.com>
As a temporary solution to enable DSS for selected boards when booting
with DT, a hack was added to board-generic.c in
63d5fc0c2f748e20f38a0a0ec1c8494bddf5c288 (OMAP: board-generic: enable
DSS for panda & sdp boards).
We're now adding proper DT support, so the hack can be removed.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-generic.c | 11 +----------
arch/arm/mach-omap2/dss-common.c | 23 -----------------------
arch/arm/mach-omap2/dss-common.h | 2 --
3 files changed, 1 insertion(+), 35 deletions(-)
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index be5d005..d388d33 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -57,17 +57,8 @@ static void __init omap_generic_init(void)
of_platform_populate(NULL, omap_dt_match_table, NULL, NULL);
- /*
- * HACK: call display setup code for selected boards to enable omapdss.
- * This will be removed when omapdss supports DT.
- */
- if (of_machine_is_compatible("ti,omap4-panda")) {
- omap4_panda_display_init_of();
+ if (of_machine_is_compatible("ti,omap4-panda"))
legacy_init_ehci_clk("auxclk3_ck");
-
- }
- else if (of_machine_is_compatible("ti,omap4-sdp"))
- omap_4430sdp_display_init_of();
else if (of_machine_is_compatible("ti,omap5-uevm"))
legacy_init_ehci_clk("auxclk1_ck");
}
diff --git a/arch/arm/mach-omap2/dss-common.c b/arch/arm/mach-omap2/dss-common.c
index 043e570..f3282ac 100644
--- a/arch/arm/mach-omap2/dss-common.c
+++ b/arch/arm/mach-omap2/dss-common.c
@@ -98,12 +98,6 @@ void __init omap4_panda_display_init(void)
omap_mux_init_gpio(HDMI_GPIO_HPD, OMAP_PIN_INPUT_PULLDOWN);
}
-void __init omap4_panda_display_init_of(void)
-{
- omap_display_init(&omap4_panda_dss_data);
-}
-
-
/* OMAP4 Blaze display data */
#define DISPLAY_SEL_GPIO 59 /* LCD2/PicoDLP switch */
@@ -232,20 +226,3 @@ void __init omap_4430sdp_display_init(void)
omap_mux_init_gpio(HDMI_GPIO_CT_CP_HPD, OMAP_PIN_OUTPUT);
omap_mux_init_gpio(HDMI_GPIO_HPD, OMAP_PIN_INPUT_PULLDOWN);
}
-
-void __init omap_4430sdp_display_init_of(void)
-{
- int r;
-
- r = gpio_request_one(DISPLAY_SEL_GPIO, GPIOF_OUT_INIT_HIGH,
- "display_sel");
- if (r)
- pr_err("%s: Could not get display_sel GPIO\n", __func__);
-
- r = gpio_request_one(DLP_POWER_ON_GPIO, GPIOF_OUT_INIT_LOW,
- "DLP POWER ON");
- if (r)
- pr_err("%s: Could not get DLP POWER ON GPIO\n", __func__);
-
- omap_display_init(&sdp4430_dss_data);
-}
diff --git a/arch/arm/mach-omap2/dss-common.h b/arch/arm/mach-omap2/dss-common.h
index 915f6ff..611b341 100644
--- a/arch/arm/mach-omap2/dss-common.h
+++ b/arch/arm/mach-omap2/dss-common.h
@@ -7,8 +7,6 @@
*/
void __init omap4_panda_display_init(void);
-void __init omap4_panda_display_init_of(void);
void __init omap_4430sdp_display_init(void);
-void __init omap_4430sdp_display_init_of(void);
#endif
--
1.8.1.2
next prev parent reply other threads:[~2013-08-09 8:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 8:38 [RFC 00/22] OMAPDSS: DT support Tomi Valkeinen
2013-08-09 8:38 ` Tomi Valkeinen [this message]
2013-08-09 8:38 ` [RFC 02/22] OMAPDSS: remove DT hacks for regulators Tomi Valkeinen
2013-08-09 8:38 ` [RFC 03/22] ARM: OMAP2+: add omapdss_init_of() Tomi Valkeinen
2013-08-09 8:38 ` [RFC 04/22] OMAPDSS: if dssdev->name==NULL, use alias Tomi Valkeinen
2013-08-09 8:38 ` [RFC 05/22] OMAPDSS: get dssdev->alias from DT alias Tomi Valkeinen
2013-08-09 8:38 ` [RFC 06/22] OMAPFB: clean up default display search Tomi Valkeinen
2013-08-09 8:38 ` [RFC 07/22] OMAPFB: search for default display with DT alias Tomi Valkeinen
2013-08-09 8:38 ` [RFC 08/22] OMAPDSS: Add DT support to DSS, DISPC, DPI, HDMI, VENC Tomi Valkeinen
2013-08-09 8:38 ` [RFC 09/22] OMAPDSS: Add DT support to DSI Tomi Valkeinen
2013-08-09 8:38 ` [RFC 10/22] ARM: omap3.dtsi: add omapdss information Tomi Valkeinen
2013-08-09 8:38 ` [RFC 11/22] ARM: omap4.dtsi: " Tomi Valkeinen
2013-08-09 8:38 ` [RFC 12/22] ARM: omap4-panda.dts: add display information Tomi Valkeinen
2013-08-09 8:38 ` [RFC 13/22] ARM: omap4-sdp.dts: " Tomi Valkeinen
2013-08-09 8:38 ` [RFC 14/22] ARM: omap3-tobi.dts: add lcd (TEST) Tomi Valkeinen
2013-08-09 8:39 ` [RFC 15/22] ARM: omap3-beagle.dts: add display information Tomi Valkeinen
2013-08-09 8:39 ` [RFC 16/22] OMAPDSS: panel-dsi-cm: Add DT support Tomi Valkeinen
2013-08-09 8:39 ` [RFC 17/22] OMAPDSS: encoder-tfp410: " Tomi Valkeinen
2013-08-09 8:39 ` [RFC 18/22] OMAPDSS: connector-dvi: " Tomi Valkeinen
2013-08-09 8:39 ` [RFC 19/22] OMAPDSS: encoder-tpd12s015: " Tomi Valkeinen
2013-08-09 8:39 ` [RFC 20/22] OMAPDSS: hdmi-connector: " Tomi Valkeinen
2013-08-09 8:39 ` [RFC 21/22] OMAPDSS: panel-dpi: " Tomi Valkeinen
2013-08-09 8:39 ` [RFC 22/22] OMAPDSS: connector-analog-tv: " Tomi Valkeinen
2013-08-13 7:54 ` [RFC 00/22] OMAPDSS: " Tony Lindgren
2013-08-30 9:47 ` Tomi Valkeinen
2013-09-02 6:15 ` Tony Lindgren
2013-09-02 6:42 ` Tomi Valkeinen
2013-09-04 17:20 ` Tony Lindgren
2013-08-21 21:07 ` Laurent Pinchart
2013-09-02 8:00 ` Tomi Valkeinen
2013-09-03 10:56 ` Laurent Pinchart
2013-09-04 7:29 ` Stefan Roese
2013-09-04 7:41 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376037547-10859-2-git-send-email-tomi.valkeinen@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).