From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: balbi@ti.com
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ian.campbell@citrix.com, rob@landley.net,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver
Date: Wed, 14 Aug 2013 12:43:24 +0300 [thread overview]
Message-ID: <1376473404.2132.10.camel@iivanov-dev.int.mm-sol.com> (raw)
In-Reply-To: <20130809132349.GC12041@radagast>
Hi,
On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote:
<snip>
>
> > + /*
> > + * DWC3 Core requires its CORE CLK (aka master / bus clk) to
> > + * run at 125Mhz in SSUSB mode and >60MHZ for HSUSB mode.
> > + */
> > + clk_set_rate(mdwc->core_clk, 125000000);
>
> if this is dwc3's core clock, why don't we teach dwc3.ko about this
> requirement ? Just make sure to have it optional, since x86 and OMAP
> wouldn't need direct fiddling with the clocks.
I believe this is Qualcomm specific requirement. Something is modified
inside DWC in respect of the clocks. I will like to keep this here, in
the glue layer driver.
Regards,
Ivan
prev parent reply other threads:[~2013-08-14 9:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 11:53 [RFC 0/2] DWC3 USB support for Qualcomm platform Ivan T. Ivanov
2013-08-06 11:53 ` [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core Ivan T. Ivanov
2013-08-06 12:12 ` Pawel Moll
2013-08-06 13:30 ` Ivan T. Ivanov
2013-08-06 14:03 ` Mark Rutland
2013-08-06 14:36 ` Ivan T. Ivanov
2013-08-08 9:16 ` Mark Rutland
2013-08-06 11:53 ` [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver Ivan T. Ivanov
2013-08-06 12:21 ` Pawel Moll
2013-08-06 13:46 ` Ivan T. Ivanov
2013-08-06 15:15 ` Pawel Moll
2013-08-06 17:53 ` Ivan T. Ivanov
2013-08-09 13:24 ` Felipe Balbi
2013-08-06 14:07 ` Mark Rutland
2013-08-06 14:41 ` Ivan T. Ivanov
2013-08-09 13:23 ` Felipe Balbi
2013-08-09 16:09 ` Ivan T. Ivanov
2013-08-12 18:24 ` Felipe Balbi
2013-08-14 9:28 ` Ivan T. Ivanov
2013-08-27 18:46 ` Felipe Balbi
2013-08-14 9:43 ` Ivan T. Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376473404.2132.10.camel@iivanov-dev.int.mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).