From: Pawel Moll <pawel.moll@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
"maxime.ripard@free-electrons.com"
<maxime.ripard@free-electrons.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"l.czerwinski@samsung.com" <l.czerwinski@samsung.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"s.nawrocki@samsung.com" <s.nawrocki@samsung.com>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: passing two interrupts two an I2C driver
Date: Thu, 22 Aug 2013 10:23:28 +0100 [thread overview]
Message-ID: <1377163408.10707.29.camel@hornet> (raw)
In-Reply-To: <20130821175446.GI26118@sirena.org.uk>
On Wed, 2013-08-21 at 18:54 +0100, Mark Brown wrote:
> On Wed, Aug 21, 2013 at 01:37:04PM +0100, Pawel Moll wrote:
>
> > So let me ask such question... If Device Tree didn't exist, how would
> > you make drive such device? I guess it would require some custom code,
>
> It's always done using platform data, same for SPI - if we update one we
> should probably update both.
If the platform data used to carry the (custom) irq data, the DT-powered
driver could interrogate the DT on is own, couldn't it? Of course there
should be some helper available, maybe something of that sort? (warning,
untested)
8<---------------------
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 1264923..d2a02dd 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -46,6 +46,15 @@ unsigned int irq_of_parse_and_map(struct device_node *dev, int index)
}
EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
+unsigned int irq_of_parse_and_map_by_name(struct device_node *dev,
+ const char *name)
+{
+ int index = of_property_match_string(dev, "interrupt-names", name);
+
+ return index < 0 ? 0 : irq_of_parse_and_map(dev, index);
+}
+EXPORT_SYMBOL_GPL(irq_of_parse_and_map_by_name);
+
/**
* of_irq_find_parent - Given a device node, find its interrupt parent node
* @child: pointer to device node
8<---------------------
Pawel
next prev parent reply other threads:[~2013-08-22 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <520E3B8F.9010800@samsung.com>
[not found] ` <520E7417.3090606@wwwdotorg.org>
2013-08-19 8:42 ` passing two interrupts two an I2C driver Mark Rutland
2013-08-19 16:09 ` Stephen Warren
2013-08-20 8:44 ` Mark Rutland
2013-08-20 16:25 ` Stephen Warren
2013-08-21 8:54 ` Mark Rutland
2013-08-22 12:45 ` Rob Herring
2013-08-22 20:26 ` Stephen Warren
2013-08-21 11:53 ` Jacek Anaszewski
2013-08-21 12:34 ` Pawel Moll
2013-08-21 12:37 ` Pawel Moll
2013-08-21 17:54 ` Mark Brown
2013-08-22 9:23 ` Pawel Moll [this message]
2013-08-22 11:26 ` Mark Brown
2013-08-22 11:44 ` Pawel Moll
2013-08-22 13:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377163408.10707.29.camel@hornet \
--to=pawel.moll@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=j.anaszewski@samsung.com \
--cc=jic23@kernel.org \
--cc=l.czerwinski@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rob.herring@calxeda.com \
--cc=s.nawrocki@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).