From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:55395 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753431Ab3HVVpE (ORCPT ); Thu, 22 Aug 2013 17:45:04 -0400 Message-ID: <1377207893.20722.14.camel@snotra.buserror.net> Subject: Re: [PATCH] Device Tree bindings for DSP clusters and DSP CPUs From: Scott Wood Date: Thu, 22 Aug 2013 16:44:53 -0500 In-Reply-To: <1377077149-24347-1-git-send-email-poonam.aggrwal@freescale.com> References: <1377077149-24347-1-git-send-email-poonam.aggrwal@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Poonam Aggrwal Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-ID: On Wed, 2013-08-21 at 14:55 +0530, Poonam Aggrwal wrote: > Binding for DSP CPU clusters and DSP CPUs for Freescale SOCs which > have DSP CPUs in addition to PowerPC CPUs. For example B4860. > > Signed-off-by: Poonam Aggrwal > --- > .../devicetree/bindings/powerpc/fsl/dsp-cpus.txt | 78 ++++++++++++++++++++ > 1 files changed, 78 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt > new file mode 100644 > index 0000000..da7f5d4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt > @@ -0,0 +1,78 @@ > +=================================================================== > +Binding for DSP CPU clusters and DSP CPUs for Freescale SOCs which > +have DSP CPUs in addition to PowerPC cpus. > +Copyright 2013 Freescale Semiconductor Inc. > + > +Power Architecture CPUs in Freescale SOCs are represented in device trees as > +per the definition in ePAPR. > + > +Required properties for DSP CPU cluster: > +- compatible : should be "fsl,dsp-cluster" or "fsl,sc3900-cluster". > +- reg : should contain the cluster index > + > +Required properties for DSP CPU: > +- compatible : should be "fsl,dsp" or "fsl,sc3900". > +- reg : should contain index of DSP CPU within the DSP clsuter. s/clsuter/cluster/ Could you elaborate on "index of DSP CPU within the DSP cluster"? From the examples it looks like the reg values are unique even across clusters. I wonder whether we should be describing this at all in the device tree given that the topology is discoverable in registers... though that applies to the PowerPC CPUs as well. :-) -Scott