devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: broonie@kernel.org
Cc: dwmw2@infradead.org, dedekind1@gmail.com,
	computersforpeace@gmail.com, shawn.guo@linaro.org,
	kernel@pengutronix.de, b18965@freescale.com,
	b44548@freescale.com, lznuaa@gmail.com,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	Huang Shijie <b32955@freescale.com>
Subject: [PATCH v3 3/8] mtd: m25p80: add the quad-read support
Date: Fri, 30 Aug 2013 10:07:24 +0800	[thread overview]
Message-ID: <1377828449-18912-4-git-send-email-b32955@freescale.com> (raw)
In-Reply-To: <1377828449-18912-1-git-send-email-b32955@freescale.com>

This patch adds the quad read support:

(1) Add the relative commands:
      OPCODE_QIOR, OPCODE_4QIOR, OPCODE_RDCR,

    also add the relative macro for the Configuartion Register.

(2) add the "m25p,quad-read" property for the m25p80 driver
    If the dts has the "m25p,quad-read" property, the kernel will
    set the Quad bit of the configuration register, and when the
    setting suceedes, we will set the read opcode with the right
    spi nor command.

Signed-off-by: Huang Shijie <b32955@freescale.com>
---
 Documentation/devicetree/bindings/mtd/m25p80.txt |    5 ++
 drivers/mtd/devices/m25p80.c                     |   62 ++++++++++++++++++++++
 include/linux/mtd/spi-nor.h                      |    6 ++
 3 files changed, 73 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt b/Documentation/devicetree/bindings/mtd/m25p80.txt
index 6d3d576..b33313f 100644
--- a/Documentation/devicetree/bindings/mtd/m25p80.txt
+++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
@@ -17,6 +17,11 @@ Optional properties:
                    Refer to your chips' datasheet to check if this is supported
                    by your chip.
 
+- m25p,quad-read : Use the "quad read" opcode to read data from the chip instead
+                   of the usual "read" opcode. This opcode is not supported by
+                   all chips and support for it can not be detected at runtime.
+                   Refer to your chips' datasheet to check if this is supported
+                   by your chip.
 Example:
 
 	flash: m25p80@0 {
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index cae419e..0645c9f 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -103,6 +103,40 @@ static int write_sr(struct m25p *flash, u8 val)
 }
 
 /*
+ * Read the configuration register, returning its value in the location
+ * Return the configuration register value.
+ * Returns negative if error occurred.
+ */
+static int read_cr(struct m25p *flash)
+{
+	u8 code = OPCODE_RDCR;
+	int ret;
+	u8 val;
+
+	ret = spi_write_then_read(flash->spi, &code, 1, &val, 1);
+	if (ret < 0) {
+		dev_err(&flash->spi->dev, "error %d reading CR\n", ret);
+		return ret;
+	}
+	return val;
+}
+
+/*
+ * Write status register and configuration register with 2 bytes
+ * The first byte will be written to the status register, while the second byte
+ * will be written to the configuration register.
+ * Returns negative if error occurred.
+ */
+static int write_sr_cr(struct m25p *flash, u16 val)
+{
+	flash->command[0] = OPCODE_WRSR;
+	flash->command[1] = val & 0xff;
+	flash->command[2] = (val >> 8);
+
+	return spi_write(flash->spi, flash->command, 3);
+}
+
+/*
  * Set write enable latch with Write Enable command.
  * Returns negative if error occurred.
  */
@@ -874,6 +908,31 @@ static const struct spi_device_id *jedec_probe(struct spi_device *spi)
 	return ERR_PTR(-ENODEV);
 }
 
+static void m25p80_check_quad_read(struct m25p *flash, struct device_node *np)
+{
+	int ret;
+	int sr_cr;
+
+	if (of_property_read_bool(np, "m25p,quad-read")) {
+		/* The configuration register is set by the second byte. */
+		sr_cr = CR_QUAD << 8;
+
+		/* Write the QUAD bit to the Configuration Register. */
+		write_enable(flash);
+		if (write_sr_cr(flash, sr_cr))
+			return;
+
+		/* read back and check it */
+		ret = read_cr(flash);
+		if (!(ret > 0 && (ret & CR_QUAD)))
+			return;
+
+		if (flash->mtd.size <= SZ_16M)
+			flash->read_opcode = OPCODE_QIOR;
+		else
+			flash->read_opcode = OPCODE_4QIOR;
+	}
+}
 
 /*
  * board specific setup should have ensured the SPI clock used here
@@ -1048,6 +1107,9 @@ static int m25p_probe(struct spi_device *spi)
 		flash->addr_width = 3;
 	}
 
+	/* Try to enable the Quad Read */
+	m25p80_check_quad_read(flash, np);
+
 	dev_info(&spi->dev, "%s (%lld Kbytes)\n", id->name,
 			(long long)flash->mtd.size >> 10);
 
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index f2637b9..e6c3309 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -40,6 +40,9 @@
 
 /* Used for Spansion flashes only. */
 #define	OPCODE_BRWR		0x17	/* Bank register write */
+#define	OPCODE_QIOR		0xeb	/* Quad read */
+#define	OPCODE_4QIOR		0xec	/* Quad read (4-byte)*/
+#define	OPCODE_RDCR		0x35	/* Read configuration register */
 
 /* Status Register bits. */
 #define	SR_WIP			1	/* Write in progress */
@@ -50,4 +53,7 @@
 #define	SR_BP2			0x10	/* Block protect 2 */
 #define	SR_SRWD			0x80	/* SR write protect */
 
+/* Configuration Register bits. */
+#define	CR_QUAD			0x2	/* Quad I/O */
+
 #endif /* __LINUX_MTD_SPI_NOR_H */
-- 
1.7.1



  parent reply	other threads:[~2013-08-30  2:07 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  2:07 [PATCH v3 0/8] Add the Quadspi driver for vf610-twr Huang Shijie
2013-08-30  2:07 ` [PATCH v3 1/8] mtd: m25p80: move the spi-nor commands to a header Huang Shijie
2013-08-30  2:07 ` [PATCH v3 2/8] mtd: m25p80: add support for Spansion s25fl128s chip Huang Shijie
2013-08-30  2:07 ` Huang Shijie [this message]
2013-08-30  2:07 ` [PATCH v3 4/8] mtd: m25p80: add the DDR quad-read support Huang Shijie
2013-08-30  2:07 ` [PATCH v3 5/8] spi: Add Freescale QuadSpi driver Huang Shijie
2013-09-10 18:09   ` Mark Brown
2013-09-11  2:40     ` Huang Shijie
2013-09-11 10:39       ` Mark Brown
2013-08-30  2:07 ` [PATCH v3 6/8] Documentation: add the binding file for Quadspi driver Huang Shijie
2013-08-30  2:07 ` [PATCH v3 7/8] ARM: dts: vf610: change the PAD values for Quadspi Huang Shijie
2013-08-30  2:07 ` [PATCH v3 8/8] ARM: dts: vf610-twr: Add SPI NOR support Huang Shijie
2013-09-04  2:16 ` [PATCH v3 0/8] Add the Quadspi driver for vf610-twr Huang Shijie
2013-09-04  9:55   ` Mark Brown
2013-09-04 10:29     ` Huang Shijie
2013-09-04 11:33       ` Mark Brown
2013-09-05  1:43         ` Huang Shijie
2013-09-04 13:45           ` thomas.langer
2013-09-05  2:04             ` Huang Shijie
2013-09-05  4:25               ` Gupta, Pekon
2013-09-05  5:34                 ` Huang Shijie
2013-09-05  6:32                   ` Gupta, Pekon
2013-09-05  7:45                     ` Huang Shijie
2013-09-05  9:11                       ` Gupta, Pekon
2013-09-05  9:30                         ` Huang Shijie
2013-09-05 13:50                           ` Mark Brown
2013-09-06  2:36                             ` Huang Shijie
2013-09-08 13:47                               ` Mark Brown
2013-09-09  3:07                                 ` Huang Shijie
2013-09-09 15:14                                   ` Mark Brown
2013-09-10  6:59                                     ` Huang Shijie
2013-09-10 18:07                                       ` Mark Brown
2013-09-11  2:38                                         ` Huang Shijie
2013-09-11 10:41                                           ` Mark Brown
2013-09-11 10:54                                             ` Huang Shijie
2013-09-11 11:30                                               ` Mark Brown
2013-09-11 12:26                                                 ` Gupta, Pekon
2013-09-11 12:35                                                   ` Mark Brown
2013-09-12  9:18                                                 ` Huang Shijie
2013-09-12 10:20                                                   ` Mark Brown
2013-09-13  3:30                                                     ` Huang Shijie
2013-09-12 15:32                                                       ` David Woodhouse
2013-09-12 10:39                                                   ` David Woodhouse
2013-09-12 10:56                                                     ` Gupta, Pekon
2013-09-12 11:17                                                       ` David Woodhouse
2013-09-12 11:48                                                         ` Mark Brown
2013-09-12 11:55                                                           ` Russell King - ARM Linux
2013-09-12 13:24                                                             ` Mark Brown
2013-09-12 13:25                                                             ` Ricard Wanderlof
2013-09-12 14:10                                                               ` Russell King - ARM Linux
2013-09-12 12:02                                                           ` David Woodhouse
2013-09-12 13:43                                                             ` Mark Brown
2013-09-12 14:03                                                               ` David Woodhouse
2013-09-12 14:40                                                                 ` Mark Brown
2013-09-13  3:14                                                                 ` Huang Shijie
2013-09-11 14:05                                               ` David Woodhouse
2013-09-11 15:07                                                 ` Mark Brown
     [not found]                                   ` <20130909151450 <52318953.6090405@freescale.com>
     [not found]                                     ` <52318953.6090405@freescale.com>
2013-09-12  9:50                                       ` David Woodhouse
2013-09-12 10:19                                         ` Mark Brown
2013-09-13  2:58                                         ` Huang Shijie
2013-09-12 15:22                                           ` David Woodhouse
2013-09-13  4:12                                             ` Huang Shijie
2013-09-12 16:26                                               ` David Woodhouse
2013-09-13  3:06                                                 ` Huang Shijie
2013-09-12 16:27                                               ` Fabio Estevam
     [not found]                                                 ` <CAOMZO5C54wCdEOHJmwVLk_zkh-twjis1ys20Gd1+T+ygM+A6bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-13  2:21                                                   ` Huang Shijie
2013-09-12 20:56                                               ` Mark Brown
     [not found]                                                 ` <20130912205644.GW29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-13  4:55                                                   ` Huang Shijie
     [not found]                                                     ` <52329AD3.2050608-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-09-13 10:21                                                       ` Mark Brown
     [not found]                                                         ` <20130913102127.GD29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-16  2:40                                                           ` Huang Shijie
2013-09-16 10:19                                                             ` Mark Brown
     [not found]                                                               ` <20130916101912.GY29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-16 10:27                                                                 ` Huang Shijie
     [not found]                                                                   ` <5236DD17.5090203-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-09-16 11:06                                                                     ` Mark Brown
     [not found]                                                                       ` <20130916110634.GC29403-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-17  2:14                                                                         ` Huang Shijie
     [not found]                                                                           ` <5237BB01.3080700-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-09-17 10:51                                                                             ` Mark Brown
     [not found]                                                                               ` <20130917105142.GO21013-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-17 15:05                                                                                 ` Gerhard Sittig
2013-09-17 16:49                                                                                   ` Gerhard Sittig
2013-09-17 19:54                                                                                     ` Sourav Poddar
     [not found]                                                                                   ` <20130917150548.GE14747-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-09-17 19:13                                                                                     ` Mark Brown
     [not found]                                                                                       ` <20130917191318.GJ21013-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-09-18 15:40                                                                                         ` David Woodhouse
     [not found]                                                                                           ` <1379518822.753.91.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2013-09-18 16:00                                                                                             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377828449-18912-4-git-send-email-b32955@freescale.com \
    --to=b32955@freescale.com \
    --cc=b18965@freescale.com \
    --cc=b44548@freescale.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lznuaa@gmail.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).