From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Benoit Cousson <b-cousson@ti.com>,
grant.likely@secretlab.ca, tony@atomide.com,
Kevin Hilman <khilman@ti.com>,
manjugk@ti.com, devicetree-discuss@lists.ozlabs.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/7] arm/dts: OMAP3: Add mpu and iva nodes
Date: Thu, 01 Sep 2011 20:17:09 +0200 [thread overview]
Message-ID: <1377915.IaVE5xAurc@wuerfel> (raw)
In-Reply-To: <1314897912-18178-3-git-send-email-b-cousson@ti.com>
On Thursday 01 September 2011 19:25:07 Benoit Cousson wrote:
>
> /*
> + * XXX: The cpus node is mandatory, but since the CPUs are as well part
> + * of the mpu subsystem below, it is not clear where the information
> + * should be. Maybe here with a phandle inside the mpu?
> + */
> + cpus {
> + };
> +
> + /*
> * The soc node represents the soc top level view. It is uses for IPs
> * that are not memory mapped in the MPU view or for the MPU itself.
> */
> soc {
> compatible = "ti,omap-infra";
> + mpu {
> + compatible = "ti,omap3-mpu";
> + hwmods = "mpu";
> + cpu@0 {
> + compatible = "arm,cortex-a8";
> + };
> + };
> +
I would always put the cpu nodes in the top-level, even if that's
a slight misrepresentation of the truth. The point is basically
that CPU nodes are special (you cannot have device drivers for them)
and that the device tree is basically laid out from the perspective
of the CPU, which may be different from the perspective that a
hardware designer has.
Arnd
next prev parent reply other threads:[~2011-09-01 18:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:25 [PATCH 0/7] OMAP3: Add basic DT support + i2c + twl Benoit Cousson
[not found] ` <1314897912-18178-1-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-01 17:25 ` [PATCH 1/7] arm/dts: Add initial device-tree support for OMAP3 SoC Benoit Cousson
2011-09-01 17:25 ` [PATCH 2/7] arm/dts: OMAP3: Add mpu and iva nodes Benoit Cousson
2011-09-01 18:17 ` Arnd Bergmann [this message]
2011-09-05 15:05 ` Cousson, Benoit
2011-09-05 17:23 ` Arnd Bergmann
2011-09-05 17:46 ` Mitch Bradley
2011-09-06 7:15 ` Cousson, Benoit
2011-09-01 17:25 ` [PATCH 3/7] arm/dts: OMAP3: Add i2c controllers nodes Benoit Cousson
2011-09-01 17:25 ` [PATCH 4/7] arm/dts: omap3-beagle: Include the generic omap3.dtsi Benoit Cousson
2011-09-01 17:25 ` [PATCH 5/7] arm/dts: omap3-beagle: Add twl4030 and EEPROM i2c devices Benoit Cousson
2011-09-01 17:25 ` [PATCH 6/7] OMAP3: board-dt: Add generic board file for DT support Benoit Cousson
2011-09-02 8:09 ` Tony Lindgren
2011-09-02 8:46 ` Cousson, Benoit
[not found] ` <4E609800.9090402-l0cyMroinI0@public.gmane.org>
2011-09-02 9:08 ` Russell King - ARM Linux
2011-09-02 9:13 ` Cousson, Benoit
2011-09-02 9:21 ` Russell King - ARM Linux
2011-09-02 9:34 ` Cousson, Benoit
2011-09-02 10:43 ` Tony Lindgren
2011-09-02 11:43 ` Cousson, Benoit
2011-09-02 11:57 ` Tony Lindgren
2011-09-02 12:20 ` Cousson, Benoit
2011-09-02 12:32 ` Tony Lindgren
2011-09-05 12:09 ` G, Manjunath Kondaiah
2011-09-01 17:25 ` [PATCH 7/7] OMAP3: beagleboard: Remove DT support from regular board Benoit Cousson
2011-09-02 8:12 ` Tony Lindgren
2011-09-02 8:59 ` Cousson, Benoit
2011-09-02 10:48 ` Tony Lindgren
2011-09-02 12:35 ` Cousson, Benoit
2011-09-02 13:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377915.IaVE5xAurc@wuerfel \
--to=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).