From: Alexandre Courbot <acourbot@nvidia.com>
To: Russell King <linux@arm.linux.org.uk>,
Stephen Warren <swarren@wwwdotorg.org>,
Tomasz Figa <t.figa@samsung.com>,
Dave Martin <Dave.Martin@arm.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Kevin Hilman <khilman@linaro.org>
Cc: gnurou@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v5 4/5] ARM: tegra: set CPU reset handler with firmware op
Date: Thu, 5 Sep 2013 12:27:59 +0900 [thread overview]
Message-ID: <1378351680-14696-5-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1378351680-14696-1-git-send-email-acourbot@nvidia.com>
Use a firmware operation to set the CPU reset handler and only resort to
doing it ourselves if there is none defined.
This supports the booting of secondary CPUs on devices using a TrustZone
secure monitor.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/mach-tegra/reset.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-tegra/reset.c b/arch/arm/mach-tegra/reset.c
index 6964117..fc9cf03 100644
--- a/arch/arm/mach-tegra/reset.c
+++ b/arch/arm/mach-tegra/reset.c
@@ -21,6 +21,7 @@
#include <asm/cacheflush.h>
#include <asm/hardware/cache-l2x0.h>
+#include <asm/firmware.h>
#include "iomap.h"
#include "irammap.h"
@@ -65,6 +66,7 @@ static void __init tegra_cpu_reset_handler_enable(void)
void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
const u32 reset_address = TEGRA_IRAM_RESET_BASE +
tegra_cpu_reset_handler_offset;
+ int err;
BUG_ON(is_enabled);
BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
@@ -72,9 +74,18 @@ static void __init tegra_cpu_reset_handler_enable(void)
memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
tegra_cpu_reset_handler_size);
- tegra_cpu_reset_handler_set(reset_address);
-
- is_enabled = true;
+ err = call_firmware_op(set_cpu_boot_addr, 0, reset_address);
+ switch (err) {
+ case -ENOSYS:
+ tegra_cpu_reset_handler_set(reset_address);
+ /* pass-through */
+ case 0:
+ is_enabled = true;
+ break;
+ default:
+ pr_crit("Cannot set CPU reset handler: %d\n", err);
+ BUG();
+ }
}
void __init tegra_cpu_reset_handler_init(void)
--
1.8.4
next prev parent reply other threads:[~2013-09-05 3:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 3:27 [PATCH v5 0/5] ARM: support for Trusted Foundations secure monitor Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 1/5] ARM: add basic Trusted Foundations support Alexandre Courbot
[not found] ` <1378351680-14696-2-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-05 18:35 ` Rob Herring
[not found] ` <5228CEDB.1090306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-09 6:15 ` Alexandre Courbot
[not found] ` <CAAVeFu+MGGBfmm1jwtKGP_d3EjkLdf5B_E_5RT___PVh1e=8jw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-10 13:04 ` Will Deacon
2013-09-12 9:18 ` Linus Walleij
2013-09-12 9:56 ` Alexandre Courbot
2013-09-10 13:18 ` Catalin Marinas
2013-09-06 19:29 ` Stephen Warren
2013-09-09 6:38 ` Alexandre Courbot
[not found] ` <CAAVeFuJF-cu9aPCruGPQk9WHV7VAGhGpU0bU6LToxP38YBnS_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-09 15:59 ` Stephen Warren
[not found] ` <522DF058.8020509-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-12 10:00 ` Alexandre Courbot
2013-09-06 16:48 ` Linus Walleij
[not found] ` <CACRpkdaphSqM1oOphC-t1UPmkxaEemC3R3aDfEXb79GWNNyNMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-09 6:32 ` Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 2/5] ARM: tegra: add support for Trusted Foundations Alexandre Courbot
2013-09-05 3:27 ` [PATCH v5 3/5] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
2013-09-05 3:27 ` Alexandre Courbot [this message]
[not found] ` <1378351680-14696-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-05 3:28 ` [PATCH v5 5/5] ARM: tegra: support Trusted Foundations by default Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378351680-14696-5-git-send-email-acourbot@nvidia.com \
--to=acourbot@nvidia.com \
--cc=Dave.Martin@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).