From: Archit Taneja <archit-l0cyMroinI0@public.gmane.org>
To: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tomi.valkeinen-l0cyMroinI0@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Archit Taneja <archit-l0cyMroinI0@public.gmane.org>,
Andy Gross <andygro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 4/4] arm: omap: display: Don't build device for DMM
Date: Fri, 13 Sep 2013 14:44:39 +0530 [thread overview]
Message-ID: <1379063679-4869-5-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1379063679-4869-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
DMM exists on omap4+ platforms, these platforms will always boot with DT. Remove
the previous method of searching the dmm hwmod and building the device by
ourselves. Addition of a DMM nodes in DT will ensure a DMM device is built.
For OMAP4, the address and irq data for most hwmods were removed, so the older
method doesn't work anyway.
Cc: Andy Gross <andygro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Archit Taneja <archit-l0cyMroinI0@public.gmane.org>
---
arch/arm/mach-omap2/display.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index d097d23..e0642bd 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -126,20 +126,8 @@ static int __init omapdrm_init(void)
{
int r = 0;
- /* create DRM and DMM device */
+ /* create DRM device(DMM device created via DT) */
if (omap_drm_device != NULL) {
- struct omap_hwmod *oh = NULL;
- struct platform_device *pdev;
-
- /* lookup and populate the DMM information, if present - OMAP4+ */
- oh = omap_hwmod_lookup("dmm");
- if (oh) {
- pdev = omap_device_build(oh->name, -1, oh, NULL, 0);
- WARN(IS_ERR(pdev),
- "Could not build omap_device for %s\n",
- oh->name);
- }
-
platform_drm_data.omaprev = GET_OMAP_TYPE;
r = platform_device_register(omap_drm_device);
@@ -464,7 +452,7 @@ int __init omap_display_init(struct omap_dss_board_info *board_data)
}
}
- /* create DRM and DMM device */
+ /* create DRM device */
r = omapdrm_init();
if (r < 0) {
pr_err("Unable to register omapdrm device\n");
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-13 9:14 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 9:14 [PATCH 0/4] arm: omap: DMM DT adaptation Archit Taneja
2013-09-13 9:14 ` [PATCH 1/4] arm: omap: display: Create omapdrm inside omap_display_init Archit Taneja
[not found] ` <1379063679-4869-2-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:24 ` Tomi Valkeinen
2013-09-13 9:38 ` Archit Taneja
[not found] ` <5232DCFE.5050700-l0cyMroinI0@public.gmane.org>
2013-09-13 9:39 ` Archit Taneja
[not found] ` <5232DD53.3010706-l0cyMroinI0@public.gmane.org>
2013-09-13 9:48 ` Tomi Valkeinen
[not found] ` <5232DF61.6000109-l0cyMroinI0@public.gmane.org>
2013-09-13 9:51 ` Archit Taneja
2013-09-13 10:02 ` Tomi Valkeinen
2013-09-13 10:17 ` Archit Taneja
2013-09-13 10:24 ` Tomi Valkeinen
[not found] ` <5232E7E2.7050606-l0cyMroinI0@public.gmane.org>
2013-09-13 10:32 ` Archit Taneja
2013-09-13 9:42 ` Tomi Valkeinen
[not found] ` <1379063679-4869-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:14 ` [PATCH 2/4] ARM: dts: OMAP4+: Add DMM bindings Archit Taneja
2013-09-13 9:14 ` [PATCH 3/4] drm: omap: Enable DT support for DMM Archit Taneja
[not found] ` <1379063679-4869-4-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 14:14 ` Rob Clark
[not found] ` <CAF6AEGu7eRFhrQZUD-43AOHNQtRWeyxYga1dnir=qUo1mQ9ebA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-16 6:28 ` Archit Taneja
[not found] ` <5236A503.90507-l0cyMroinI0@public.gmane.org>
2013-09-16 11:56 ` Rob Clark
2013-09-13 9:14 ` Archit Taneja [this message]
[not found] ` <1379063679-4869-5-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-13 9:29 ` [PATCH 4/4] arm: omap: display: Don't build device " Tomi Valkeinen
2013-09-16 9:30 ` [PATCH v2 0/2] DMM DT adaptation Archit Taneja
2013-09-16 9:30 ` [PATCH v2 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2013-09-16 11:19 ` Tomi Valkeinen
[not found] ` <5236E940.9070503-l0cyMroinI0@public.gmane.org>
2013-09-16 12:25 ` Archit Taneja
2013-09-16 9:30 ` [PATCH v2 2/2] drm: omap: Enable DT support for DMM Archit Taneja
[not found] ` <1379323815-14130-1-git-send-email-archit-l0cyMroinI0@public.gmane.org>
2013-09-16 11:30 ` [PATCH v2 0/2] DMM DT adaptation Tomi Valkeinen
2013-10-10 6:36 ` [PATCH v3 " Archit Taneja
2013-10-10 6:36 ` [PATCH v3 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2013-10-10 10:08 ` Mark Rutland
2013-10-10 10:36 ` Archit Taneja
2013-10-10 6:36 ` [PATCH v3 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2013-10-15 7:04 ` [PATCH v4 0/2] DMM DT adaptation Archit Taneja
2013-10-15 7:04 ` [PATCH v4 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2014-03-11 7:15 ` Tomi Valkeinen
2014-03-11 8:14 ` Archit Taneja
2013-10-15 7:04 ` [PATCH v4 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2013-11-01 0:40 ` Mark Rutland
2013-11-05 5:50 ` Archit Taneja
2013-12-17 10:02 ` [PATCH v5 0/2] DMM DT adaptation Archit Taneja
2013-12-17 10:02 ` [PATCH v5 1/2] arm: dts: omap4+: Add DMM bindings Archit Taneja
2014-03-02 19:53 ` Benoit Cousson
2013-12-17 10:02 ` [PATCH v5 2/2] drm: omap: Enable DT support for DMM Archit Taneja
2014-01-03 12:34 ` [PATCH v5 0/2] DMM DT adaptation Archit Taneja
2014-01-17 7:32 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379063679-4869-5-git-send-email-archit@ti.com \
--to=archit-l0cymroini0@public.gmane.org \
--cc=andygro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).