From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v2] clk: si570: Add a driver for SI570 oscillators Date: Wed, 18 Sep 2013 16:02:41 -0700 Message-ID: <1379545361.1787.87.camel@joe-AO722> References: <1379544219-23579-1-git-send-email-soren.brinkmann@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379544219-23579-1-git-send-email-soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Soren Brinkmann Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Mike Turquette , Grant Likely , Guenter Roeck , Sebastian Hesselbarth , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Hyun Kwon List-Id: devicetree@vger.kernel.org On Wed, 2013-09-18 at 15:43 -0700, Soren Brinkmann wrote: > Add a driver for SILabs 570, 571, 598, 599 programmable oscillators. > The devices generate low-jitter clock signals and are reprogrammable via > an I2C interface. [] > v2: [] > - use 10000 as MIN and MAX value in usleep_range [] > diff --git a/drivers/clk/clk-si570.c b/drivers/clk/clk-si570.c [] > +static int si570_set_frequency(struct clk_si570 *data, unsigned long frequency) > +{ [] > + /* Applying a new frequency can take up to 10ms */ > + usleep_range(10000, 10000); Generally it's nicer to have an actual range for usleep_range. Is there a bit you could periodically poll to see if the new frequency has been set or is stable so that a 10ms delay isn't always used? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html