devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	linux-rockchip <linux-rockchip@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v1 0/4] Add Rockchip RGA support
Date: Mon, 28 Mar 2016 20:44:44 +0200	[thread overview]
Message-ID: <13797722.SiyveTZ1bB@diego> (raw)
In-Reply-To: <CACvgo513q-Vtm2wG4Cwh4G1u0OUNVAAFmHFv-kg4fHDEy7i_eg@mail.gmail.com>

Am Montag, 28. März 2016, 13:21:02 schrieb Emil Velikov:
> On 22 March 2016 at 00:42, Heiko Stuebner <heiko@sntech.de> wrote:
> > Hi Yakir,
> > 
> > Am Montag, 21. März 2016, 20:17:46 schrieb Yakir Yang:
> >> On 03/21/2016 07:29 PM, Heiko Stübner wrote:
> >> > Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang:
> >> >> This patch set would add the RGA direct rendering based 2d graphics
> >> >> acceleration module.
> >> > 
> >> > very cool to see that.
> >> 
> >> ;)
> >> 
> >> >> This patch set is based on git repository below:
> >> >> git://people.freedesktop.org/~airlied/linux drm-next
> >> >> commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7
> >> >> 
> >> >> And the RGA driver is based on Exynos G2D driver, it only manages the
> >> >> command lists received from user, so user should make the command list
> >> >> to data and registers needed by operation to use.
> >> >> 
> >> >> I have prepared an userspace demo application for testing:
> >> >>    https://github.com/yakir-Yang/libdrm-rockchip
> >> >> 
> >> >> That is a rockchip libdrm library, and I have write a simple test case
> >> >> "rockchip_rga_test" that would test the below RGA features:
> >> >> - solid
> >> >> - copy
> >> >> - rotation
> >> >> - flip
> >> >> - window clip
> >> >> - dithering
> >> > 
> >> > Did you submit your libdrm changes as well?
> >> > 
> >> > Userspace-interfaces need to be stable so the other side must also get
> >> > accepted - even before the kernel change if I remember correctly.
> >> 
> >> Got it, and I just saw exynos_fimg2d already landed at mainline libdrm.
> >> But I don't find the way to submit patches to libdrm, would you like
> >> share some helps here ;)
> > 
> > Looking at the libdrm sources on cgit.freedesktop.org, I did not find any
> > specific manual on submitting patches.
> > 
> > But looking at the dri-list archive, dri-devel@lists.freedesktop.org is
> > the
> > right list and looking at the libdrm history it looks like Emil Velikov
> > <emil.l.velikov@gmail.com> seems to be doing maintenance-stuff in libdrm.
> > And as a 3rd recipient, please also include the linux-rockchip list.
> > 
> > @Emil, please shout if I read that wrong :-)
> 
> You got it spot on Heiko. There are a few notes though...
> 
> As one reuses the existing hardware/IP block, it would be better to
> avoid copy/pasting code around.
> Namely:
>  - (if possible) factor out the exynos g2d kernel functionality to a
> separate kernel module and wire up the rockhip (via dt ?) to use it
>  - factor out the g2d specifics out of exynos_drm.h (into
> exynos_g2d_drm.h perhaps ?) and make sure exynos_drm.h includes the
> new header

I think the IP blocks themself are quite different between Rockchip's RGA and 
Samsung's g2d and I guess the similarities are more along the lines on how 
that gets integrated into the respective drm driver and userspace.


>  - if neither of these are possible, then please ensure that the new
> header uses correct types (see the docs [1]), use MIT/X11 license (if
> possible) and link where upstream userspace is happy with the
> interface (ideally more than a simple test app like libdrm)
> These might sound like an overkill, although getting UAPI right and
> maintaining it forever forces us to do so.

As for a real-world usecase, maybe the armsoc xserver might be somewhat easy 
to use. While the core changes I did are in the core project already, I'm 
still keeping the actual Rockchip support separate [0] due to the not-yet-
resolved create_gem ioctl.

Anyway, the armsoc xserver has some exa implementation hooks were I guess it 
might be relatively easy to hook up soc-specific things.

[0] https://github.com/mmind/xf86-video-armsoc/tree/devel/rockchip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-03-28 18:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21  9:28 [RFC PATCH v1 0/4] Add Rockchip RGA support Yakir Yang
2016-03-21  9:38 ` [RFC PATCH v1 1/4] drm: rockchip: add a common subdrv interfaces Yakir Yang
2016-03-21  9:40 ` [RFC PATCH v1 2/4] drm: rockchip: add RGA driver support Yakir Yang
     [not found]   ` <1458553206-26880-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-30 18:34     ` Rob Clark
     [not found] ` <1458552518-25527-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-21  9:42   ` [RFC PATCH v1 3/4] ARM: dts: rockchip: add RGA device node for RK3288 Yakir Yang
2016-03-21  9:42 ` [RFC PATCH v1 4/4] ARM: dst: rockchip: enable RGA support on veyron devices Yakir Yang
2016-03-21 11:29 ` [RFC PATCH v1 0/4] Add Rockchip RGA support Heiko Stübner
2016-03-21 12:17   ` Yakir Yang
2016-03-22  0:42     ` Heiko Stuebner
2016-03-22  2:14       ` Yakir Yang
2016-03-28 12:21       ` Emil Velikov
2016-03-28 18:44         ` Heiko Stübner [this message]
2016-03-28 21:35           ` Emil Velikov
     [not found]             ` <CACvgo52vL5_HQfgfnxRMzSJXYw-sWT3QozZaWswQXHr9-bwBSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-28 21:46               ` Heiko Stübner
2016-03-28 22:07                 ` Emil Velikov
2016-03-28 22:13                   ` Heiko Stübner
2016-03-29 13:13                     ` Emil Velikov
     [not found]                       ` <CACvgo50REvRxN2_qdw=2NeTTSgjpA+9c8OZgPE0q19meH6ArKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-30 20:03                         ` Emil Velikov
2016-04-05  1:13                           ` Mark yao
2016-03-29 11:17             ` Yakir Yang
2016-03-29 11:47               ` Heiko Stübner
2016-03-29 11:40         ` Yakir Yang
     [not found]           ` <56FA69C5.5090602-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-29 13:27             ` Emil Velikov
2016-03-22 10:24     ` Andreas Färber
2016-03-29 11:45       ` Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13797722.SiyveTZ1bB@diego \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).