From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 2/5] dt-bindings: adv7511: Add support for i2c_new_secondary_device Date: Tue, 13 Feb 2018 14:10:23 +0200 Message-ID: <138061694.kW5LlSP0Rd@avalon> References: <1518473273-6333-1-git-send-email-kbingham@kernel.org> <1518473273-6333-3-git-send-email-kbingham@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1518473273-6333-3-git-send-email-kbingham@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Kieran Bingham Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jean-Michel Hautbois , Sergei Shtylyov , Lars-Peter Clausen , Kieran Bingham , David Airlie , Rob Herring , Mark Rutland , John Stultz , Hans Verkuil , Mark Brown , Archit Taneja , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" List-Id: devicetree@vger.kernel.org Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:50 EET Kieran Bingham wrote: > From: Kieran Bingham >=20 > The ADV7511 has four 256-byte maps that can be accessed via the main I=B2C > ports. Each map has it own I=B2C address and acts as a standard slave > device on the I=B2C bus. >=20 > Extend the device tree node bindings to be able to override the default > addresses so that address conflicts with other devices on the same bus > may be resolved at the board description level. >=20 > Signed-off-by: Kieran Bingham > Reviewed-by: Rob Herring Same comment as for 1/5 about the subject line. > --- > v2: > - Fixed up reg: property description to account for multiple optional > addresses. > - Minor reword to commit message to account for DT only change > - Collected Robs RB tag >=20 > v3: > - Split map register addresses into individual declarations. >=20 > .../devicetree/bindings/display/bridge/adi,adv7511.txt | 18 ++++++++++++= +-- > 1 file changed, 16 insertions(+), 2 deletions(-) >=20 > diff --git > a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt > b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt index > 0047b1394c70..3f85c351dd39 100644 > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt > @@ -14,7 +14,13 @@ Required properties: > "adi,adv7513" > "adi,adv7533" >=20 > -- reg: I2C slave address > +- reg: I2C slave addresses > + The ADV7511 internal registers are split into four pages exposed throu= gh > + different I2C addresses, creating four register maps. Each map has it = own > + I2C address and acts as a standard slave device on the I=B2C bus. The = main > + address is mandatory, others are optional and revert to defaults if not > + specified. Nitpicking again, you're mixing I2C and I=B2C. > + >=20 > The ADV7511 supports a large number of input data formats that differ by > their color depth, color format, clock mode, bit justification and random > @@ -70,6 +76,9 @@ Optional properties: > rather than generate its own timings for HDMI output. > - clocks: from common clock binding: reference to the CEC clock. > - clock-names: from common clock binding: must be "cec". > +- reg-names : Names of maps with programmable addresses. > + It can contain any map needing a non-default address. > + Possible maps names are : "main", "edid", "cec", "packet" >=20 > Required nodes: >=20 > @@ -88,7 +97,12 @@ Example >=20 > adv7511w: hdmi@39 { > compatible =3D "adi,adv7511w"; > - reg =3D <39>; > + /* > + * The EDID page will be accessible on address 0x66 on the i2c And now you're using lowercase :-) > + * bus. All other maps continue to use their default addresses. > + */ > + reg =3D <0x39>, <0x66>; > + reg-names =3D "main", "edid"; > interrupt-parent =3D <&gpio3>; > interrupts =3D <29 IRQ_TYPE_EDGE_FALLING>; > clocks =3D <&cec_clock>; With these fixed (or not, up to you), Reviewed-by: Laurent Pinchart =2D-=20 Regards, Laurent Pinchart