From: Roger Quadros <rogerq@ti.com>
To: gregkh@linuxfoundation.org, balbi@ti.com
Cc: devicetree@vger.kernel.org, george.cherian@ti.com,
sergei.shtylyov@cogentembedded.com, tony@atomide.com,
bigeasy@linutronix.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kishon@ti.com,
thomas.langer@lantiq.com, bcousson@baylibre.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH v8 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev()
Date: Thu, 3 Oct 2013 18:12:33 +0300 [thread overview]
Message-ID: <1380813157-22311-5-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1380813157-22311-1-git-send-email-rogerq@ti.com>
omap_get_control_dev() is being deprecated as it doesn't support
multiple instances. As control device is present only from OMAP4
onwards which supports DT only, we use phandles to get the
reference to the control device.
As we don't support non-DT boot, we just bail out on probe
if device node is not present.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/usb/phy/phy-omap-usb3.c | 26 ++++++++++++++++++++------
1 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/phy/phy-omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c
index 0824be4..0c6ba29 100644
--- a/drivers/usb/phy/phy-omap-usb3.c
+++ b/drivers/usb/phy/phy-omap-usb3.c
@@ -26,6 +26,7 @@
#include <linux/pm_runtime.h>
#include <linux/delay.h>
#include <linux/usb/omap_control_usb.h>
+#include <linux/of_platform.h>
#define PLL_STATUS 0x00000004
#define PLL_GO 0x00000008
@@ -196,8 +197,14 @@ static int omap_usb3_init(struct usb_phy *x)
static int omap_usb3_probe(struct platform_device *pdev)
{
- struct omap_usb *phy;
- struct resource *res;
+ struct omap_usb *phy;
+ struct resource *res;
+ struct device_node *node = pdev->dev.of_node;
+ struct device_node *control_node;
+ struct platform_device *control_pdev;
+
+ if (!node)
+ return -EINVAL;
phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
if (!phy) {
@@ -239,11 +246,18 @@ static int omap_usb3_probe(struct platform_device *pdev)
return -EINVAL;
}
- phy->control_dev = omap_get_control_dev();
- if (IS_ERR(phy->control_dev)) {
- dev_dbg(&pdev->dev, "Failed to get control device\n");
- return -ENODEV;
+ control_node = of_parse_phandle(node, "ctrl-module", 0);
+ if (!control_node) {
+ dev_err(&pdev->dev, "Failed to get control device phandle\n");
+ return -EINVAL;
}
+ control_pdev = of_find_device_by_node(control_node);
+ if (!control_pdev) {
+ dev_err(&pdev->dev, "Failed to get control device\n");
+ return -EINVAL;
+ }
+
+ phy->control_dev = &control_pdev->dev;
omap_control_usb_phy_power(phy->control_dev, 0);
usb_add_phy_dev(&phy->phy);
--
1.7.4.1
next prev parent reply other threads:[~2013-10-03 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 15:12 [PATCH v8 0/8][RESEND] phy: omap-usb: Support multiple instances and new types Roger Quadros
2013-10-03 15:12 ` [PATCH v8 1/8] usb: phy: omap-control: Get rid of platform data Roger Quadros
2013-10-03 15:12 ` [PATCH v8 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power() Roger Quadros
2013-10-03 15:12 ` [PATCH v8 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev() Roger Quadros
2013-10-03 15:12 ` Roger Quadros [this message]
2013-10-03 15:12 ` [PATCH v8 5/8] usb: musb: omap2430: " Roger Quadros
2013-10-03 15:12 ` [PATCH v8 6/8] usb: phy: omap: get rid of omap_get_control_dev() Roger Quadros
[not found] ` <1380813157-22311-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-10-03 15:12 ` [PATCH v8 7/8] ARM: dts: omap4: update omap-control-usb nodes Roger Quadros
2013-10-03 15:12 ` [PATCH v8 8/8] ARM: dts: omap5: update omap-control-usb node Roger Quadros
-- strict thread matches above, loose matches on Subject: below --
2013-10-03 9:58 [PATCH v8 0/8] phy: omap-usb: Support multiple instances and new types Roger Quadros
2013-10-03 9:59 ` [PATCH v8 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev() Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380813157-22311-5-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.langer@lantiq.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).