devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rahul Sharma <rahul.sharma@samsung.com>
To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Cc: kgene.kim@samsung.com, sw0312.kim@samsung.com,
	inki.dae@samsung.com, seanpaul@chromium.org,
	tomasz.figa@gmail.com, s.nawrocki@samsung.com, joshi@samsung.com,
	r.sh.open@gmail.com, Rahul Sharma <rahul.sharma@samsung.com>
Subject: [PATCH v2 5/7] exynos/drm: fix ddc i2c device probe failure
Date: Tue, 22 Oct 2013 15:41:06 +0530	[thread overview]
Message-ID: <1382436668-15813-6-git-send-email-rahul.sharma@samsung.com> (raw)
In-Reply-To: <1382436668-15813-1-git-send-email-rahul.sharma@samsung.com>

Exynos hdmi ddc is a I2C device and if we register hdmi ddc
driver with id_table as NULL, cause failure in probing.

id_table field should not be NULL for i2c_driver registeration.

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_ddc.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_ddc.c b/drivers/gpu/drm/exynos/exynos_ddc.c
index 6a8c84e..54ead55 100644
--- a/drivers/gpu/drm/exynos/exynos_ddc.c
+++ b/drivers/gpu/drm/exynos/exynos_ddc.c
@@ -51,12 +51,17 @@ static struct of_device_id hdmiddc_match_types[] = {
 	}
 };
 
+static struct i2c_device_id ddc_idtable[] = {
+	{ },
+};
+
 struct i2c_driver ddc_driver = {
 	.driver = {
 		.name = "exynos-hdmiddc",
 		.owner = THIS_MODULE,
 		.of_match_table = hdmiddc_match_types,
 	},
+	.id_table	= ddc_idtable,
 	.probe		= s5p_ddc_probe,
 	.remove		= s5p_ddc_remove,
 	.command		= NULL,
-- 
1.7.10.4

  parent reply	other threads:[~2013-10-22 10:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 10:11 [PATCH v2 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver Rahul Sharma
2013-10-22 10:11 ` [PATCH v2 1/7] drm/exynos: move hdmiphy code to hdmiphy i2c driver Rahul Sharma
2013-10-22 10:11 ` [PATCH v2 2/7] drm/exynos: remove dummy hdmiphy clock Rahul Sharma
2013-10-22 10:11 ` [PATCH v2 3/7] drm/exynos: add hdmiphy platform driver for exynos5420 Rahul Sharma
2013-10-22 10:11 ` [PATCH v2 4/7] drm/exynos: add hdmiphy pmu bit control in hdmiphy drivers Rahul Sharma
2013-10-22 10:11 ` Rahul Sharma [this message]
2013-10-22 10:11 ` [PATCH v2 6/7] ARM: dts: update hdmiphy dt node for exynos5250 Rahul Sharma
     [not found] ` <1382436668-15813-1-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-22 10:11   ` [PATCH v2 7/7] ARM: dts: update hdmiphy dt node for exynos5420 Rahul Sharma
2013-10-28 13:40 ` [PATCH v2 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver Inki Dae
2013-10-29  3:36   ` Rahul Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382436668-15813-6-git-send-email-rahul.sharma@samsung.com \
    --to=rahul.sharma@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=joshi@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=r.sh.open@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=seanpaul@chromium.org \
    --cc=sw0312.kim@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).