devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>,
	Russell King <linux@arm.linux.org.uk>,
	Tomasz Figa <t.figa@samsung.com>
Cc: Olof Johansson <olof@lixom.net>,
	Dave Martin <Dave.Martin@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	Kevin Hilman <khilman@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v9 4/5] ARM: tegra: set CPU reset handler with firmware op
Date: Mon, 28 Oct 2013 19:28:37 +0900	[thread overview]
Message-ID: <1382956118-12495-5-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1382956118-12495-1-git-send-email-acourbot@nvidia.com>

Use a firmware operation to set the CPU reset handler and only resort to
doing it ourselves if there is none defined.

This supports the booting of secondary CPUs on devices using a TrustZone
secure monitor.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/mach-tegra/reset.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-tegra/reset.c b/arch/arm/mach-tegra/reset.c
index e282395..368af0a 100644
--- a/arch/arm/mach-tegra/reset.c
+++ b/arch/arm/mach-tegra/reset.c
@@ -21,6 +21,7 @@
 
 #include <asm/cacheflush.h>
 #include <asm/hardware/cache-l2x0.h>
+#include <asm/firmware.h>
 
 #include "iomap.h"
 #include "irammap.h"
@@ -65,6 +66,7 @@ static void __init tegra_cpu_reset_handler_enable(void)
 	void __iomem *iram_base = IO_ADDRESS(TEGRA_IRAM_RESET_BASE);
 	const u32 reset_address = TEGRA_IRAM_RESET_BASE +
 						tegra_cpu_reset_handler_offset;
+	int err;
 
 	BUG_ON(is_enabled);
 	BUG_ON(tegra_cpu_reset_handler_size > TEGRA_IRAM_RESET_HANDLER_SIZE);
@@ -72,9 +74,18 @@ static void __init tegra_cpu_reset_handler_enable(void)
 	memcpy(iram_base, (void *)__tegra_cpu_reset_handler_start,
 			tegra_cpu_reset_handler_size);
 
-	tegra_cpu_reset_handler_set(reset_address);
-
-	is_enabled = true;
+	err = call_firmware_op(set_cpu_boot_addr, 0, reset_address);
+	switch (err) {
+	case -ENOSYS:
+		tegra_cpu_reset_handler_set(reset_address);
+		/* pass-through */
+	case 0:
+		is_enabled = true;
+		break;
+	default:
+		pr_crit("Cannot set CPU reset handler: %d\n", err);
+		BUG();
+	}
 }
 
 void __init tegra_cpu_reset_handler_init(void)
-- 
1.8.4.1

  parent reply	other threads:[~2013-10-28 10:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 10:28 [PATCH v9 0/5] ARM: support for Trusted Foundations secure monitor Alexandre Courbot
2013-10-28 10:28 ` [PATCH v9 1/5] ARM: add basic support for Trusted Foundations Alexandre Courbot
2013-10-28 10:57   ` Kumar Gala
     [not found]     ` <D49A3E92-54FD-4275-82F5-DBB476086B03-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-10-28 21:56       ` Olof Johansson
     [not found]         ` <20131028215649.GB10833-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2013-10-28 23:31           ` Tomasz Figa
2013-10-29  0:25             ` Mark Rutland
2013-10-29  8:12               ` Kumar Gala
     [not found]                 ` <0232E02C-5F41-4EC6-9011-86D67005433D-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-10-29 18:39                   ` Matt Porter
2013-10-30  3:07                   ` Alex Courbot
2013-10-28 10:28 ` [PATCH v9 2/5] ARM: tegra: add " Alexandre Courbot
2013-10-28 10:28 ` [PATCH v9 3/5] ARM: tegra: split setting of CPU reset handler Alexandre Courbot
     [not found]   ` <1382956118-12495-4-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-29  0:18     ` Mark Rutland
2013-10-28 10:28 ` Alexandre Courbot [this message]
     [not found] ` <1382956118-12495-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-28 10:28   ` [PATCH v9 5/5] ARM: tegra: support Trusted Foundations by default Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382956118-12495-5-git-send-email-acourbot@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=Dave.Martin@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).