* [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi
@ 2013-10-30 10:05 Sachin Kamat
2013-10-30 10:05 ` [PATCH 2/2] ARM: dts: Update Samsung sysreg binding document Sachin Kamat
2013-10-30 14:44 ` [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Tomasz Figa
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-10-30 10:05 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree, kgene.kim, sachin.kamat
Fix the name as per DT node naming convention.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e262946..68479c3 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -99,7 +99,7 @@
reg = <0x10440000 0x1000>;
};
- sys_reg: sysreg {
+ sys_reg: sysreg@10010000 {
compatible = "samsung,exynos4-sysreg", "syscon";
reg = <0x10010000 0x400>;
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] ARM: dts: Update Samsung sysreg binding document
2013-10-30 10:05 [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Sachin Kamat
@ 2013-10-30 10:05 ` Sachin Kamat
2013-10-30 14:44 ` [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Tomasz Figa
1 sibling, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-10-30 10:05 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree, kgene.kim, sachin.kamat
Added a binding example for reference.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
.../devicetree/bindings/arm/samsung/sysreg.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
index 5039c0a..7090178 100644
--- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
@@ -5,3 +5,9 @@ Properties:
- compatible : should contain "samsung,<chip name>-sysreg", "syscon";
For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon";
- reg : offset and length of the register set.
+
+Example:
+ sys_reg: sysreg@10010000 {
+ compatible = "samsung,exynos4-sysreg", "syscon";
+ reg = <0x10010000 0x400>;
+ };
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi
2013-10-30 10:05 [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Sachin Kamat
2013-10-30 10:05 ` [PATCH 2/2] ARM: dts: Update Samsung sysreg binding document Sachin Kamat
@ 2013-10-30 14:44 ` Tomasz Figa
1 sibling, 0 replies; 3+ messages in thread
From: Tomasz Figa @ 2013-10-30 14:44 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-samsung-soc, devicetree, kgene.kim
Hi Sachin,
On Wednesday 30 of October 2013 15:35:53 Sachin Kamat wrote:
> Fix the name as per DT node naming convention.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e262946..68479c3 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -99,7 +99,7 @@
> reg = <0x10440000 0x1000>;
> };
>
> - sys_reg: sysreg {
> + sys_reg: sysreg@10010000 {
While at changing node name, could you rename it to syscon? Nodes
should have more generic names, while sysreg is an Exynos-specific term.
Best regards.
Tomasz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-30 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 10:05 [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Sachin Kamat
2013-10-30 10:05 ` [PATCH 2/2] ARM: dts: Update Samsung sysreg binding document Sachin Kamat
2013-10-30 14:44 ` [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Tomasz Figa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).