From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lad, Prabhakar" Subject: [PATCH v4 2/6] gpio: davinci: remove unnecessary printk Date: Sat, 2 Nov 2013 21:09:31 +0530 Message-ID: <1383406775-14902-3-git-send-email-prabhakar.csenng@gmail.com> References: <1383406775-14902-1-git-send-email-prabhakar.csenng@gmail.com> Return-path: In-Reply-To: <1383406775-14902-1-git-send-email-prabhakar.csenng@gmail.com> Sender: linux-doc-owner@vger.kernel.org To: Sekhar Nori , Linus Walleij , devicetree@vger.kernel.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Grant Likely , Alex Elder , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, davinci-linux-open-source@linux.davincidsp.com, linux-gpio@vger.kernel.org, Lad Prabhakar , Grygorii Strashko List-Id: devicetree@vger.kernel.org From: "Lad, Prabhakar" the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 6c90cfb..95c6df1 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) } clk = devm_clk_get(dev, "gpio"); - if (IS_ERR(clk)) { - printk(KERN_ERR "Error %ld getting gpio clock?\n", - PTR_ERR(clk)); + if (IS_ERR(clk)) return PTR_ERR(clk); - } + clk_prepare_enable(clk); /* -- 1.7.9.5