[PATCH v3 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[PATCH v3 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[Sachin Kamat]

Fix the name as per DT node naming convention.
- rename the node to syscon which is a more generic name.
- append the register value to the node name.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
Changes since v2:
None.
---
 arch/arm/boot/dts/exynos4.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index cb0f70cc552b..b7378154c0a1 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -99,7 +99,7 @@
 		reg = <0x10440000 0x1000>;
 	};
 
-	sys_reg: sysreg {
+	sys_reg: syscon@10010000 {
 		compatible = "samsung,exynos4-sysreg", "syscon";
 		reg = <0x10010000 0x400>;
 	};
-- 
1.7.9.5

[PATCH v3 2/2] ARM: dts: Update Samsung sysreg binding document

[Sachin Kamat]

Added a binding example for reference and updated the
node name. While at it also removed the name description
as it is not necessary.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
Changes since v2:
* Removed node name description as suggested by Tomasz Figa.
---
 .../devicetree/bindings/arm/samsung/sysreg.txt     |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
index 5039c0a12f55..0ab3251a6ec2 100644
--- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
@@ -1,7 +1,12 @@
 SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
 
 Properties:
- - name : should be 'sysreg';
  - compatible : should contain "samsung,<chip name>-sysreg", "syscon";
    For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon";
  - reg : offset and length of the register set.
+
+Example:
+	syscon@10010000 {
+		compatible = "samsung,exynos4-sysreg", "syscon";
+		reg = <0x10010000 0x400>;
+	};
-- 
1.7.9.5

Re: [PATCH v3 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[Sylwester Nawrocki]

On 05/11/13 07:18, Sachin Kamat wrote:
> Fix the name as per DT node naming convention.
> - rename the node to syscon which is a more generic name.
> - append the register value to the node name.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Thanks Sachin.

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Re: [PATCH v3 2/2] ARM: dts: Update Samsung sysreg binding document

[Sylwester Nawrocki]

On 05/11/13 07:18, Sachin Kamat wrote:
> Added a binding example for reference and updated the
> node name. While at it also removed the name description
> as it is not necessary.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

I'm not sure we need an example in each and every binding,
but anyway

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

> ---
> Changes since v2:
> * Removed node name description as suggested by Tomasz Figa.
> ---
>  .../devicetree/bindings/arm/samsung/sysreg.txt     |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> index 5039c0a12f55..0ab3251a6ec2 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> @@ -1,7 +1,12 @@
>  SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
>  
>  Properties:
> - - name : should be 'sysreg';
>   - compatible : should contain "samsung,<chip name>-sysreg", "syscon";
>     For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon";
>   - reg : offset and length of the register set.
> +
> +Example:
> +	syscon@10010000 {
> +		compatible = "samsung,exynos4-sysreg", "syscon";
> +		reg = <0x10010000 0x400>;
> +	};

--
Thanks,
Sylwester

RE: [PATCH v3 2/2] ARM: dts: Update Samsung sysreg binding document

[Kukjin Kim]

Sachin Kamat wrote:
> 
> Added a binding example for reference and updated the
> node name. While at it also removed the name description
> as it is not necessary.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Changes since v2:
> * Removed node name description as suggested by Tomasz Figa.
> ---
>  .../devicetree/bindings/arm/samsung/sysreg.txt     |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> index 5039c0a12f55..0ab3251a6ec2 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> @@ -1,7 +1,12 @@
>  SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
> 
>  Properties:
> - - name : should be 'sysreg';
>   - compatible : should contain "samsung,<chip name>-sysreg", "syscon";
>     For Exynos4 SoC series it should be "samsung,exynos4-sysreg",
"syscon";
>   - reg : offset and length of the register set.
> +
> +Example:
> +	syscon@10010000 {
> +		compatible = "samsung,exynos4-sysreg", "syscon";
> +		reg = <0x10010000 0x400>;
> +	};
> --
> 1.7.9.5

Looks OK to me.

DT guys, shall I pick this into Samsung tree or not?

Thanks,
Kukjin

RE: [PATCH v3 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[Kukjin Kim]

Sachin Kamat wrote:
> 
> Fix the name as per DT node naming convention.
> - rename the node to syscon which is a more generic name.
> - append the register value to the node name.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
> Changes since v2:
> None.
> ---
>  arch/arm/boot/dts/exynos4.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> b/arch/arm/boot/dts/exynos4.dtsi
> index cb0f70cc552b..b7378154c0a1 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -99,7 +99,7 @@
>  		reg = <0x10440000 0x1000>;
>  	};
> 
> -	sys_reg: sysreg {
> +	sys_reg: syscon@10010000 {
>  		compatible = "samsung,exynos4-sysreg", "syscon";
>  		reg = <0x10010000 0x400>;
>  	};
> --
> 1.7.9.5

Looks good to me, thanks for this patch and reviews from Sylwester and
Tomasz.

Applied.
- Kukjin