* [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt
@ 2013-11-05 6:57 Sachin Kamat
2013-11-08 10:28 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-11-05 6:57 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
lee.jones-QSEj5FYQhm4dnm+yROfE0A, rob-VoJi6FS/r0vR7s880joybQ,
sachin.kamat-QSEj5FYQhm4dnm+yROfE0A
Fixed trivial typos to improve readability.
Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
Documentation/devicetree/bindings/mfd/s2mps11.txt | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
index c9332c6..0ff4e65 100644
--- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
+++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
@@ -1,10 +1,10 @@
* Samsung S2MPS11 Voltage and Current Regulator
-The Samsung S2MP211 is a multi-function device which includes voltage and
+The Samsung S2MPS11 is a multi-function device which includes voltage and
current regulators, RTC, charger controller and other sub-blocks. It is
-interfaced to the host controller using a I2C interface. Each sub-block is
-addressed by the host system using different I2C slave address.
+interfaced to the host controller using an I2C interface. Each sub-block is
+addressed by the host system using different I2C slave addresses.
Required properties:
- compatible: Should be "samsung,s2mps11-pmic".
@@ -43,7 +43,8 @@ sub-node should be of the format as listed below.
BUCK[2/3/4/6] supports disabling ramp delay on hardware, so explictly
regulator-ramp-delay = <0> can be used for them to disable ramp delay.
- In absence of regulator-ramp-delay property, default ramp delay will be used.
+ In the absence of regulator-ramp-delay property, default ramp delay will
+ be used.
NOTE: Some BUCKs share the ramp rate setting i.e. same ramp value will be set
for a particular group of BUCKs. So provide same regulator-ramp-delay<value>.
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt
2013-11-05 6:57 [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt Sachin Kamat
@ 2013-11-08 10:28 ` Lee Jones
2013-11-08 11:20 ` Sachin Kamat
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2013-11-08 10:28 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, linux-doc, devicetree, rob
As this is only a trivial patch, I'll take it out the hands of the
already overloaded DT maintainers.
> Fixed trivial typos to improve readability.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/s2mps11.txt | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index c9332c6..0ff4e65 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -1,10 +1,10 @@
>
> * Samsung S2MPS11 Voltage and Current Regulator
>
> -The Samsung S2MP211 is a multi-function device which includes voltage and
> +The Samsung S2MPS11 is a multi-function device which includes voltage and
Nice catch eagle-eye!
> current regulators, RTC, charger controller and other sub-blocks. It is
> -interfaced to the host controller using a I2C interface. Each sub-block is
> -addressed by the host system using different I2C slave address.
> +interfaced to the host controller using an I2C interface. Each sub-block is
> +addressed by the host system using different I2C slave addresses.
>
> Required properties:
> - compatible: Should be "samsung,s2mps11-pmic".
> @@ -43,7 +43,8 @@ sub-node should be of the format as listed below.
>
> BUCK[2/3/4/6] supports disabling ramp delay on hardware, so explictly
> regulator-ramp-delay = <0> can be used for them to disable ramp delay.
> - In absence of regulator-ramp-delay property, default ramp delay will be used.
> + In the absence of regulator-ramp-delay property, default ramp delay will
> + be used.
So if we're being pertinacity here, your correction isn't much better.
s/of regulator-ramp-delay property,/of {the,an} regulator-ramp-delay property, the
or
s/of regulator-ramp-delay property,/of regulator-ramp-delay, the
> NOTE: Some BUCKs share the ramp rate setting i.e. same ramp value will be set
> for a particular group of BUCKs. So provide same regulator-ramp-delay<value>.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt
2013-11-08 10:28 ` Lee Jones
@ 2013-11-08 11:20 ` Sachin Kamat
2013-11-08 11:39 ` Sachin Kamat
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-11-08 11:20 UTC (permalink / raw)
To: Lee Jones
Cc: LKML, linux-doc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Landley
On 8 November 2013 15:58, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> As this is only a trivial patch, I'll take it out the hands of the
> already overloaded DT maintainers.
>
>> Fixed trivial typos to improve readability.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> Documentation/devicetree/bindings/mfd/s2mps11.txt | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
>> index c9332c6..0ff4e65 100644
>> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
>> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
>> @@ -1,10 +1,10 @@
>>
>> * Samsung S2MPS11 Voltage and Current Regulator
>>
>> -The Samsung S2MP211 is a multi-function device which includes voltage and
>> +The Samsung S2MPS11 is a multi-function device which includes voltage and
>
> Nice catch eagle-eye!
:)
>
>> current regulators, RTC, charger controller and other sub-blocks. It is
>> -interfaced to the host controller using a I2C interface. Each sub-block is
>> -addressed by the host system using different I2C slave address.
>> +interfaced to the host controller using an I2C interface. Each sub-block is
>> +addressed by the host system using different I2C slave addresses.
>>
>> Required properties:
>> - compatible: Should be "samsung,s2mps11-pmic".
>> @@ -43,7 +43,8 @@ sub-node should be of the format as listed below.
>>
>> BUCK[2/3/4/6] supports disabling ramp delay on hardware, so explictly
>> regulator-ramp-delay = <0> can be used for them to disable ramp delay.
>> - In absence of regulator-ramp-delay property, default ramp delay will be used.
>> + In the absence of regulator-ramp-delay property, default ramp delay will
>> + be used.
>
> So if we're being pertinacity here, your correction isn't much better.
>
> s/of regulator-ramp-delay property,/of {the,an} regulator-ramp-delay property, the
I like this one :)
>
> or
>
> s/of regulator-ramp-delay property,/of regulator-ramp-delay, the
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt
2013-11-08 11:20 ` Sachin Kamat
@ 2013-11-08 11:39 ` Sachin Kamat
0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-11-08 11:39 UTC (permalink / raw)
To: Lee Jones; +Cc: LKML, linux-doc, devicetree@vger.kernel.org, Rob Landley
On 8 November 2013 16:50, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 8 November 2013 15:58, Lee Jones <lee.jones@linaro.org> wrote:
>> As this is only a trivial patch, I'll take it out the hands of the
>> already overloaded DT maintainers.
>>
>>> Fixed trivial typos to improve readability.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/mfd/s2mps11.txt | 9 +++++----
>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
>>> index c9332c6..0ff4e65 100644
>>> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
>>> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
>>> @@ -1,10 +1,10 @@
>>>
>>> * Samsung S2MPS11 Voltage and Current Regulator
>>>
>>> -The Samsung S2MP211 is a multi-function device which includes voltage and
>>> +The Samsung S2MPS11 is a multi-function device which includes voltage and
>>
>> Nice catch eagle-eye!
>
> :)
>
>>
>>> current regulators, RTC, charger controller and other sub-blocks. It is
>>> -interfaced to the host controller using a I2C interface. Each sub-block is
>>> -addressed by the host system using different I2C slave address.
>>> +interfaced to the host controller using an I2C interface. Each sub-block is
>>> +addressed by the host system using different I2C slave addresses.
>>>
>>> Required properties:
>>> - compatible: Should be "samsung,s2mps11-pmic".
>>> @@ -43,7 +43,8 @@ sub-node should be of the format as listed below.
>>>
>>> BUCK[2/3/4/6] supports disabling ramp delay on hardware, so explictly
>>> regulator-ramp-delay = <0> can be used for them to disable ramp delay.
>>> - In absence of regulator-ramp-delay property, default ramp delay will be used.
>>> + In the absence of regulator-ramp-delay property, default ramp delay will
>>> + be used.
>>
>> So if we're being pertinacity here, your correction isn't much better.
>>
>> s/of regulator-ramp-delay property,/of {the,an} regulator-ramp-delay property, the
>
> I like this one :)
>>
>> or
>>
>> s/of regulator-ramp-delay property,/of regulator-ramp-delay, the
>
Resent this patch with the above suggested changes and some more
updates and hence
with a modified subject line (Documentation/mfd: Update s2mps11.txt).
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-08 11:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-05 6:57 [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt Sachin Kamat
2013-11-08 10:28 ` Lee Jones
2013-11-08 11:20 ` Sachin Kamat
2013-11-08 11:39 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).