From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCHv7] dmaengine: Add support for BCM2835 Date: Mon, 18 Nov 2013 14:18:48 -0800 Message-ID: <1384813128.17783.3.camel@joe-AO722> References: <5288E327.8050809@koalo.de> <1384768816.14845.186.camel@smile> <528A051A.7000703@koalo.de> <1384785017.14845.214.camel@smile> <20131118145400.GE16735@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131118145400.GE16735-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russell King - ARM Linux Cc: Andy Shevchenko , Florian Meier , Stephen Warren , "Koul, Vinod" , "Williams, Dan J" , devicetree , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , Liam Girdwood , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mark Brown , linux-rpi-kernel , dmaengine , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, 2013-11-18 at 14:54 +0000, Russell King - ARM Linux wrote: > On Mon, Nov 18, 2013 at 04:30:17PM +0200, Andy Shevchenko wrote: > > On Mon, 2013-11-18 at 13:16 +0100, Florian Meier wrote: > > > >> + uint32_t chans_available; > > > > > > > > Why uint32_t? > > > > > > Because it is a bit mask of fixed length that directly comes from the > > > firmware. > > > > Like one already told you in your i2s patch, please, change that to > > corresponding u* value, namely u32. > > There's no problem with uint32_t vs u32 - either will do. u32 is the > pre-stdint.h Linux definition of a 32-bit unsigned integer. There's > no reason why uint32_t isn't perfectly acceptable. It's a matter of > author taste which gets used. (Except where modifications are to an > existing chunk of code using one or the other - where consistency then > matters more.) https://lkml.org/lkml/2006/5/2/258 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html