From: Leela Krishna Amudala <l.krishna@samsung.com>
To: linux-samsung-soc@vger.kernel.org, wim@iguana.be
Cc: dianders@chromium.org, kgene.kim@samsung.com, t.figa@samsung.com,
devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
cpgs@samsung.com, linux@roeck-us.net
Subject: [PATCH V10 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers
Date: Wed, 27 Nov 2013 17:20:07 +0530 [thread overview]
Message-ID: <1385553010-30183-1-git-send-email-l.krishna@samsung.com> (raw)
This patchset does the following things
- Adds pmusysreg device node to exynos5.dtsi file
- Adds watchdog DT nodes to Exynos5250 and 5420
- Uses syscon regmap interface to configure pmu registers
to mask/unmask enable/disable of watchdog.
This patch set is rebased on Kgene's for-next branch and tested on SMDK5420
changes since V9:
- added descriptions to s3c2410_wdt_variant structure fields
- moved calling s3c2410wdt_mask_and_disable_reset() function above s3c2410wdt_start() call in probe
- put dev_err message back to s3c2410wdt_mask_and_disable_reset() function
(suggested by Doug Anderson <dianders@chromium.org>)
changes since V8:
- modified the patch description for the below patch
"watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register"
- removed MODULE_ALIAS in watchdog driver
- changed dev_warn to dev_err in one failure case handling (suggested by Guenter Roeck <linux@roeck-us.net>)
- renamed variable name from pmu_config to drv_data
- changed the compatible field description in documentation file
(suggested by Tomasz Figa <t.figa@samsung.com>)
changes since V7:
- re-ordered the patches in the series
- moved pmu_config_s3c2410 structure out of ifdef CONFIG_OF
and limited only this structure to platform match table
- renamed structure name from s3c_wdt_driver_ids to s3c2410_wdt_ids
- removed exynos variants from platform match table
(suggested by Tomasz Figa <t.figa@samsung.com>)
changes since V6:
- added SoC-specific compatible value to syscon node and documented it
- given more patch description for below patch
ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
- added platform_device_id array for watchdog devices
- selected MFD_SYSCON in Kconfig entry for watchdog
Changes since V5:
- removed status property in DT nodes
- changed the return type for the function s3c2410wdt_mask_and_disable_reset()
and handled error cases
- Handled to get driver data in non-DT cases
- Addressed comments given by Tomasz Figa <t.figa@samsung.com>
Changes since V4:
- changed the node name from pmusysreg to syscon and node label from pmu_sys_reg to pmu_syscon
- changed the property name from samsung,pmusysreg to samsung,syscon-phandle
- used regmap_update_bits instead of remap_read/regmap_write
- Addressed other comments given by Tomasz Figa <t.figa@samsung.com>
Changes since V3:
- changed the compatible strings for watchdog node
- splitted up adding pmusysreg node and made it separate patch
- Addressed comments given by Sachin Kamat <sachin.kamat@linaro.org>
Changes since V2:
- used syscon regmap interface to configure pmu registers in WDT driver
(suggested by Tomasz Figa <t.figa@samsung.com>)
Changes since V1:
- Added new compatible string for Exynos5 SoCs
- Introduced quirk mechanism to program PMU registers
- Addressed comments given by Tomasz Figa <t.figa@samsung.com>
Leela Krishna Amudala (3):
ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files
watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu
register
ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
.../devicetree/bindings/arm/samsung/pmu.txt | 16 ++
.../devicetree/bindings/watchdog/samsung-wdt.txt | 21 ++-
arch/arm/boot/dts/exynos5.dtsi | 7 -
arch/arm/boot/dts/exynos5250.dtsi | 11 +-
arch/arm/boot/dts/exynos5420.dtsi | 14 ++
drivers/watchdog/Kconfig | 1 +
drivers/watchdog/s3c2410_wdt.c | 164 ++++++++++++++++++--
7 files changed, 216 insertions(+), 18 deletions(-)
create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
--
1.7.10.4
next reply other threads:[~2013-11-27 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 11:50 Leela Krishna Amudala [this message]
[not found] ` <1385553010-30183-1-git-send-email-l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-27 11:50 ` [PATCH V10 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files Leela Krishna Amudala
2013-11-27 11:50 ` [PATCH V10 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register Leela Krishna Amudala
2013-11-27 16:58 ` Guenter Roeck
2013-11-27 11:50 ` [PATCH V10 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420 Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385553010-30183-1-git-send-email-l.krishna@samsung.com \
--to=l.krishna@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=t.figa@samsung.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).