From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org
Cc: t.figa@samsung.com, kgene.kim@samsung.com,
grant.likely@linaro.org, rob.herring@calxeda.com,
sylvester.nawrocki@gmail.com, kishon@ti.com,
kyungmin.park@samsung.com,
Tomasz Stanislawski <t.stanislaws@samsung.com>
Subject: [PATCH] phy: Add exynos-phy driver
Date: Wed, 27 Nov 2013 14:26:27 +0100 [thread overview]
Message-ID: <1385558788-10880-1-git-send-email-t.stanislaws@samsung.com> (raw)
Hello everyone,
The Samsung SoCs from Exynos family are enhanced with a bunch of switches
dedicated for IP blocks. Those switches are called PHYs in Exynos
specification. They are usually controlled by a single bit in a single
one-word-long register.
A IP driver has to control such a switch in an abstract manner. Therefore,
such 'enablers' were implemented as clocks in older versions of Linux kernel.
With the dawn of PHY subsystems, PHYs become a natural way of exporting the
'enabler' functionality to drivers. However, there is an unexpected
consequence. Some of those 1-bit PHYs were implemented as separate drivers.
This means that one has to create a struct device, struct phy, its phy provider
and 100-150 lines of driver code to basically set one bit.
The DP phy driver is a good example:
https://lkml.org/lkml/2013/7/18/53
And simple-phy RFC (shares only driver code but not other resources):
https://lkml.org/lkml/2013/10/21/313
To avoid waste of resources I propose to create all such 1-bit phys from Exynos
SoC using a single device, driver and phy provider.
This patchset contains a proposed solution.
All comment are welcome.
Hopefully in future the functionality introduced by this patch may be merged
into a larger Power Management Unit (PMU) gluer driver. On Samsusng SoC , the
PMU part contains a number of register barely linked to power management (like
clock gating, clock dividers, CPU resetting, etc.). It may be tempting to
create a hybrid driver that export clocks/phys/etc that are controlled by PMU
unit.
Regards,
Tomasz Stanislawski
Tomasz Stanislawski (1):
phy: Add exynos-phy driver
drivers/phy/Kconfig | 5 ++
drivers/phy/Makefile | 1 +
drivers/phy/exynos-phy.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 158 insertions(+)
create mode 100644 drivers/phy/exynos-phy.c
--
1.7.9.5
next reply other threads:[~2013-11-27 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 13:26 Tomasz Stanislawski [this message]
2013-11-27 13:26 ` [PATCH] phy: Add exynos-phy driver Tomasz Stanislawski
[not found] ` <1385558788-10880-1-git-send-email-t.stanislaws-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-12-11 9:54 ` Kishon Vijay Abraham I
2013-12-11 10:16 ` Sylwester Nawrocki
2013-12-13 11:22 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385558788-10880-1-git-send-email-t.stanislaws@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).