devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: balbi@ti.com, shawn.guo@linaro.org, rob.herring@calxeda.com,
	grant.likely@linaro.org
Cc: alexander.shishkin@linux.intel.com, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, festevam@gmail.com,
	marex@denx.de, kernel@pengutronix.de, m.grzeschik@pengutronix.de,
	frank.li@freescale.com, peter.chen@freescale.com,
	gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: [PATCH v4 13/17] usb: phy-mxs: Add sync time after controller clear phcd
Date: Tue, 3 Dec 2013 15:37:07 +0800	[thread overview]
Message-ID: <1386056231-17258-14-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1386056231-17258-1-git-send-email-peter.chen@freescale.com>

After clear portsc.phcd, PHY needs 200us stable time for switch
32K clock to AHB clock.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 drivers/usb/phy/phy-mxs-usb.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index 3e25c3d..52e80d9 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -139,6 +139,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)
 	return mxs_phy->data == &imx6sl_phy_data;
 }
 
+/*
+ * PHY needs some 32K cycles to switch from 32K clock to
+ * bus (such as AHB/AXI, etc) clock.
+ */
+static void mxs_phy_clock_switch(void)
+{
+	usleep_range(300, 400);
+}
+
 static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
 {
 	int ret;
@@ -234,6 +243,7 @@ static int mxs_phy_init(struct usb_phy *phy)
 {
 	struct mxs_phy *mxs_phy = to_mxs_phy(phy);
 
+	mxs_phy_clock_switch();
 	clk_prepare_enable(mxs_phy->clk);
 	return mxs_phy_hw_init(mxs_phy);
 }
@@ -258,6 +268,7 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)
 		       x->io_priv + HW_USBPHY_CTRL_SET);
 		clk_disable_unprepare(mxs_phy->clk);
 	} else {
+		mxs_phy_clock_switch();
 		clk_prepare_enable(mxs_phy->clk);
 		writel(BM_USBPHY_CTRL_CLKGATE,
 		       x->io_priv + HW_USBPHY_CTRL_CLR);
-- 
1.7.8



      parent reply	other threads:[~2013-12-03  7:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  7:36 [PATCH v4 00/17] Add power management support for mxs phy Peter Chen
     [not found] ` <1386056231-17258-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-03  7:36   ` [PATCH v4 01/17] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-03  7:36   ` [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-03  8:38     ` Marc Kleine-Budde
     [not found]       ` <529D987C.8080905-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-12-03  8:12         ` Peter Chen
2013-12-03 10:24     ` Michael Grzeschik
     [not found]       ` <20131203102416.GB27635-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-12-03 14:09         ` Peter Chen
2013-12-03  7:36   ` [PATCH v4 03/17] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-03  7:36   ` [PATCH v4 04/17] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-03  7:36   ` [PATCH v4 05/17] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-12-03  7:37   ` [PATCH v4 06/17] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-03  7:37   ` [PATCH v4 07/17] usb: phy: add notify suspend and resume callback Peter Chen
2013-12-03  7:37   ` [PATCH v4 08/17] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-03  7:37   ` [PATCH v4 09/17] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-03  8:27     ` Marc Kleine-Budde
2013-12-03  8:38       ` Peter Chen
     [not found]         ` <F281D0F91ED19E4D8E63A7504E8A649804140F64-RL0Hj/+nBVAqqAZmXiz6tK4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-12-03  8:43           ` Marc Kleine-Budde
2013-12-03  8:49             ` Peter Chen
2013-12-03  7:37   ` [PATCH v4 11/17] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-03  7:37   ` [PATCH v4 14/17] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-03  7:37   ` [PATCH v4 15/17] usb: phy-mxs: add " Peter Chen
2013-12-03  7:37   ` [PATCH v4 16/17] usb: phy-mxs: fix the problem by only using 1st controller's register Peter Chen
2013-12-03  8:34     ` Marc Kleine-Budde
     [not found]       ` <529D9781.1080209-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-12-03  8:12         ` Peter Chen
2013-12-03  7:37   ` [PATCH v4 17/17] usb: phy-mxs: do not set PWD.RXPWD1PT1 for low speed connection Peter Chen
     [not found]     ` <1386056231-17258-18-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-03  8:53       ` Marc Kleine-Budde
2013-12-03  9:19         ` Peter Chen
2013-12-03  9:28           ` Marc Kleine-Budde
2013-12-03  9:48             ` Peter Chen
2013-12-03  7:37 ` [PATCH v4 10/17] usb: phy: Add set_wakeup API Peter Chen
2013-12-03  7:37 ` [PATCH v4 12/17] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-03  7:37 ` Peter Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386056231-17258-14-git-send-email-peter.chen@freescale.com \
    --to=peter.chen@freescale.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@freescale.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=marex@denx.de \
    --cc=rob.herring@calxeda.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).