Re: [PATCH 03/15] arm64: dts: allwinner: h616: add NAND controller

Richard GENOUD
2025-10-10T10:22:19Z

Le 10/10/2025 à 10:47, Krzysztof Kozlowski a écrit :
> On 10/10/2025 10:40, Richard Genoud wrote:
>> The H616 has a NAND controller quite similar to the A10/A23 ones, but
>> with some register differences, more clocks (for ECC and MBUS), more ECC
>> strengths, so this requires a new compatible string.
>>
>> This patch adds the NAND controller node and pins in the device tree.
>
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
You're right, I'll reformulate that.

>
>>
>> Signed-off-by: Richard Genoud <richard.genoud@bootlin.com>
>> ---
>
> Confusing order of patches. Driver code cannot depend on DTS.
>
> See submitting patches in DT. It is VERY explicit about it. Please also
> read maintainer soc profile.
Indeed, it's quite explicit in
Documentation/devicetree/bindings/submitting-patches.rst
Sorry for that.

But I don't know what you are referring to as "maintainer soc profile"
I guess soc here doesn't stand for system on chip :)

Thanks!

>
> Best regards,
> Krzysztof

--
Richard Genoud, Bootlin
Embedded Linux and Kernel engineering