* [PATCH] ARM: dts: Fix mmc node on exynos5250 snow board
@ 2013-12-05 10:06 Yuvaraj Kumar C D
[not found] ` <1386237974-2255-1-git-send-email-yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Yuvaraj Kumar C D @ 2013-12-05 10:06 UTC (permalink / raw)
To: linux-samsung-soc, kgene.kim, rob.herring, pawel.moll,
mark.rutland, swarren, ian.campbell, devicetree
Cc: t.figa, alim.akhtar, sonnyrao, dianders, Yuvaraj Kumar C D
Commits 64c138a ("ARM: dts: Move fifo-depth property from exynos5250
board dts") and 0c3de788 ("ARM: dts: change status property of dwmmc
nodes for exynos5250") missed out handling the exynos5250 snow dts file.
Delete the fifo-depth property and enable the mmc node in the snow dts
file.
Signed-off-by : Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
arch/arm/boot/dts/cros5250-common.dtsi | 7 -------
arch/arm/boot/dts/exynos5250-snow.dts | 9 +++++++++
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index 6470536..2dd70e9 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -233,7 +233,6 @@
num-slots = <1>;
supports-highspeed;
broken-cd;
- fifo-depth = <0x80>;
card-detect-delay = <200>;
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <2 3>;
@@ -247,14 +246,9 @@
};
};
- mmc@12210000 {
- status = "disabled";
- };
-
mmc@12220000 {
num-slots = <1>;
supports-highspeed;
- fifo-depth = <0x80>;
card-detect-delay = <200>;
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <2 3>;
@@ -273,7 +267,6 @@
num-slots = <1>;
supports-highspeed;
broken-cd;
- fifo-depth = <0x80>;
card-detect-delay = <200>;
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <2 3>;
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index a9395c4..67484d1 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -171,11 +171,20 @@
};
};
+ mmc@12200000 {
+ status = "okay";
+ };
+
+ mmc@12220000 {
+ status = "okay";
+ };
+
/*
* On Snow we've got SIP WiFi and so can keep drive strengths low to
* reduce EMI.
*/
mmc@12230000 {
+ status = "okay";
slot@0 {
pinctrl-names = "default";
pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: Fix mmc node on exynos5250 snow board
[not found] ` <1386237974-2255-1-git-send-email-yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2013-12-05 18:49 ` Sonny Rao
2013-12-06 5:00 ` Yuvaraj Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Sonny Rao @ 2013-12-05 18:49 UTC (permalink / raw)
To: Yuvaraj Kumar C D
Cc: linux-samsung-soc, Kukjin Kim, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
swarren-3lzwWm7+Weoh9ZMKESR00Q,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Tomasz Figa, ALIM AKHTAR,
Douglas Anderson, Yuvaraj Kumar C D
On Thu, Dec 5, 2013 at 2:06 AM, Yuvaraj Kumar C D <yuvaraj.cd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Commits 64c138a ("ARM: dts: Move fifo-depth property from exynos5250
> board dts") and 0c3de788 ("ARM: dts: change status property of dwmmc
> nodes for exynos5250") missed out handling the exynos5250 snow dts file.
> Delete the fifo-depth property and enable the mmc node in the snow dts
> file.
>
Since this is really fixing two different issues, even though they
both affect dw_mmc, would you mind splitting this up into two
different commits?
> Signed-off-by : Abhilash Kesavan <a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/boot/dts/cros5250-common.dtsi | 7 -------
> arch/arm/boot/dts/exynos5250-snow.dts | 9 +++++++++
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
> index 6470536..2dd70e9 100644
> --- a/arch/arm/boot/dts/cros5250-common.dtsi
> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
> @@ -233,7 +233,6 @@
> num-slots = <1>;
> supports-highspeed;
> broken-cd;
> - fifo-depth = <0x80>;
Why are you deleting fifo-depth?
> card-detect-delay = <200>;
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <2 3>;
> @@ -247,14 +246,9 @@
> };
> };
>
> - mmc@12210000 {
> - status = "disabled";
> - };
> -
> mmc@12220000 {
> num-slots = <1>;
> supports-highspeed;
> - fifo-depth = <0x80>;
> card-detect-delay = <200>;
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <2 3>;
> @@ -273,7 +267,6 @@
> num-slots = <1>;
> supports-highspeed;
> broken-cd;
> - fifo-depth = <0x80>;
> card-detect-delay = <200>;
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <2 3>;
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index a9395c4..67484d1 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -171,11 +171,20 @@
> };
> };
>
> + mmc@12200000 {
> + status = "okay";
> + };
> +
> + mmc@12220000 {
> + status = "okay";
> + };
> +
> /*
> * On Snow we've got SIP WiFi and so can keep drive strengths low to
> * reduce EMI.
> */
> mmc@12230000 {
> + status = "okay";
> slot@0 {
> pinctrl-names = "default";
> pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: Fix mmc node on exynos5250 snow board
2013-12-05 18:49 ` Sonny Rao
@ 2013-12-06 5:00 ` Yuvaraj Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Yuvaraj Kumar @ 2013-12-06 5:00 UTC (permalink / raw)
To: Sonny Rao
Cc: linux-samsung-soc, Kukjin Kim, Rob Herring, Pawel Moll,
Mark Rutland, Stephen Warren, Ian Campbell,
devicetree@vger.kernel.org, Tomasz Figa, ALIM AKHTAR,
Douglas Anderson, Yuvaraj Kumar C D
On Fri, Dec 6, 2013 at 12:19 AM, Sonny Rao <sonnyrao@chromium.org> wrote:
> On Thu, Dec 5, 2013 at 2:06 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>> Commits 64c138a ("ARM: dts: Move fifo-depth property from exynos5250
>> board dts") and 0c3de788 ("ARM: dts: change status property of dwmmc
>> nodes for exynos5250") missed out handling the exynos5250 snow dts file.
>> Delete the fifo-depth property and enable the mmc node in the snow dts
>> file.
>>
>
> Since this is really fixing two different issues, even though they
> both affect dw_mmc, would you mind splitting this up into two
> different commits?
OK, I will split into two and repost.
>
>> Signed-off-by : Abhilash Kesavan <a.kesavan@samsung.com>
>>
>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>> ---
>> arch/arm/boot/dts/cros5250-common.dtsi | 7 -------
>> arch/arm/boot/dts/exynos5250-snow.dts | 9 +++++++++
>> 2 files changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
>> index 6470536..2dd70e9 100644
>> --- a/arch/arm/boot/dts/cros5250-common.dtsi
>> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
>> @@ -233,7 +233,6 @@
>> num-slots = <1>;
>> supports-highspeed;
>> broken-cd;
>> - fifo-depth = <0x80>;
>
> Why are you deleting fifo-depth?
fifo-depth property has been moved to SOC specific file exynos5250.dtsi
>
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -247,14 +246,9 @@
>> };
>> };
>>
>> - mmc@12210000 {
>> - status = "disabled";
>> - };
>> -
>> mmc@12220000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - fifo-depth = <0x80>;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -273,7 +267,6 @@
>> num-slots = <1>;
>> supports-highspeed;
>> broken-cd;
>> - fifo-depth = <0x80>;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index a9395c4..67484d1 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -171,11 +171,20 @@
>> };
>> };
>>
>> + mmc@12200000 {
>> + status = "okay";
>> + };
>> +
>> + mmc@12220000 {
>> + status = "okay";
>> + };
>> +
>> /*
>> * On Snow we've got SIP WiFi and so can keep drive strengths low to
>> * reduce EMI.
>> */
>> mmc@12230000 {
>> + status = "okay";
>> slot@0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&sd3_clk &sd3_cmd &sd3_bus4>;
>> --
>> 1.7.9.5
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-06 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-05 10:06 [PATCH] ARM: dts: Fix mmc node on exynos5250 snow board Yuvaraj Kumar C D
[not found] ` <1386237974-2255-1-git-send-email-yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-12-05 18:49 ` Sonny Rao
2013-12-06 5:00 ` Yuvaraj Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).