[PATCH] ARM64: dts: Add clock-frequency to model cpu nodes

public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] ARM64: dts: Add clock-frequency to model cpu nodes
@ 2013-12-06 13:14 Mark Brown
  2013-12-09 17:56 ` Jon Medhurst (Tixy)
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-12-06 13:14 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw, Mark Brown

From: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

The clock-frequency property is meaningless for the models but it's a
mandatory property so claim that all the cores run at 1MHz.

Signed-off-by: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 arch/arm64/boot/dts/foundation-v8.dts  | 4 ++++
 arch/arm64/boot/dts/rtsm_ve-aemv8a.dts | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/foundation-v8.dts b/arch/arm64/boot/dts/foundation-v8.dts
index 4a060906809d..f91b2fa41fb3 100644
--- a/arch/arm64/boot/dts/foundation-v8.dts
+++ b/arch/arm64/boot/dts/foundation-v8.dts
@@ -34,6 +34,7 @@
 			reg = <0x0 0x0>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 		cpu@1 {
 			device_type = "cpu";
@@ -41,6 +42,7 @@
 			reg = <0x0 0x1>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 		cpu@2 {
 			device_type = "cpu";
@@ -48,6 +50,7 @@
 			reg = <0x0 0x2>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 		cpu@3 {
 			device_type = "cpu";
@@ -55,6 +58,7 @@
 			reg = <0x0 0x3>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 	};
 
diff --git a/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts
index 572005ea2217..d7debfe79d9f 100644
--- a/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts
+++ b/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts
@@ -37,6 +37,7 @@
 			reg = <0x0 0x0>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 		cpu@1 {
 			device_type = "cpu";
@@ -44,6 +45,7 @@
 			reg = <0x0 0x1>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 		cpu@2 {
 			device_type = "cpu";
@@ -51,6 +53,7 @@
 			reg = <0x0 0x2>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 		cpu@3 {
 			device_type = "cpu";
@@ -58,6 +61,7 @@
 			reg = <0x0 0x3>;
 			enable-method = "spin-table";
 			cpu-release-addr = <0x0 0x8000fff8>;
+			clock-frequency = <1000000>;
 		};
 	};
 
-- 
1.8.5.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM64: dts: Add clock-frequency to model cpu nodes
  2013-12-06 13:14 [PATCH] ARM64: dts: Add clock-frequency to model cpu nodes Mark Brown
@ 2013-12-09 17:56 ` Jon Medhurst (Tixy)
       [not found]   ` <1386611765.3380.70.camel-K+mpW1F5uff9zxVx7UNMDg@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Medhurst (Tixy) @ 2013-12-09 17:56 UTC (permalink / raw)
  To: Mark Brown
  Cc: devicetree, linaro-kernel, Mark Brown, Catalin Marinas,
	Will Deacon, linux-arm-kernel

On Fri, 2013-12-06 at 13:14 +0000, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> The clock-frequency property is meaningless for the models but it's a
> mandatory property so claim that all the cores run at 1MHz.

Is it a mandatory property? I know we seem to get ugly warnings if it's
missing but I see no mention of it at all in
Documentation/devicetree/bindings/arm/cpus.txt (am I looking in the
wrong place?)

I think this attribute got merged into the kernel with the early power
related scheduling efforts, but given the state of all that at the
moment I was guessing it might be obsolete.

-- Tixy

> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  arch/arm64/boot/dts/foundation-v8.dts  | 4 ++++
>  arch/arm64/boot/dts/rtsm_ve-aemv8a.dts | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/foundation-v8.dts b/arch/arm64/boot/dts/foundation-v8.dts
> index 4a060906809d..f91b2fa41fb3 100644
> --- a/arch/arm64/boot/dts/foundation-v8.dts
> +++ b/arch/arm64/boot/dts/foundation-v8.dts
> @@ -34,6 +34,7 @@
>  			reg = <0x0 0x0>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  		cpu@1 {
>  			device_type = "cpu";
> @@ -41,6 +42,7 @@
>  			reg = <0x0 0x1>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  		cpu@2 {
>  			device_type = "cpu";
> @@ -48,6 +50,7 @@
>  			reg = <0x0 0x2>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  		cpu@3 {
>  			device_type = "cpu";
> @@ -55,6 +58,7 @@
>  			reg = <0x0 0x3>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  	};
>  
> diff --git a/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts
> index 572005ea2217..d7debfe79d9f 100644
> --- a/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts
> +++ b/arch/arm64/boot/dts/rtsm_ve-aemv8a.dts
> @@ -37,6 +37,7 @@
>  			reg = <0x0 0x0>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  		cpu@1 {
>  			device_type = "cpu";
> @@ -44,6 +45,7 @@
>  			reg = <0x0 0x1>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  		cpu@2 {
>  			device_type = "cpu";
> @@ -51,6 +53,7 @@
>  			reg = <0x0 0x2>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  		cpu@3 {
>  			device_type = "cpu";
> @@ -58,6 +61,7 @@
>  			reg = <0x0 0x3>;
>  			enable-method = "spin-table";
>  			cpu-release-addr = <0x0 0x8000fff8>;
> +			clock-frequency = <1000000>;
>  		};
>  	};
>  

^ permalink raw reply	[flat|nested] 3+ messages in thread

[parent not found: <1386611765.3380.70.camel-K+mpW1F5uff9zxVx7UNMDg@public.gmane.org>]

* Re: [PATCH] ARM64: dts: Add clock-frequency to model cpu nodes
       [not found]   ` <1386611765.3380.70.camel-K+mpW1F5uff9zxVx7UNMDg@public.gmane.org>
@ 2013-12-09 18:05     ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-12-09 18:05 UTC (permalink / raw)
  To: Jon Medhurst (Tixy)
  Cc: Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On Mon, Dec 09, 2013 at 05:56:05PM +0000, Jon Medhurst (Tixy) wrote:
> On Fri, 2013-12-06 at 13:14 +0000, Mark Brown wrote:

> > The clock-frequency property is meaningless for the models but it's a
> > mandatory property so claim that all the cores run at 1MHz.

> Is it a mandatory property? I know we seem to get ugly warnings if it's
> missing but I see no mention of it at all in
> Documentation/devicetree/bindings/arm/cpus.txt (am I looking in the
> wrong place?)

It's mandatory according to ePAPR (see my separate patch copying the
definition into our copy of the binding documents).

> I think this attribute got merged into the kernel with the early power
> related scheduling efforts, but given the state of all that at the
> moment I was guessing it might be obsolete.

No, it's still being used.  At the minute mainline should in theory
balance tasks well enough between the cores when they're all enabled, it
just won't figure out that it's useful to shut one of the clusters down.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-09 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-06 13:14 [PATCH] ARM64: dts: Add clock-frequency to model cpu nodes Mark Brown
2013-12-09 17:56 ` Jon Medhurst (Tixy)
     [not found]   ` <1386611765.3380.70.camel-K+mpW1F5uff9zxVx7UNMDg@public.gmane.org>
2013-12-09 18:05     ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox