* [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node
@ 2013-12-14 5:21 Alex Ling
[not found] ` <1386998490-19456-1-git-send-email-kasimling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alex Ling @ 2013-12-14 5:21 UTC (permalink / raw)
To: ben-linux, kgene.kim, rob.herring, pawel.moll, mark.rutland,
linux, linux-arm-kernel, linux-samsung-soc, devicetree,
linux-kernel
Cc: Alex Ling
This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc
node. Without this patch, dwmmc host driver will skip enabling the
two clocks and it will break dwmmc host function on exynos4412.
Tested on FriendlyARM TINY4412 board.
Signed-off-by: Alex Ling <kasimling@gmail.com>
---
Changes for v2:
- Fix patch description as Mark Rutland suggested
arch/arm/boot/dts/exynos4412.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e743e67..67bef99 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -67,5 +67,7 @@
interrupts = <0 77 0>;
#address-cells = <1>;
#size-cells = <0>;
+ clocks = <&clock 301>, <&clock 149>;
+ clock-names = "biu", "ciu";
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node
[not found] ` <1386998490-19456-1-git-send-email-kasimling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2013-12-14 13:24 ` Tomasz Figa
2013-12-15 14:14 ` Alex Ling
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Figa @ 2013-12-14 13:24 UTC (permalink / raw)
To: Alex Ling
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, linux-lFZ/pmaqli7XmaaqVzeoHQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Alex,
On Saturday 14 of December 2013 13:21:30 Alex Ling wrote:
> This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc
> node. Without this patch, dwmmc host driver will skip enabling the
> two clocks and it will break dwmmc host function on exynos4412.
> Tested on FriendlyARM TINY4412 board.
>
> Signed-off-by: Alex Ling <kasimling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> Changes for v2:
> - Fix patch description as Mark Rutland suggested
>
> arch/arm/boot/dts/exynos4412.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
The patch is correct, but unfortunately it's not the only thing that
is wrong with MSHC device tree node for Exynos4x12.
Please refer to my series fixing DW-MSHC support on Exynos4x12 (and
enabling it on TRATS2 board):
http://www.spinics.net/lists/arm-kernel/msg293652.html
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node
2013-12-14 13:24 ` Tomasz Figa
@ 2013-12-15 14:14 ` Alex Ling
0 siblings, 0 replies; 3+ messages in thread
From: Alex Ling @ 2013-12-15 14:14 UTC (permalink / raw)
To: Tomasz Figa
Cc: Mark Rutland, devicetree@vger.kernel.org, kgene.kim@samsung.com,
linux@arm.linux.org.uk, Pawel Moll, linux-kernel@vger.kernel.org,
Rob Herring, linux-samsung-soc@vger.kernel.org,
ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Thanks for pointing out this, Tomasz. I'll use those patches instead.
Regards,
Alex
On Sat, Dec 14, 2013 at 9:24 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Alex,
>
> On Saturday 14 of December 2013 13:21:30 Alex Ling wrote:
>> This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc
>> node. Without this patch, dwmmc host driver will skip enabling the
>> two clocks and it will break dwmmc host function on exynos4412.
>> Tested on FriendlyARM TINY4412 board.
>>
>> Signed-off-by: Alex Ling <kasimling@gmail.com>
>> ---
>> Changes for v2:
>> - Fix patch description as Mark Rutland suggested
>>
>> arch/arm/boot/dts/exynos4412.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>
> The patch is correct, but unfortunately it's not the only thing that
> is wrong with MSHC device tree node for Exynos4x12.
>
> Please refer to my series fixing DW-MSHC support on Exynos4x12 (and
> enabling it on TRATS2 board):
> http://www.spinics.net/lists/arm-kernel/msg293652.html
>
> Best regards,
> Tomasz
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-15 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 5:21 [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node Alex Ling
[not found] ` <1386998490-19456-1-git-send-email-kasimling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-12-14 13:24 ` Tomasz Figa
2013-12-15 14:14 ` Alex Ling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).