From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Reichel Subject: [RFCv4 03/11] HSI: hsi-char: fix driver for multiport scenarios Date: Mon, 16 Dec 2013 00:27:56 +0100 Message-ID: <1387150085-23173-4-git-send-email-sre@debian.org> References: <1387150085-23173-1-git-send-email-sre@debian.org> Return-path: In-Reply-To: <1387150085-23173-1-git-send-email-sre@debian.org> Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Reichel , Linus Walleij , Shubhrajyoti Datta , Carlos Chinea Cc: Tony Lindgren , Grant Likely , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , =?UTF-8?q?=27Beno=C3=AEt=20Cousson=27?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, =?UTF-8?q?Pali=20Roh=C3=A1r?= , =?UTF-8?q?=D0=98=D0=B2=D0=B0=D0=B9=D0=BB=D0=BE=20=D0=94=D0=B8=D0=BC=D0=B8=D1=82=D1=80=D0=BE=D0=B2?= , Joni Lapilainen , Aaro Koskinen , Sebastian Reichel List-Id: devicetree@vger.kernel.org Fix return code check of alloc_chrdev_region, which returns 0 on success. Signed-off-by: Sebastian Reichel --- drivers/hsi/clients/hsi_char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c index 7f64bed..f51cf45 100644 --- a/drivers/hsi/clients/hsi_char.c +++ b/drivers/hsi/clients/hsi_char.c @@ -706,7 +706,7 @@ static int hsc_probe(struct device *dev) if (!hsc_major) { ret = alloc_chrdev_region(&hsc_dev, hsc_baseminor, HSC_DEVS, devname); - if (ret > 0) + if (ret == 0) hsc_major = MAJOR(hsc_dev); } else { hsc_dev = MKDEV(hsc_major, hsc_baseminor); -- 1.8.5.1