devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jason Cooper <jason@lakedaemon.net>, kishon@ti.com
Cc: devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>,
	linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH 3/4] SATA: MV: Add support for the optional PHYs
Date: Tue, 17 Dec 2013 21:21:51 +0100	[thread overview]
Message-ID: <1387311713-1926-3-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1387311713-1926-1-git-send-email-andrew@lunn.ch>

Some Marvell SoCs have a SATA PHY which can be powered off, in order
to save power. Make use of the generic phy framework to control these
phys.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
v2->v3
Look for phys using name "port0", "port1", etc.
---
 drivers/ata/sata_mv.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 56be31819897..896725bb5e34 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -60,6 +60,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/device.h>
 #include <linux/clk.h>
+#include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/ata_platform.h>
 #include <linux/mbus.h>
@@ -563,6 +564,12 @@ struct mv_host_priv {
 	struct clk		*clk;
 	struct clk              **port_clks;
 	/*
+	 * Some devices have a SATA PHY which can be enabled/disabled
+	 * in order to save power. These are optional: if the platform
+	 * devices does not have any phy, they won't be used.
+	 */
+	struct phy		**port_phys;
+	/*
 	 * These consistent DMA memory pools give us guaranteed
 	 * alignment for hardware-accessed data structures,
 	 * and less memory waste in accomplishing the alignment.
@@ -4076,6 +4083,11 @@ static int mv_platform_probe(struct platform_device *pdev)
 					GFP_KERNEL);
 	if (!hpriv->port_clks)
 		return -ENOMEM;
+	hpriv->port_phys = devm_kzalloc(&pdev->dev,
+					sizeof(struct phy *) * n_ports,
+					GFP_KERNEL);
+	if (!hpriv->port_phys)
+		return -ENOMEM;
 	host->private_data = hpriv;
 	hpriv->n_ports = n_ports;
 	hpriv->board_idx = chip_soc;
@@ -4097,6 +4109,10 @@ static int mv_platform_probe(struct platform_device *pdev)
 		hpriv->port_clks[port] = clk_get(&pdev->dev, port_number);
 		if (!IS_ERR(hpriv->port_clks[port]))
 			clk_prepare_enable(hpriv->port_clks[port]);
+		sprintf(port_number, "port%d", port);
+		hpriv->port_phys[port] = devm_phy_get(&pdev->dev, port_number);
+		if (!IS_ERR(hpriv->port_phys[port]))
+			phy_power_on(hpriv->port_phys[port]);
 	}
 
 	/*
@@ -4132,6 +4148,8 @@ err:
 			clk_disable_unprepare(hpriv->port_clks[port]);
 			clk_put(hpriv->port_clks[port]);
 		}
+		if (!IS_ERR(hpriv->port_phys[port]))
+			phy_power_off(hpriv->port_phys[port]);
 	}
 
 	return rc;
@@ -4161,6 +4179,8 @@ static int mv_platform_remove(struct platform_device *pdev)
 			clk_disable_unprepare(hpriv->port_clks[port]);
 			clk_put(hpriv->port_clks[port]);
 		}
+		if (!IS_ERR(hpriv->port_phys[port]))
+			phy_power_off(hpriv->port_phys[port]);
 	}
 	return 0;
 }
-- 
1.8.5.1


  parent reply	other threads:[~2013-12-17 20:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 20:21 [PATCH 1/4] Phy: DT binding documentation for Marvell MVEBU SATA phy Andrew Lunn
2013-12-17 20:21 ` [PATCH 2/4] Phy: Add a PHY driver for Marvell MVEBU SATA PHY Andrew Lunn
2013-12-19 10:40   ` Kishon Vijay Abraham I
2013-12-17 20:21 ` Andrew Lunn [this message]
2013-12-18  6:30   ` [PATCH 3/4] SATA: MV: Add support for the optional PHYs Kishon Vijay Abraham I
2013-12-18 12:13     ` Tejun Heo
2013-12-19 19:10       ` Andrew Lunn
2013-12-19 19:42         ` Tejun Heo
2013-12-26 17:25           ` [PATCH v4 0/4] PHY Driver for Marvell SATA Andrew Lunn
2013-12-26 17:25             ` [PATCH v4 1/4] Phy: DT binding documentation for Marvell MVEBU SATA phy Andrew Lunn
2013-12-26 17:25             ` [PATCH v4 2/4] Phy: Add a PHY driver for Marvell MVEBU SATA PHY Andrew Lunn
2013-12-27 16:33               ` Kishon Vijay Abraham I
2014-01-10 19:31                 ` Jason Cooper
2014-01-11 11:12                   ` Kishon Vijay Abraham I
2013-12-26 17:25             ` [PATCH v4 3/4] SATA: MV: Add support for the optional PHYs Andrew Lunn
2014-01-20 12:47               ` Tejun Heo
2013-12-26 17:25             ` [PATCH v4 4/4] Phy: Add DT nodes on kirkwood and Dove for the SATA PHY Andrew Lunn
     [not found]     ` <52B140F2.8070900-l0cyMroinI0@public.gmane.org>
2013-12-19 19:03       ` [PATCH 3/4] SATA: MV: Add support for the optional PHYs Andrew Lunn
2013-12-20  3:25         ` Jason Cooper
2013-12-17 20:21 ` [PATCH 4/4] Phy: Add DT nodes on kirkwood and Dove for the SATA PHY Andrew Lunn
2013-12-18  6:32   ` Kishon Vijay Abraham I
2013-12-22 17:21   ` Jason Cooper
2013-12-17 20:27 ` [PATCH 1/4] Phy: DT binding documentation for Marvell MVEBU SATA phy Andrew Lunn
2013-12-20  3:21 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387311713-1926-3-git-send-email-andrew@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=sebastian.hesselbarth@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).