From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/5] mfd: sec: Remove sec_reg* regmap helpers Date: Wed, 18 Dec 2013 15:03:51 +0100 Message-ID: <1387375431.1433.2.camel@AMDC1943> References: <1387286601-21646-1-git-send-email-k.kozlowski@samsung.com> <1387286601-21646-4-git-send-email-k.kozlowski@samsung.com> <20131218133625.GT28455@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20131218133625.GT28455@sirena.org.uk> Sender: linux-doc-owner@vger.kernel.org To: Mark Brown Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Sangbeom Kim , Samuel Ortiz , Lee Jones , Liam Girdwood , Grant Likely , Sachin Kamat , Thomas Abraham , Amit Daniel Kachhap , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski List-Id: devicetree@vger.kernel.org On Wed, 2013-12-18 at 13:36 +0000, Mark Brown wrote: > On Tue, Dec 17, 2013 at 02:23:19PM +0100, Krzysztof Kozlowski wrote: > > Remove sec_reg* helpers as they are not used anymore. These helpers were > > error-prone as they mixed u8 with unsigned int and they changed order of > > some of parameters (val and mask in sec_reg_update()). > > This doesn't apply against the regulator tree. Can you please check > what's going on here, I guess there may need to be some merge with MFD? I think you need to rebase on current Linus' (at least 3.13-rc4) to get this patch: "mfd/rtc: s5m: fix register updating by adding regmap for RTC" (3e1e4a5f3a3) Best regards, Krzysztof