From: Zhangfei Gao <zhangfei.gao@linaro.org>
To: Chris Ball <cjb@laptop.org>, Arnd Bergmann <arnd@arndb.de>,
Mike Turquette <mturquette@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
brooke.wangzhigang@huawei.com
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
patches@linaro.org, devicetree@vger.kernel.org,
Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table
Date: Mon, 13 Jan 2014 17:14:29 +0800 [thread overview]
Message-ID: <1389604469-8064-3-git-send-email-zhangfei.gao@linaro.org> (raw)
In-Reply-To: <1389604469-8064-1-git-send-email-zhangfei.gao@linaro.org>
Remove clk_table and directly use ios->clock as clock source rate.
Abstract init clock rate and max clock limitation in clk.c
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
.../devicetree/bindings/mmc/k3-dw-mshc.txt | 14 -------
drivers/mmc/host/dw_mmc-k3.c | 41 +-------------------
2 files changed, 2 insertions(+), 53 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
index d7e2d7f159bb..b8653ea97957 100644
--- a/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
@@ -14,18 +14,6 @@ Required Properties:
* compatible: should be one of the following.
- "hisilicon,hi4511-dw-mshc": for controllers with hi4511 specific extentions.
-* clock-freq-table: should be the frequency (in Hz) array of the ciu clock
- in each supported mode.
- 0. CIU clock rate in Hz for DS mode
- 1. CIU clock rate in Hz for MMC HS mode
- 2. CIU clock rate in Hz for SD HS mode
- 3. CIU clock rate in Hz for SDR12 mode
- 4. CIU clock rate in Hz for SDR25 mode
- 5. CIU clock rate in Hz for SDR50 mode
- 6. CIU clock rate in Hz for SDR104 mode
- 7. CIU clock rate in Hz for DDR50 mode
- 8. CIU clock rate in Hz for HS200 mode
-
Example:
/* for Hi3620 */
@@ -39,8 +27,6 @@ Example:
#size-cells = <0>;
clocks = <&mmc_clock HI3620_SD_CIUCLK>, <&clock HI3620_DDRC_PER_CLK>;
clock-names = "ciu", "biu";
- clock-freq-table =
- <25000000 0 50000000 25000000 50000000 100000000 0 50000000>;
};
/* Board portion */
diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
index 68e5e428e8f6..84e1a670f8c7 100644
--- a/drivers/mmc/host/dw_mmc-k3.c
+++ b/drivers/mmc/host/dw_mmc-k3.c
@@ -18,56 +18,19 @@
#include "dw_mmc.h"
#include "dw_mmc-pltfm.h"
-#define MAX_NUMS 10
-struct dw_mci_k3_priv_data {
- u32 clk_table[MAX_NUMS];
-};
-
static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios)
{
- struct dw_mci_k3_priv_data *priv = host->priv;
- u32 rate = priv->clk_table[ios->timing];
int ret;
- if (!rate) {
- dev_warn(host->dev,
- "no specified rate in timing %u\n", ios->timing);
- return;
- }
-
- ret = clk_set_rate(host->ciu_clk, rate);
+ ret = clk_set_rate(host->ciu_clk, ios->clock);
if (ret)
- dev_warn(host->dev, "failed to set clock rate %uHz\n", rate);
+ dev_warn(host->dev, "failed to set rate %uHz\n", ios->clock);
host->bus_hz = clk_get_rate(host->ciu_clk);
}
-static int dw_mci_k3_parse_dt(struct dw_mci *host)
-{
- struct dw_mci_k3_priv_data *priv;
- struct device_node *node = host->dev->of_node;
- struct property *prop;
- const __be32 *cur;
- u32 val, num = 0;
-
- priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(host->dev, "mem alloc failed for private data\n");
- return -ENOMEM;
- }
- host->priv = priv;
-
- of_property_for_each_u32(node, "clock-freq-table", prop, cur, val) {
- if (num >= MAX_NUMS)
- break;
- priv->clk_table[num++] = val;
- }
- return 0;
-}
-
static const struct dw_mci_drv_data k3_drv_data = {
.set_ios = dw_mci_k3_set_ios,
- .parse_dt = dw_mci_k3_parse_dt,
};
static const struct of_device_id dw_mci_k3_match[] = {
--
1.7.9.5
next prev parent reply other threads:[~2014-01-13 9:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 9:14 [PATCH 0/2] mmc: dw_mmc: k3 remove clk_table Zhangfei Gao
2014-01-13 9:14 ` [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks Zhangfei Gao
2014-01-13 9:37 ` [PATCH] " Zhangfei Gao
2014-02-27 0:10 ` Mike Turquette
2014-01-14 9:47 ` [PATCH 1/2] " Seungwon Jeon
2014-01-14 10:04 ` Zhangfei Gao
2014-01-14 10:40 ` Seungwon Jeon
2014-01-14 11:52 ` zhangfei
[not found] ` <1389604469-8064-2-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-01-14 20:17 ` Mike Turquette
2014-01-15 1:40 ` zhangfei
2014-01-15 3:53 ` Mike Turquette
2014-01-15 5:59 ` Haojian Zhuang
2014-01-15 8:29 ` Mike Turquette
2014-01-15 9:34 ` Haojian Zhuang
2014-01-15 16:14 ` Kevin Hilman
2014-01-13 9:14 ` Zhangfei Gao [this message]
2014-01-14 10:42 ` [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table Seungwon Jeon
[not found] ` <002b01cf1115$4cdfe240$e69fa6c0$%jun-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-01-17 15:01 ` Chris Ball
2014-01-17 16:10 ` Seungwon Jeon
2014-01-17 22:56 ` Mike Turquette
2014-01-17 23:00 ` Chris Ball
2014-01-17 14:43 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389604469-8064-3-git-send-email-zhangfei.gao@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=arnd@arndb.de \
--cc=brooke.wangzhigang@huawei.com \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=patches@linaro.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).