From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96F5BBA33; Thu, 10 Apr 2025 10:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744281731; cv=none; b=HZHboUplKOcnC6NTMO4tYSAysdeAPmm7xVrlRvtIu3GN8Y7TFmsEJkJSLAS5CflYyDMrpqYP6k8e9m0mkH8f0Jojj2RfrA666hV99aN0pghYERhuBiqEfxkNpVAUmDfXCMlkN16Ukb69t09+Hn6fXPUjYvsYvsEeg7fgv7PP4Hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744281731; c=relaxed/simple; bh=k7pjrlB1l7xc3GSWH75T9N9plUepnhwKTuocK1lbagM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UdBrEyBtLTIfVhRM5SiZb3vAkfM34i5A8b/Ugs08N8KpeU+SKsFS9nthqVWJx9qhj3X1aTKJS+CbhGQyUjuWL2om4qRwIIsuZp+hAVq4VtBnyfDdSF0DceepGkwYK1OwqOgYildi541i8CnHpyumh2AqwsdRyoc52++4oL9xGKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tWWaISTg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tWWaISTg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14CD2C4CEDD; Thu, 10 Apr 2025 10:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744281731; bh=k7pjrlB1l7xc3GSWH75T9N9plUepnhwKTuocK1lbagM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tWWaISTgVxicKOMw7l7rGcHOttcQIi8iIm32V+g5y3ejKxnpZIykHbjP5Te3P8ukp bkacSkffk0qkyNvFsDsxJJzwZ9ZcewTsYp6znTQHlT1xr2vzkcCSn3C4J4D8n132JO GIpvpAu0WDkMNjw9nLCpfA88RIDl3g5uL+t/KxRYAM8NQr2Is1zjyJqZxKlfW3T/wc 1gYBQg1xot01Yo1rUWfz8zuSwgIb8zQN97kKSrBNxOuKQcZC2tCi8Yeb6mD1uUlA3g D9SaIDBQuctJQuhHzr8a3u4I9+Jjhw4/JAGydqf2M1ruLbDCcW3IlcudDphtqTGXWj KEODIXimsGU+w== Message-ID: <138d0e3c-ccab-48e2-b437-aec063d1d2dc@kernel.org> Date: Thu, 10 Apr 2025 12:42:05 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/28] mfd: zl3073x: Add components versions register defs To: Ivan Vecera , Andrew Lunn Cc: netdev@vger.kernel.org, Michal Schmidt , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250407172836.1009461-1-ivecera@redhat.com> <20250407172836.1009461-6-ivecera@redhat.com> <22b9f197-2f98-43c7-9cc9-c748e80078b0@redhat.com> <5af77349-5a76-4557-839b-d9ac643f5368@kernel.org> <40239de9-7552-41d1-9ee4-152ece6f33bc@redhat.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <40239de9-7552-41d1-9ee4-152ece6f33bc@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/04/2025 12:23, Ivan Vecera wrote: > > > On 10. 04. 25 9:11 dop., Krzysztof Kozlowski wrote: >> On 09/04/2025 08:44, Ivan Vecera wrote: >>> On 07. 04. 25 11:09 odp., Andrew Lunn wrote: >>>> On Mon, Apr 07, 2025 at 07:28:32PM +0200, Ivan Vecera wrote: >>>>> Add register definitions for components versions and report them >>>>> during probe. >>>>> >>>>> Reviewed-by: Michal Schmidt >>>>> Signed-off-by: Ivan Vecera >>>>> --- >>>>> drivers/mfd/zl3073x-core.c | 35 +++++++++++++++++++++++++++++++++++ >>>>> 1 file changed, 35 insertions(+) >>>>> >>>>> diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c >>>>> index 39d4c8608a740..b3091b00cffa8 100644 >>>>> --- a/drivers/mfd/zl3073x-core.c >>>>> +++ b/drivers/mfd/zl3073x-core.c >>>>> @@ -1,10 +1,19 @@ >>>>> // SPDX-License-Identifier: GPL-2.0-only >>>>> >>>>> +#include >>>>> #include >>>>> #include >>>>> #include >>>>> #include "zl3073x.h" >>>>> >>>>> +/* >>>>> + * Register Map Page 0, General >>>>> + */ >>>>> +ZL3073X_REG16_DEF(id, 0x0001); >>>>> +ZL3073X_REG16_DEF(revision, 0x0003); >>>>> +ZL3073X_REG16_DEF(fw_ver, 0x0005); >>>>> +ZL3073X_REG32_DEF(custom_config_ver, 0x0007); >>>>> + >>>>> /* >>>>> * Regmap ranges >>>>> */ >>>>> @@ -159,10 +168,36 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_dev_alloc, "ZL3073X"); >>>>> >>>>> int zl3073x_dev_init(struct zl3073x_dev *zldev) >>>>> { >>>>> + u16 id, revision, fw_ver; >>>>> struct devlink *devlink; >>>>> + u32 cfg_ver; >>>>> + int rc; >>>>> >>>>> devm_mutex_init(zldev->dev, &zldev->lock); >>>>> >>>>> + scoped_guard(zl3073x, zldev) { >>>> >>>> Why the scoped_guard? The locking scheme you have seems very opaque. >>> >>> We are read the HW registers in this block and the access is protected >>> by this device lock. Regmap locking will be disabled in v2 as this is >> >> Reading ID must be protected by mutex? Why and how? > > Yes, the ID is read from the hardware register and HW access functions > are protected by zl3073x_dev->lock. The access is not protected by Please do not keep repeating the same. You again describe the code. We ask why do you implement that way? > regmap locking schema. Set of registers are indirect and are accessed by > mailboxes where multiple register accesses need to be done atomically. regmap handles that, but anyway, how multiple register access to ID registers happen? From what module? Which code does it? So they write here something in the middle and reading would be unsynced? > This is the reason why regmap locking is not sufficient. Again, you explained nothing why it is not sufficient. You only keep saying "access is protected" and therefore regmap locking is not enough. That's not a valid argument. Best regards, Krzysztof