From: Philipp Zabel <p.zabel@pengutronix.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v2 2/4] ASoC: tlv320aic32x4: DT support
Date: Mon, 20 Jan 2014 13:54:57 +0100 [thread overview]
Message-ID: <1390222497.5871.2.camel@pizza.hi.pengutronix.de> (raw)
In-Reply-To: <1390219558-25341-3-git-send-email-mpa@pengutronix.de>
Am Montag, den 20.01.2014, 13:05 +0100 schrieb Markus Pargmann:
> Add DT support for this codec. The bindings differ a bit from the aic3x
> codec bindings, so I created a new binding documentation.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> .../devicetree/bindings/sound/tlv320aic32x4.txt | 18 ++++++++++++++++
> sound/soc/codecs/tlv320aic32x4.c | 25 ++++++++++++++++++++++
> 2 files changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/tlv320aic32x4.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt b/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt
> new file mode 100644
> index 0000000..cff06ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt
> @@ -0,0 +1,18 @@
> +Texas Instruments - tlv320aic32x4 Codec module
> +
> +The tlv320aic32x4 serial control bus communicates through I2C protocols
> +
> +Required properties:
> + - compatible: Should be "ti,tlv320aic32x4"
> + - reg: I2C slave address
> +
> +Optional properties:
> + - gpio-reset: Reset-GPIO phandle with args as described in gpio/gpio.txt
This should be "reset-gpios".
> +
> +
> +Example:
> +
> +codec: tlv320aic32x4@18 {
> + compatible = "ti,tlv320aic32x4";
> + reg = <0x18>;
> +};
> diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
> index 1c9f1d8..6c38cb7 100644
> --- a/sound/soc/codecs/tlv320aic32x4.c
> +++ b/sound/soc/codecs/tlv320aic32x4.c
> @@ -29,6 +29,7 @@
> #include <linux/delay.h>
> #include <linux/pm.h>
> #include <linux/gpio.h>
> +#include <linux/of_gpio.h>
> #include <linux/i2c.h>
> #include <linux/cdev.h>
> #include <linux/slab.h>
> @@ -669,11 +670,22 @@ static struct snd_soc_codec_driver soc_codec_dev_aic32x4 = {
> .num_dapm_routes = ARRAY_SIZE(aic32x4_dapm_routes),
> };
>
> +static int aic32x4_parse_dt(struct aic32x4_priv *aic32x4,
> + struct device_node *np)
> +{
> + aic32x4->swapdacs = false;
> + aic32x4->micpga_routing = 0;
> + aic32x4->rstn_gpio = of_get_named_gpio(np, "gpio-reset", 0);
This should be "reset-gpios".
> +
> + return 0;
> +}
> +
> static int aic32x4_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> struct aic32x4_pdata *pdata = i2c->dev.platform_data;
> struct aic32x4_priv *aic32x4;
> + struct device_node *np = i2c->dev.of_node;
> int ret;
>
> aic32x4 = devm_kzalloc(&i2c->dev, sizeof(struct aic32x4_priv),
> @@ -692,6 +704,12 @@ static int aic32x4_i2c_probe(struct i2c_client *i2c,
> aic32x4->swapdacs = pdata->swapdacs;
> aic32x4->micpga_routing = pdata->micpga_routing;
> aic32x4->rstn_gpio = pdata->rstn_gpio;
> + } else if (np) {
> + ret = aic32x4_parse_dt(aic32x4, np);
> + if (ret) {
> + dev_err(&i2c->dev, "Failed to parse DT node\n");
> + return ret;
> + }
> } else {
> aic32x4->power_cfg = 0;
> aic32x4->swapdacs = false;
> @@ -723,10 +741,17 @@ static const struct i2c_device_id aic32x4_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, aic32x4_i2c_id);
>
> +static const struct of_device_id aic32x4_of_id[] = {
> + { .compatible = "ti,tlv320aic32x4", },
> + { /* senitel */ }
> +};
> +MODULE_DEVICE_TABLE(of, aic32x4_of_id);
> +
> static struct i2c_driver aic32x4_i2c_driver = {
> .driver = {
> .name = "tlv320aic32x4",
> .owner = THIS_MODULE,
> + .of_match_table = aic32x4_of_id,
> },
> .probe = aic32x4_i2c_probe,
> .remove = aic32x4_i2c_remove,
regards
Philipp
next prev parent reply other threads:[~2014-01-20 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390219558-25341-1-git-send-email-mpa@pengutronix.de>
2014-01-20 12:05 ` [PATCH v2 2/4] ASoC: tlv320aic32x4: DT support Markus Pargmann
2014-01-20 12:54 ` Philipp Zabel [this message]
2014-01-20 12:58 ` Markus Pargmann
[not found] ` <1390219558-25341-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-01-20 12:05 ` [PATCH v2 3/4] ASoC: tlv320aic32x4: Support for master clock Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390222497.5871.2.camel@pizza.hi.pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mpa@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).