From: Roger Quadros <rogerq@ti.com>
To: tj@kernel.org
Cc: sergei.shtylyov@cogentembedded.com, kishon@ti.com,
b.zolnierkie@samsung.com, hdegoede@redhat.com, arnd@arndb.de,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Balaji T K <balajitk@ti.com>,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH v5 3/4] ata: ahci_platform: Manage SATA PHY
Date: Mon, 20 Jan 2014 16:41:27 +0200 [thread overview]
Message-ID: <1390228888-5537-4-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1390228888-5537-1-git-send-email-rogerq@ti.com>
From: Balaji T K <balajitk@ti.com>
Some platforms have a PHY hooked up to the
SATA controller. The PHY needs to be initialized
and powered up for SATA to work. We do that
using the PHY framework.
[Roger Q] Cleaned up.
Signed-off-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/ata/ahci.h | 2 ++
drivers/ata/ahci_platform.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 2289efd..f9bbada 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -37,6 +37,7 @@
#include <linux/clk.h>
#include <linux/libata.h>
+#include <linux/phy/phy.h>
/* Enclosure Management Control */
#define EM_CTRL_MSG_TYPE 0x000f0000
@@ -322,6 +323,7 @@ struct ahci_host_priv {
u32 em_buf_sz; /* EM buffer size in byte */
u32 em_msg_type; /* EM message type */
struct clk *clk; /* Only for platforms supporting clk */
+ struct phy *phy; /* If platform uses phy */
void *plat_data; /* Other platform data */
};
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index d5ced13..580567f 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -142,6 +142,37 @@ static int ahci_probe(struct platform_device *pdev)
}
}
+ hpriv->phy = devm_phy_get(dev, "sata-phy");
+ if (IS_ERR(hpriv->phy)) {
+ rc = PTR_ERR(hpriv->phy);
+ switch (rc) {
+ case -ENODEV:
+ case -ENOSYS:
+ /* continue normally */
+ hpriv->phy = NULL;
+ break;
+
+ case -EPROBE_DEFER:
+ goto disable_unprepare_clk;
+
+ default:
+ dev_err(dev, "couldn't get sata-phy\n");
+ goto disable_unprepare_clk;
+ }
+ }
+
+ if (hpriv->phy) {
+ rc = phy_init(hpriv->phy);
+ if (rc)
+ goto disable_unprepare_clk;
+
+ rc = phy_power_on(hpriv->phy);
+ if (rc) {
+ phy_exit(hpriv->phy);
+ goto disable_unprepare_clk;
+ }
+ }
+
/*
* Some platforms might need to prepare for mmio region access,
* which could be done in the following init call. So, the mmio
@@ -151,7 +182,7 @@ static int ahci_probe(struct platform_device *pdev)
if (pdata && pdata->init) {
rc = pdata->init(dev, hpriv->mmio);
if (rc)
- goto disable_unprepare_clk;
+ goto disable_phy;
}
ahci_save_initial_config(dev, hpriv,
@@ -221,6 +252,12 @@ static int ahci_probe(struct platform_device *pdev)
pdata_exit:
if (pdata && pdata->exit)
pdata->exit(dev);
+disable_phy:
+ if (hpriv->phy) {
+ phy_power_off(hpriv->phy);
+ phy_exit(hpriv->phy);
+ }
+
disable_unprepare_clk:
if (!IS_ERR(hpriv->clk))
clk_disable_unprepare(hpriv->clk);
@@ -239,6 +276,11 @@ static void ahci_host_stop(struct ata_host *host)
if (pdata && pdata->exit)
pdata->exit(dev);
+ if (hpriv->phy) {
+ phy_power_off(hpriv->phy);
+ phy_exit(hpriv->phy);
+ }
+
if (!IS_ERR(hpriv->clk)) {
clk_disable_unprepare(hpriv->clk);
clk_put(hpriv->clk);
--
1.8.3.2
next prev parent reply other threads:[~2014-01-20 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 14:41 [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support Roger Quadros
2014-01-20 14:41 ` [PATCH v5 1/4] ata: ahci_platform: Add DT compatible for Synopsis DWC AHCI controller Roger Quadros
2014-01-20 14:41 ` [PATCH v5 2/4] ata: ahci_platform: Update DT compatible list Roger Quadros
2014-01-20 14:51 ` Rob Herring
2014-01-20 14:41 ` Roger Quadros [this message]
2014-01-20 14:41 ` [PATCH v5 4/4] ata: ahci_platform: runtime resume the device before use Roger Quadros
2014-01-20 16:48 ` [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support Hans de Goede
[not found] ` <52DD5368.5020301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-21 8:34 ` Roger Quadros
[not found] ` <52DE3132.3000007-l0cyMroinI0@public.gmane.org>
2014-01-21 11:59 ` Roger Quadros
2014-01-21 13:59 ` Hans de Goede
2014-01-22 8:11 ` Roger Quadros
2014-01-22 8:28 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390228888-5537-4-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=balajitk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=kishon@ti.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).