devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: tj@kernel.org
Cc: sergei.shtylyov@cogentembedded.com, kishon@ti.com,
	b.zolnierkie@samsung.com, hdegoede@redhat.com, arnd@arndb.de,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Roger Quadros <rogerq@ti.com>,
	Balaji T K <balajitk@ti.com>
Subject: [PATCH v5 4/4] ata: ahci_platform: runtime resume the device before use
Date: Mon, 20 Jan 2014 16:41:28 +0200	[thread overview]
Message-ID: <1390228888-5537-5-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1390228888-5537-1-git-send-email-rogerq@ti.com>

On OMAP platforms the device needs to be runtime resumed before
it can be accessed. The OMAP HWMOD framework takes care of
enabling the module and its resources based on the
device's runtime PM state.

In this patch we runtime resume during .probe() and runtime suspend
during .remove() (i.e. ahci_host_stop()).

We also update the runtime PM state during .resume().

Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Balaji T K <balajitk@ti.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/ata/ahci_platform.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 580567f..b3a48bb 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -23,6 +23,7 @@
 #include <linux/platform_device.h>
 #include <linux/libata.h>
 #include <linux/ahci_platform.h>
+#include <linux/pm_runtime.h>
 #include "ahci.h"
 
 static void ahci_host_stop(struct ata_host *host);
@@ -142,6 +143,9 @@ static int ahci_probe(struct platform_device *pdev)
 		}
 	}
 
+	pm_runtime_enable(dev);
+	pm_runtime_get_sync(dev);
+
 	hpriv->phy = devm_phy_get(dev, "sata-phy");
 	if (IS_ERR(hpriv->phy)) {
 		rc = PTR_ERR(hpriv->phy);
@@ -285,6 +289,9 @@ static void ahci_host_stop(struct ata_host *host)
 		clk_disable_unprepare(hpriv->clk);
 		clk_put(hpriv->clk);
 	}
+
+	pm_runtime_put_sync(dev);
+	pm_runtime_disable(dev);
 }
 
 #ifdef CONFIG_PM_SLEEP
@@ -356,6 +363,11 @@ static int ahci_resume(struct device *dev)
 
 	ata_host_resume(host);
 
+	/* We resumed so update PM runtime state */
+	pm_runtime_disable(dev);
+	pm_runtime_set_active(dev);
+	pm_runtime_enable(dev);
+
 	return 0;
 
 disable_unprepare_clk:
-- 
1.8.3.2


  parent reply	other threads:[~2014-01-20 14:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 14:41 [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support Roger Quadros
2014-01-20 14:41 ` [PATCH v5 1/4] ata: ahci_platform: Add DT compatible for Synopsis DWC AHCI controller Roger Quadros
2014-01-20 14:41 ` [PATCH v5 2/4] ata: ahci_platform: Update DT compatible list Roger Quadros
2014-01-20 14:51   ` Rob Herring
2014-01-20 14:41 ` [PATCH v5 3/4] ata: ahci_platform: Manage SATA PHY Roger Quadros
2014-01-20 14:41 ` Roger Quadros [this message]
2014-01-20 16:48 ` [PATCH v5 0/4] ata: ahci_platform: Add PHY support and OMAP support Hans de Goede
     [not found]   ` <52DD5368.5020301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-21  8:34     ` Roger Quadros
     [not found]       ` <52DE3132.3000007-l0cyMroinI0@public.gmane.org>
2014-01-21 11:59         ` Roger Quadros
2014-01-21 13:59           ` Hans de Goede
2014-01-22  8:11             ` Roger Quadros
2014-01-22  8:28               ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390228888-5537-5-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=balajitk@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=kishon@ti.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).