Re: [PATCH v2 3/4] dt-bindings: PCI: Add UltraRISC DP1000 PCIe controller

Jia Wang
2026-04-08T06:43:37Z

On 2026-04-08 08:28 +0200, Krzysztof Kozlowski wrote:
> On 08/04/2026 05:34, Jia Wang wrote:
> >>> + max-link-speed:
> >>> + $ref: /schemas/types.yaml#/definitions/uint32
> >>> + const: 4
> >>
> >> If const then deducible from the compatible. Drop the property.
> >>
> >
> > Will replace `const: 4` with `maximum: 4` in v3.
>
> Why? Wasn't maximum link speed fixed to 4?
>

Just to make sure I fully understand: since the maximum link speed is a
fixed hardware property and is implied by the compatible, we should drop
the `max-link-speed` property from the binding.

In that case, should I set `pci->max_link_speed = 4` in the driver during
probe? I want to make sure this is the correct way to handle it.

>
> Best regards,
> Krzysztof
>

Best regards,
Jia Wang