* Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support [not found] ` <1389777291-15026-1-git-send-email-ch.naveen@samsung.com> @ 2014-01-23 10:28 ` Sylwester Nawrocki 2014-01-23 17:41 ` Mark Rutland 0 siblings, 1 reply; 6+ messages in thread From: Sylwester Nawrocki @ 2014-01-23 10:28 UTC (permalink / raw) To: Naveen Krishna Chatradhi, linux-crypto, linux-samsung-soc Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, tomasz.figa, David S. Miller, devicetree Hi, (Adding missing devicetre ML list at CC.) On 15/01/14 10:14, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com> > CC: Herbert Xu <herbert@gondor.apana.org.au> > CC: David S. Miller <davem@davemloft.net> > CC: Vladimir Zapolskiy <vzapolskiy@gmail.com> > TO: <linux-crypto@vger.kernel.org> > CC: <linux-samsung-soc@vger.kernel.org> > --- > Changes since v3: > None > > .../devicetree/bindings/crypto/samsung-sss.txt | 20 ++++++++++++++++++++ > drivers/crypto/s5p-sss.c | 10 +++++++++- > 2 files changed, 29 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/crypto/samsung-sss.txt > > diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt > new file mode 100644 > index 0000000..2f9d7e4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt > @@ -0,0 +1,20 @@ > +Samsung SoC SSS (Security SubSystem) module > + > +The SSS module in S5PV210 SoC supports the following: > +-- Feeder (FeedCtrl) > +-- Advanced Encryption Standard (AES) > +-- Data Encryption Standard (DES)/3DES > +-- Public Key Accelerator (PKA) > +-- SHA-1/SHA-256/MD5/HMAC (SHA-1/SHA-256/MD5)/PRNG > +-- PRNG: Pseudo Random Number Generator > + > +Required properties: > + > +- compatible : Should contain entries for this and backward compatible > + SSS versions: > + - "samsung,s5pv210-secss" for S5PV210 SoC. > +- reg : Offset and length of the register set for the module > +- interrupts : the interrupt-specifier for the SSS module. > + Two interrupts "feed control and hash" in case of S5PV210 It should be described in what order both interrupts are supposed to be specified. > +- clocks : the required gating clock for the SSS module. > +- clock-names : the gating clock name to be requested in the SSS driver. > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 93cddeb..2da5617 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -22,6 +22,7 @@ > #include <linux/scatterlist.h> > #include <linux/dma-mapping.h> > #include <linux/io.h> > +#include <linux/of.h> > #include <linux/crypto.h> > #include <linux/interrupt.h> > > @@ -177,6 +178,12 @@ struct s5p_aes_dev { > > static struct s5p_aes_dev *s5p_dev; > > +static const struct of_device_id s5p_sss_dt_match[] = { > + { .compatible = "samsung,s5pv210-secss", }, nit: the first semicolon could be omitted. > + { }, > +}; > +MODULE_DEVICE_TABLE(of, s5p_sss_dt_match); > + > static void s5p_set_dma_indata(struct s5p_aes_dev *dev, struct scatterlist *sg) > { > SSS_WRITE(dev, FCBRDMAS, sg_dma_address(sg)); > @@ -676,7 +683,8 @@ static struct platform_driver s5p_aes_crypto = { > .remove = s5p_aes_remove, > .driver = { > .owner = THIS_MODULE, > - .name = "s5p-secss", > + .name = "s5pv210-secss", Why you're changing the driver name ? It's not related and not needed AFAICT. > + .of_match_table = s5p_sss_dt_match, > }, > }; -- Thanks, Sylwester ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support 2014-01-23 10:28 ` [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support Sylwester Nawrocki @ 2014-01-23 17:41 ` Mark Rutland 2014-01-23 17:47 ` Sylwester Nawrocki 0 siblings, 1 reply; 6+ messages in thread From: Mark Rutland @ 2014-01-23 17:41 UTC (permalink / raw) To: Sylwester Nawrocki Cc: Naveen Krishna Chatradhi, linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, vzapolskiy@gmail.com, herbert@gondor.apana.org.au, naveenkrishna.ch@gmail.com, cpgs@samsung.com, tomasz.figa@gmail.com, David S. Miller, devicetree On Thu, Jan 23, 2014 at 10:28:08AM +0000, Sylwester Nawrocki wrote: > Hi, > > (Adding missing devicetre ML list at CC.) > > On 15/01/14 10:14, Naveen Krishna Chatradhi wrote: > > This patch adds device tree support to the s5p-sss.c crypto driver. > > > > Also, Documentation under devicetree/bindings added. > > > > Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com> > > CC: Herbert Xu <herbert@gondor.apana.org.au> > > CC: David S. Miller <davem@davemloft.net> > > CC: Vladimir Zapolskiy <vzapolskiy@gmail.com> > > TO: <linux-crypto@vger.kernel.org> > > CC: <linux-samsung-soc@vger.kernel.org> > > --- > > Changes since v3: > > None > > > > .../devicetree/bindings/crypto/samsung-sss.txt | 20 ++++++++++++++++++++ > > drivers/crypto/s5p-sss.c | 10 +++++++++- > > 2 files changed, 29 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/crypto/samsung-sss.txt > > > > diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt > > new file mode 100644 > > index 0000000..2f9d7e4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt > > @@ -0,0 +1,20 @@ > > +Samsung SoC SSS (Security SubSystem) module > > + > > +The SSS module in S5PV210 SoC supports the following: > > +-- Feeder (FeedCtrl) > > +-- Advanced Encryption Standard (AES) > > +-- Data Encryption Standard (DES)/3DES > > +-- Public Key Accelerator (PKA) > > +-- SHA-1/SHA-256/MD5/HMAC (SHA-1/SHA-256/MD5)/PRNG > > +-- PRNG: Pseudo Random Number Generator > > + > > +Required properties: > > + > > +- compatible : Should contain entries for this and backward compatible > > + SSS versions: > > + - "samsung,s5pv210-secss" for S5PV210 SoC. > > +- reg : Offset and length of the register set for the module > > +- interrupts : the interrupt-specifier for the SSS module. > > + Two interrupts "feed control and hash" in case of S5PV210 > > It should be described in what order both interrupts are supposed to be > specified. > > > +- clocks : the required gating clock for the SSS module. > > +- clock-names : the gating clock name to be requested in the SSS driver. The _exact_ names expected must be described in the binding, or this property is useless. > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > > index 93cddeb..2da5617 100644 > > --- a/drivers/crypto/s5p-sss.c > > +++ b/drivers/crypto/s5p-sss.c > > @@ -22,6 +22,7 @@ > > #include <linux/scatterlist.h> > > #include <linux/dma-mapping.h> > > #include <linux/io.h> > > +#include <linux/of.h> > > #include <linux/crypto.h> > > #include <linux/interrupt.h> > > > > @@ -177,6 +178,12 @@ struct s5p_aes_dev { > > > > static struct s5p_aes_dev *s5p_dev; > > > > +static const struct of_device_id s5p_sss_dt_match[] = { > > + { .compatible = "samsung,s5pv210-secss", }, > > nit: the first semicolon could be omitted. I assume you mean comma ratehr than semicolon? Cheers, Mark. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support 2014-01-23 17:41 ` Mark Rutland @ 2014-01-23 17:47 ` Sylwester Nawrocki 2014-01-23 17:59 ` Mark Rutland 0 siblings, 1 reply; 6+ messages in thread From: Sylwester Nawrocki @ 2014-01-23 17:47 UTC (permalink / raw) To: Mark Rutland Cc: Naveen Krishna Chatradhi, linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, vzapolskiy@gmail.com, herbert@gondor.apana.org.au, naveenkrishna.ch@gmail.com, cpgs@samsung.com, tomasz.figa@gmail.com, David S. Miller, devicetree On 23/01/14 18:41, Mark Rutland wrote: >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c >>> > > index 93cddeb..2da5617 100644 >>> > > --- a/drivers/crypto/s5p-sss.c >>> > > +++ b/drivers/crypto/s5p-sss.c >>> > > @@ -22,6 +22,7 @@ >>> > > #include <linux/scatterlist.h> >>> > > #include <linux/dma-mapping.h> >>> > > #include <linux/io.h> >>> > > +#include <linux/of.h> >>> > > #include <linux/crypto.h> >>> > > #include <linux/interrupt.h> >>> > > >>> > > @@ -177,6 +178,12 @@ struct s5p_aes_dev { >>> > > >>> > > static struct s5p_aes_dev *s5p_dev; >>> > > >>> > > +static const struct of_device_id s5p_sss_dt_match[] = { >>> > > + { .compatible = "samsung,s5pv210-secss", }, >> > >> > nit: the first semicolon could be omitted. > > I assume you mean comma ratehr than semicolon? Indeed...and it's actually the second one :-/ -- Regards, Sylwester ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support 2014-01-23 17:47 ` Sylwester Nawrocki @ 2014-01-23 17:59 ` Mark Rutland 0 siblings, 0 replies; 6+ messages in thread From: Mark Rutland @ 2014-01-23 17:59 UTC (permalink / raw) To: Sylwester Nawrocki Cc: Naveen Krishna Chatradhi, linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, vzapolskiy@gmail.com, herbert@gondor.apana.org.au, naveenkrishna.ch@gmail.com, cpgs@samsung.com, tomasz.figa@gmail.com, David S. Miller, devicetree On Thu, Jan 23, 2014 at 05:47:25PM +0000, Sylwester Nawrocki wrote: > On 23/01/14 18:41, Mark Rutland wrote: > >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > >>> > > index 93cddeb..2da5617 100644 > >>> > > --- a/drivers/crypto/s5p-sss.c > >>> > > +++ b/drivers/crypto/s5p-sss.c > >>> > > @@ -22,6 +22,7 @@ > >>> > > #include <linux/scatterlist.h> > >>> > > #include <linux/dma-mapping.h> > >>> > > #include <linux/io.h> > >>> > > +#include <linux/of.h> > >>> > > #include <linux/crypto.h> > >>> > > #include <linux/interrupt.h> > >>> > > > >>> > > @@ -177,6 +178,12 @@ struct s5p_aes_dev { > >>> > > > >>> > > static struct s5p_aes_dev *s5p_dev; > >>> > > > >>> > > +static const struct of_device_id s5p_sss_dt_match[] = { > >>> > > + { .compatible = "samsung,s5pv210-secss", }, > >> > > >> > nit: the first semicolon could be omitted. > > > > I assume you mean comma ratehr than semicolon? > > Indeed...and it's actually the second one :-/ Also, I meant "rather" rather than "ratehr". At least we figured it out in the end. :) Thanks, Mark. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/9 v5] crypto:s5p-sss: Add device tree support [not found] <1389243541-13122-1-git-send-email-ch.naveen@samsung.com> [not found] ` <1389777291-15026-1-git-send-email-ch.naveen@samsung.com> @ 2014-01-29 9:20 ` Naveen Krishna Chatradhi 2014-02-06 14:36 ` Tomasz Figa 1 sibling, 1 reply; 6+ messages in thread From: Naveen Krishna Chatradhi @ 2014-01-29 9:20 UTC (permalink / raw) To: linux-crypto, linux-samsung-soc Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, devicetree, David S. Miller This patch adds device tree support to the s5p-sss.c crypto driver. Also, Documentation under devicetree/bindings added. Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com> CC: Herbert Xu <herbert@gondor.apana.org.au> CC: David S. Miller <davem@davemloft.net> CC: Vladimir Zapolskiy <vzapolskiy@gmail.com> TO: <linux-crypto@vger.kernel.org> CC: <linux-samsung-soc@vger.kernel.org> --- Changes since v4: Modified Documentation to give clock names and example for interrupts Changes since v3: None .../devicetree/bindings/crypto/samsung-sss.txt | 24 ++++++++++++++++++++ drivers/crypto/s5p-sss.c | 8 +++++++ 2 files changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/samsung-sss.txt diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt new file mode 100644 index 0000000..d193084 --- /dev/null +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt @@ -0,0 +1,24 @@ +Samsung SoC SSS (Security SubSystem) module + +The SSS module in S5PV210 SoC supports the following: +-- Feeder (FeedCtrl) +-- Advanced Encryption Standard (AES) +-- Data Encryption Standard (DES)/3DES +-- Public Key Accelerator (PKA) +-- SHA-1/SHA-256/MD5/HMAC (SHA-1/SHA-256/MD5)/PRNG +-- PRNG: Pseudo Random Number Generator + +Required properties: + +- compatible : Should contain entries for this and backward compatible + SSS versions: + - "samsung,s5pv210-secss" for S5PV210 SoC. +- reg : Offset and length of the register set for the module +- interrupts : the interrupt-specifier for the SSS module. + Two interrupts "feed control and hash" in case of S5PV210 + Eg : interrupts = <0 feed-control 0> <0 hash 0>; +- clocks : list of clock phandle and specifier pairs for all clocks listed in + clock-names property. +- clock-names : list of device clock input names; should contain one entry + "secss". + diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 93cddeb..73c8b38 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -22,6 +22,7 @@ #include <linux/scatterlist.h> #include <linux/dma-mapping.h> #include <linux/io.h> +#include <linux/of.h> #include <linux/crypto.h> #include <linux/interrupt.h> @@ -177,6 +178,12 @@ struct s5p_aes_dev { static struct s5p_aes_dev *s5p_dev; +static const struct of_device_id s5p_sss_dt_match[] = { + { .compatible = "samsung,s5pv210-secss" }, + { }, +}; +MODULE_DEVICE_TABLE(of, s5p_sss_dt_match); + static void s5p_set_dma_indata(struct s5p_aes_dev *dev, struct scatterlist *sg) { SSS_WRITE(dev, FCBRDMAS, sg_dma_address(sg)); @@ -677,6 +684,7 @@ static struct platform_driver s5p_aes_crypto = { .driver = { .owner = THIS_MODULE, .name = "s5p-secss", + .of_match_table = s5p_sss_dt_match, }, }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/9 v5] crypto:s5p-sss: Add device tree support 2014-01-29 9:20 ` [PATCH 2/9 v5] " Naveen Krishna Chatradhi @ 2014-02-06 14:36 ` Tomasz Figa 0 siblings, 0 replies; 6+ messages in thread From: Tomasz Figa @ 2014-02-06 14:36 UTC (permalink / raw) To: Naveen Krishna Chatradhi, linux-crypto, linux-samsung-soc Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, devicetree, David S. Miller Hi Naveen, On 29.01.2014 10:20, Naveen Krishna Chatradhi wrote: > This patch adds device tree support to the s5p-sss.c crypto driver. > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: Naveen Krishna Ch <ch.naveen@samsung.com> > CC: Herbert Xu <herbert@gondor.apana.org.au> > CC: David S. Miller <davem@davemloft.net> > CC: Vladimir Zapolskiy <vzapolskiy@gmail.com> > TO: <linux-crypto@vger.kernel.org> > CC: <linux-samsung-soc@vger.kernel.org> > --- > Changes since v4: > Modified Documentation to give clock names and example for interrupts > > Changes since v3: > None > .../devicetree/bindings/crypto/samsung-sss.txt | 24 ++++++++++++++++++++ > drivers/crypto/s5p-sss.c | 8 +++++++ > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/samsung-sss.txt > > diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt > new file mode 100644 > index 0000000..d193084 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt > @@ -0,0 +1,24 @@ > +Samsung SoC SSS (Security SubSystem) module > + > +The SSS module in S5PV210 SoC supports the following: > +-- Feeder (FeedCtrl) > +-- Advanced Encryption Standard (AES) > +-- Data Encryption Standard (DES)/3DES > +-- Public Key Accelerator (PKA) > +-- SHA-1/SHA-256/MD5/HMAC (SHA-1/SHA-256/MD5)/PRNG > +-- PRNG: Pseudo Random Number Generator > + > +Required properties: > + > +- compatible : Should contain entries for this and backward compatible > + SSS versions: > + - "samsung,s5pv210-secss" for S5PV210 SoC. > +- reg : Offset and length of the register set for the module > +- interrupts : the interrupt-specifier for the SSS module. > + Two interrupts "feed control and hash" in case of S5PV210 > + Eg : interrupts = <0 feed-control 0> <0 hash 0>; Please rewrite the description of interrupts property sa follows: - interrupts : interrupt specifiers of SSS module interrupts, should contain two entries: - first : feed control interrupt, - second : hash interrupt. Then in later patch adding support for Exynos, it shoudl be rewritten to: - interrupts : interrupt specifiers of SSS module interrupts, should contain following entries: - first : feed control interrupt (required for all variants), - second : hash interrupt (required only for samsung,s5pv210-secss). Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-06 14:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1389243541-13122-1-git-send-email-ch.naveen@samsung.com>
[not found] ` <1389777291-15026-1-git-send-email-ch.naveen@samsung.com>
2014-01-23 10:28 ` [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support Sylwester Nawrocki
2014-01-23 17:41 ` Mark Rutland
2014-01-23 17:47 ` Sylwester Nawrocki
2014-01-23 17:59 ` Mark Rutland
2014-01-29 9:20 ` [PATCH 2/9 v5] " Naveen Krishna Chatradhi
2014-02-06 14:36 ` Tomasz Figa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).