* [PATCH 7/9 v5] crypto:s5p-sss: validate iv before memcpy
[not found] <1389243640-13282-1-git-send-email-ch.naveen@samsung.com>
@ 2014-01-29 9:25 ` Naveen Krishna Chatradhi
0 siblings, 0 replies; only message in thread
From: Naveen Krishna Chatradhi @ 2014-01-29 9:25 UTC (permalink / raw)
To: linux-crypto, linux-samsung-soc
Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs,
devicetree
This patch adds code to validate "iv" buffer before trying to
memcpy the contents
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
Changes since v4:
None
Changes since v3:
None
drivers/crypto/s5p-sss.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index da1c8943..a890273 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -380,7 +380,8 @@ static void s5p_set_aes(struct s5p_aes_dev *dev,
{
void __iomem *keystart;
- memcpy(dev->aes_ioaddr + SSS_REG_AES_IV_DATA (0), iv, 0x10);
+ if (iv)
+ memcpy(dev->aes_ioaddr + SSS_REG_AES_IV_DATA (0), iv, 0x10);
if (keylen == AES_KEYSIZE_256)
keystart = dev->aes_ioaddr + SSS_REG_AES_KEY_DATA(0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread