devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v1 2/2] dt-bindings: extcon: Add Realtek DHC RTD SoC Type-C
Date: Thu, 24 Aug 2023 07:23:29 +0000	[thread overview]
Message-ID: <1390ad28e50f493fa72209fe29b7f3f4@realtek.com> (raw)
In-Reply-To: <50ce8e71-613e-1ef5-0c23-67a2f6f78949@linaro.org>

Hi Krzysztof,

> >>> +
> >>> +title: Realtek DHC RTD SoCs USB Type-C detection
> >>
> >> Type-c usually go to usb directory.
> >
> > This binding is not for a type-c controller.
> > It is an extcon device for type-c connector detection.
> > So I put it at extcon directory.
> 
> If this is not a type-c controller, then what is it? Explain me please what is an
> "extcon device" without using any Linux subsystem naming.

Sorry. "extcon device" may be the wrong name I'm using.

As far as I know, type-c controller supports PD detection, role detection, role swap and cc configuration.
But in our SoC, type c module only supports role detection.
So I don't think it's a type-c controller.

I found a similar driver at
drivers/extcon/extcon-usbc-cros-ec.c
It belongs to External Connector, which can detect USB Type C cables.

So our driver is an external connector driver.

> >
> > And I will add “connector” to the title.
> > title: Realtek DHC RTD SoCs USB Type-C Connector detection
> 
> So usb...

I refer to this binding, and it is in folder bindings/extcon.
docs/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
Title: ChromeOS EC USB Type-C Cable and Accessory Detection

Thank,
Stanley

  reply	other threads:[~2023-08-24  7:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 10:28 [PATCH v1 1/2] extcon: add Realtek DHC RTD SoC Type-C driver Stanley Chang
2023-08-22 10:28 ` [PATCH v1 2/2] dt-bindings: extcon: Add Realtek DHC RTD SoC Type-C Stanley Chang
2023-08-22 15:38   ` Krzysztof Kozlowski
2023-08-24  6:03     ` Stanley Chang[昌育德]
2023-08-24  6:26       ` Krzysztof Kozlowski
2023-08-24  7:23         ` Stanley Chang[昌育德] [this message]
2023-08-24  8:43           ` Krzysztof Kozlowski
2023-08-24  9:23             ` Stanley Chang[昌育德]
2023-08-24  9:56               ` Krzysztof Kozlowski
2023-08-24 10:05                 ` Stanley Chang[昌育德]
2023-08-22 15:35 ` [PATCH v1 1/2] extcon: add Realtek DHC RTD SoC Type-C driver Krzysztof Kozlowski
2023-08-24  6:09   ` Stanley Chang[昌育德]
2023-08-23  0:26 ` kernel test robot
2023-08-23 14:15 ` kernel test robot
2023-08-24 19:43 ` Chanwoo Choi
2023-08-25  9:39   ` Stanley Chang[昌育德]
2023-08-29 11:15   ` Stanley Chang[昌育德]
2023-08-29 19:18     ` Chanwoo Choi
2023-08-30  3:59       ` Stanley Chang[昌育德]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390ad28e50f493fa72209fe29b7f3f4@realtek.com \
    --to=stanley_chang@realtek.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).