[PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Stephen Boyd]

The first breaks a reset-controller include ordering requirement. It got
an ack so I think we're ok for it to go through the clock tree.

The next patch adds support for setting the rate and the parent at the
same time based on patches from James Hogan's remuxing set_rate series.

After that we add MSM clock hardware support and SoC specific drivers. The DT
node additions will be sent through the MSM maintainers once these patches are
accepted.

Changes since v4:
 * Moved regmap code out of the core into drivers/clk/qcom/
 * Reworked to use a wrapper clk_regmap struct

Changes since v3:
 * Moved binding include to clock/
 * New patch for 8660 GCC driver
 * Renamed directory to qcom to match vendor prefix
 * Added some missing clocks in 8974 GCC driver
 * New patch for 8974 MMCC driver

Changes since v2:

 * Completed 8960 and 8974 GCC data & dt-bindings
 * Added support for reset controllers
 * Squashed some bugs in 8974 gcc clocks
 * New patch to fix clk NULL pointer deref
 * New patch to fix #include requirement for reset-controller.h

Changes since v1:

 * Rewrote binding to use #clock-cells=1
 * Reworked library components (pll, rcg, branch) to use regmap
 * Dropped common clock framework patches that did DT parsing
 * New patches for regmap support in common clock framework

Stephen Boyd (14):
  reset: Silence warning in reset-controller.h
  clk: Add set_rate_and_parent() op
  clk: qcom: Add a regmap type clock struct
  clk: qcom: Add support for phase locked loops (PLLs)
  clk: qcom: Add support for root clock generators (RCGs)
  clk: qcom: Add support for branches/gate clocks
  clk: qcom: Add reset controller support
  clk: qcom: Add support for MSM8960's global clock controller (GCC)
  clk: qcom: Add support for MSM8960's multimedia clock controller
    (MMCC)
  clk: qcom: Add support for MSM8974's global clock controller (GCC)
  clk: qcom: Add support for MSM8974's multimedia clock controller
    (MMCC)
  clk: qcom: Add support for MSM8660's global clock controller (GCC)
  devicetree: bindings: Document qcom,gcc
  devicetree: bindings: Document qcom,mmcc

 Documentation/clk.txt                              |    3 +
 .../devicetree/bindings/clock/qcom,gcc.txt         |   21 +
 .../devicetree/bindings/clock/qcom,mmcc.txt        |   21 +
 drivers/clk/Kconfig                                |    2 +
 drivers/clk/Makefile                               |    1 +
 drivers/clk/clk.c                                  |   78 +-
 drivers/clk/qcom/Kconfig                           |   47 +
 drivers/clk/qcom/Makefile                          |   14 +
 drivers/clk/qcom/clk-branch.c                      |  159 ++
 drivers/clk/qcom/clk-branch.h                      |   56 +
 drivers/clk/qcom/clk-pll.c                         |  222 ++
 drivers/clk/qcom/clk-pll.h                         |   66 +
 drivers/clk/qcom/clk-rcg.c                         |  517 ++++
 drivers/clk/qcom/clk-rcg.h                         |  159 ++
 drivers/clk/qcom/clk-rcg2.c                        |  291 ++
 drivers/clk/qcom/clk-regmap.c                      |  114 +
 drivers/clk/qcom/clk-regmap.h                      |   45 +
 drivers/clk/qcom/gcc-msm8660.c                     | 2819 ++++++++++++++++++
 drivers/clk/qcom/gcc-msm8960.c                     | 2993 ++++++++++++++++++++
 drivers/clk/qcom/gcc-msm8974.c                     | 2694 ++++++++++++++++++
 drivers/clk/qcom/mmcc-msm8960.c                    | 2321 +++++++++++++++
 drivers/clk/qcom/mmcc-msm8974.c                    | 2625 +++++++++++++++++
 drivers/clk/qcom/reset.c                           |   63 +
 drivers/clk/qcom/reset.h                           |   37 +
 include/dt-bindings/clock/qcom,gcc-msm8660.h       |  276 ++
 include/dt-bindings/clock/qcom,gcc-msm8960.h       |  313 ++
 include/dt-bindings/clock/qcom,gcc-msm8974.h       |  320 +++
 include/dt-bindings/clock/qcom,mmcc-msm8960.h      |  137 +
 include/dt-bindings/clock/qcom,mmcc-msm8974.h      |  161 ++
 include/dt-bindings/reset/qcom,gcc-msm8660.h       |  134 +
 include/dt-bindings/reset/qcom,gcc-msm8960.h       |  118 +
 include/dt-bindings/reset/qcom,gcc-msm8974.h       |   96 +
 include/dt-bindings/reset/qcom,mmcc-msm8960.h      |   93 +
 include/dt-bindings/reset/qcom,mmcc-msm8974.h      |   62 +
 include/linux/clk-provider.h                       |   15 +
 include/linux/reset-controller.h                   |    1 +
 36 files changed, 17075 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.txt
 create mode 100644 drivers/clk/qcom/Kconfig
 create mode 100644 drivers/clk/qcom/Makefile
 create mode 100644 drivers/clk/qcom/clk-branch.c
 create mode 100644 drivers/clk/qcom/clk-branch.h
 create mode 100644 drivers/clk/qcom/clk-pll.c
 create mode 100644 drivers/clk/qcom/clk-pll.h
 create mode 100644 drivers/clk/qcom/clk-rcg.c
 create mode 100644 drivers/clk/qcom/clk-rcg.h
 create mode 100644 drivers/clk/qcom/clk-rcg2.c
 create mode 100644 drivers/clk/qcom/clk-regmap.c
 create mode 100644 drivers/clk/qcom/clk-regmap.h
 create mode 100644 drivers/clk/qcom/gcc-msm8660.c
 create mode 100644 drivers/clk/qcom/gcc-msm8960.c
 create mode 100644 drivers/clk/qcom/gcc-msm8974.c
 create mode 100644 drivers/clk/qcom/mmcc-msm8960.c
 create mode 100644 drivers/clk/qcom/mmcc-msm8974.c
 create mode 100644 drivers/clk/qcom/reset.c
 create mode 100644 drivers/clk/qcom/reset.h
 create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8660.h
 create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8960.h
 create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8974.h
 create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8960.h
 create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8974.h
 create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8660.h
 create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8960.h
 create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8974.h
 create mode 100644 include/dt-bindings/reset/qcom,mmcc-msm8960.h
 create mode 100644 include/dt-bindings/reset/qcom,mmcc-msm8974.h

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH v5 13/14] devicetree: bindings: Document qcom,gcc

[Stephen Boyd]

Document the global clock controller found on Qualcomm devices.

Cc: <devicetree@vger.kernel.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 .../devicetree/bindings/clock/qcom,gcc.txt          | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc.txt

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.txt b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
new file mode 100644
index 000000000000..767401f42871
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.txt
@@ -0,0 +1,21 @@
+Qualcomm Global Clock & Reset Controller Binding
+------------------------------------------------
+
+Required properties :
+- compatible : shall contain only one of the following:
+
+			"qcom,gcc-msm8660"
+			"qcom,gcc-msm8960"
+			"qcom,gcc-msm8974"
+
+- reg : shall contain base register location and length
+- #clock-cells : shall contain 1
+- #reset-cells : shall contain 1
+
+Example:
+	clock-controller@900000 {
+		compatible = "qcom,gcc-msm8960";
+		reg = <0x900000 0x4000>;
+		#clock-cells = <1>;
+		#reset-cells = <1>;
+	};
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH v5 14/14] devicetree: bindings: Document qcom,mmcc

[Stephen Boyd]

Document the multimedia clock controller found on Qualcomm devices

Cc: <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
---
 .../devicetree/bindings/clock/qcom,mmcc.txt         | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.txt

diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
new file mode 100644
index 000000000000..d572e9964c54
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
@@ -0,0 +1,21 @@
+Qualcomm Multimedia Clock & Reset Controller Binding
+----------------------------------------------------
+
+Required properties :
+- compatible : shall contain only one of the following:
+
+			"qcom,mmcc-msm8660"
+			"qcom,mmcc-msm8960"
+			"qcom,mmcc-msm8974"
+
+- reg : shall contain base register location and length
+- #clock-cells : shall contain 1
+- #reset-cells : shall contain 1
+
+Example:
+	clock-controller@4000000 {
+		compatible = "qcom,mmcc-msm8960";
+		reg = <0x4000000 0x1000>;
+		#clock-cells = <1>;
+		#reset-cells = <1>;
+	};
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Mike Turquette]

Quoting Stephen Boyd (2014-01-15 10:47:20)
> The first breaks a reset-controller include ordering requirement. It got
> an ack so I think we're ok for it to go through the clock tree.
> 
> The next patch adds support for setting the rate and the parent at the
> same time based on patches from James Hogan's remuxing set_rate series.
> 
> After that we add MSM clock hardware support and SoC specific drivers. The DT
> node additions will be sent through the MSM maintainers once these patches are
> accepted.

Hi Stephen,

These patches look great and I've taken them into clk-next for testing.
They should get pushed out to my Linaro mirror later today and will go
in for 3.14. Thanks for spinning the revisions to this series so
quickly.

There might still be some way to share the regmap helpers in the future,
and getting these patches merged is a good starting point.

Regards,
Mike

> 
> Changes since v4:
>  * Moved regmap code out of the core into drivers/clk/qcom/
>  * Reworked to use a wrapper clk_regmap struct
> 
> Changes since v3:
>  * Moved binding include to clock/
>  * New patch for 8660 GCC driver
>  * Renamed directory to qcom to match vendor prefix
>  * Added some missing clocks in 8974 GCC driver
>  * New patch for 8974 MMCC driver
> 
> Changes since v2:
> 
>  * Completed 8960 and 8974 GCC data & dt-bindings
>  * Added support for reset controllers
>  * Squashed some bugs in 8974 gcc clocks
>  * New patch to fix clk NULL pointer deref
>  * New patch to fix #include requirement for reset-controller.h
> 
> Changes since v1:
> 
>  * Rewrote binding to use #clock-cells=1
>  * Reworked library components (pll, rcg, branch) to use regmap
>  * Dropped common clock framework patches that did DT parsing
>  * New patches for regmap support in common clock framework
> 
> Stephen Boyd (14):
>   reset: Silence warning in reset-controller.h
>   clk: Add set_rate_and_parent() op
>   clk: qcom: Add a regmap type clock struct
>   clk: qcom: Add support for phase locked loops (PLLs)
>   clk: qcom: Add support for root clock generators (RCGs)
>   clk: qcom: Add support for branches/gate clocks
>   clk: qcom: Add reset controller support
>   clk: qcom: Add support for MSM8960's global clock controller (GCC)
>   clk: qcom: Add support for MSM8960's multimedia clock controller
>     (MMCC)
>   clk: qcom: Add support for MSM8974's global clock controller (GCC)
>   clk: qcom: Add support for MSM8974's multimedia clock controller
>     (MMCC)
>   clk: qcom: Add support for MSM8660's global clock controller (GCC)
>   devicetree: bindings: Document qcom,gcc
>   devicetree: bindings: Document qcom,mmcc
> 
>  Documentation/clk.txt                              |    3 +
>  .../devicetree/bindings/clock/qcom,gcc.txt         |   21 +
>  .../devicetree/bindings/clock/qcom,mmcc.txt        |   21 +
>  drivers/clk/Kconfig                                |    2 +
>  drivers/clk/Makefile                               |    1 +
>  drivers/clk/clk.c                                  |   78 +-
>  drivers/clk/qcom/Kconfig                           |   47 +
>  drivers/clk/qcom/Makefile                          |   14 +
>  drivers/clk/qcom/clk-branch.c                      |  159 ++
>  drivers/clk/qcom/clk-branch.h                      |   56 +
>  drivers/clk/qcom/clk-pll.c                         |  222 ++
>  drivers/clk/qcom/clk-pll.h                         |   66 +
>  drivers/clk/qcom/clk-rcg.c                         |  517 ++++
>  drivers/clk/qcom/clk-rcg.h                         |  159 ++
>  drivers/clk/qcom/clk-rcg2.c                        |  291 ++
>  drivers/clk/qcom/clk-regmap.c                      |  114 +
>  drivers/clk/qcom/clk-regmap.h                      |   45 +
>  drivers/clk/qcom/gcc-msm8660.c                     | 2819 ++++++++++++++++++
>  drivers/clk/qcom/gcc-msm8960.c                     | 2993 ++++++++++++++++++++
>  drivers/clk/qcom/gcc-msm8974.c                     | 2694 ++++++++++++++++++
>  drivers/clk/qcom/mmcc-msm8960.c                    | 2321 +++++++++++++++
>  drivers/clk/qcom/mmcc-msm8974.c                    | 2625 +++++++++++++++++
>  drivers/clk/qcom/reset.c                           |   63 +
>  drivers/clk/qcom/reset.h                           |   37 +
>  include/dt-bindings/clock/qcom,gcc-msm8660.h       |  276 ++
>  include/dt-bindings/clock/qcom,gcc-msm8960.h       |  313 ++
>  include/dt-bindings/clock/qcom,gcc-msm8974.h       |  320 +++
>  include/dt-bindings/clock/qcom,mmcc-msm8960.h      |  137 +
>  include/dt-bindings/clock/qcom,mmcc-msm8974.h      |  161 ++
>  include/dt-bindings/reset/qcom,gcc-msm8660.h       |  134 +
>  include/dt-bindings/reset/qcom,gcc-msm8960.h       |  118 +
>  include/dt-bindings/reset/qcom,gcc-msm8974.h       |   96 +
>  include/dt-bindings/reset/qcom,mmcc-msm8960.h      |   93 +
>  include/dt-bindings/reset/qcom,mmcc-msm8974.h      |   62 +
>  include/linux/clk-provider.h                       |   15 +
>  include/linux/reset-controller.h                   |    1 +
>  36 files changed, 17075 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc.txt
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>  create mode 100644 drivers/clk/qcom/Kconfig
>  create mode 100644 drivers/clk/qcom/Makefile
>  create mode 100644 drivers/clk/qcom/clk-branch.c
>  create mode 100644 drivers/clk/qcom/clk-branch.h
>  create mode 100644 drivers/clk/qcom/clk-pll.c
>  create mode 100644 drivers/clk/qcom/clk-pll.h
>  create mode 100644 drivers/clk/qcom/clk-rcg.c
>  create mode 100644 drivers/clk/qcom/clk-rcg.h
>  create mode 100644 drivers/clk/qcom/clk-rcg2.c
>  create mode 100644 drivers/clk/qcom/clk-regmap.c
>  create mode 100644 drivers/clk/qcom/clk-regmap.h
>  create mode 100644 drivers/clk/qcom/gcc-msm8660.c
>  create mode 100644 drivers/clk/qcom/gcc-msm8960.c
>  create mode 100644 drivers/clk/qcom/gcc-msm8974.c
>  create mode 100644 drivers/clk/qcom/mmcc-msm8960.c
>  create mode 100644 drivers/clk/qcom/mmcc-msm8974.c
>  create mode 100644 drivers/clk/qcom/reset.c
>  create mode 100644 drivers/clk/qcom/reset.h
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8660.h
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8960.h
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8974.h
>  create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8960.h
>  create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8974.h
>  create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8660.h
>  create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8960.h
>  create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8974.h
>  create mode 100644 include/dt-bindings/reset/qcom,mmcc-msm8960.h
>  create mode 100644 include/dt-bindings/reset/qcom,mmcc-msm8974.h
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Frank Rowand]

On 1/15/2014 10:47 AM, Stephen Boyd wrote:
> The first breaks a reset-controller include ordering requirement. It got
> an ack so I think we're ok for it to go through the clock tree.
> 

< snip >

checkpatch is whining about patches

  4
  5
  6
  7
  8

(Just for completeness if someone thinks I did not check all the patches,
it also whines about patch 11, but I think the whining should be ignored,
and it whines about patch 1 but I think that might be a checkpatch bug.)

-Frank

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Frank Rowand]

On 2/6/2014 8:15 PM, Frank Rowand wrote:
> On 1/15/2014 10:47 AM, Stephen Boyd wrote:
>> The first breaks a reset-controller include ordering requirement. It got
>> an ack so I think we're ok for it to go through the clock tree.
>>
> 
> < snip >
> 
> checkpatch is whining about patches
> 

< snip >

Never mind....  I see that the patches are already in 3.14-rc1.

-Frank

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Joe Perches]

On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote:
> On 1/15/2014 10:47 AM, Stephen Boyd wrote:
> > The first breaks a reset-controller include ordering requirement. It got
> > an ack so I think we're ok for it to go through the clock tree.
> > 
> 
> < snip >
> 
> checkpatch is whining about patches
> 
>   4
>   5
>   6
>   7
>   8
> 
> (Just for completeness if someone thinks I did not check all the patches,
> it also whines about patch 11, but I think the whining should be ignored,
> and it whines about patch 1 but I think that might be a checkpatch bug.)

Hi Frank.

For patch 1, what checkpatch bug might that be?

I think all the checkpatch whinges in patch 11 are correct.

I didn't check any of 4-8.

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Frank Rowand]

On 2/6/2014 9:11 PM, Joe Perches wrote:
> On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote:
>> On 1/15/2014 10:47 AM, Stephen Boyd wrote:
>>> The first breaks a reset-controller include ordering requirement. It got
>>> an ack so I think we're ok for it to go through the clock tree.
>>>
>>
>> < snip >
>>
>> checkpatch is whining about patches
>>
>>   4
>>   5
>>   6
>>   7
>>   8
>>
>> (Just for completeness if someone thinks I did not check all the patches,
>> it also whines about patch 11, but I think the whining should be ignored,
>> and it whines about patch 1 but I think that might be a checkpatch bug.)
> 
> Hi Frank.
> 
> For patch 1, what checkpatch bug might that be?

see below

> 
> I think all the checkpatch whinges in patch 11 are correct.

Agreed on patch 11, judgement call on whether to ignore the warnings.

> 
> I didn't check any of 4-8.

Hi Joe,

Thanks for jumping in.  I did not want to bother you until I dug a little
deeper into the warning to see if I was just misunderstanding something.

Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add set_rate_and_parent() op"):

   WARNING: Multiple spaces after return type
   #188: FILE: include/linux/clk-provider.h:154:
   +       int             (*set_rate_and_parent)(struct clk_hw *hw,

   total: 0 errors, 1 warnings, 152 lines checked

-Frank

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Joe Perches]

On Fri, 2014-02-07 at 11:38 -0800, Frank Rowand wrote:
> On 2/6/2014 9:11 PM, Joe Perches wrote:
> > For patch 1, what checkpatch bug might that be?
[]
> Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add set_rate_and_parent() op"):
> 
>    WARNING: Multiple spaces after return type
>    #188: FILE: include/linux/clk-provider.h:154:
>    +       int             (*set_rate_and_parent)(struct clk_hw *hw,
> 
>    total: 0 errors, 1 warnings, 152 lines checked

Yup, that one might be a bit aggressive.

It's a complaint about function pointer declaration style.

from checkpatch:
------------------------------------------------------
# unnecessary space "type  (*funcptr)(args...)"
			elsif ($declare =~ /\s{2,}$/) {
				WARN("SPACING",
				     "Multiple spaces after return type\n" . $herecurr);
			}
------------------------------------------------------

This is warning about style equivalent to declarations like:

int		foo(int bar);

checkpatch doesn't warn about declarations of that style,
so likely checkpatch shouldn't warn about multiple spaces
after a function pointer return type either.

I don't have a strong opinion one way or another about it.

If you think it should be silenced, it could be either
downgraded to a CHK or removed altogether.

Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Frank Rowand]

On 2/7/2014 12:51 PM, Joe Perches wrote:
> On Fri, 2014-02-07 at 11:38 -0800, Frank Rowand wrote:
>> On 2/6/2014 9:11 PM, Joe Perches wrote:
>>> For patch 1, what checkpatch bug might that be?
> []
>> Sorry, it is patch 2, not patch 1 ("[PATCH v5 02/14] clk: Add set_rate_and_parent() op"):
>>
>>    WARNING: Multiple spaces after return type
>>    #188: FILE: include/linux/clk-provider.h:154:
>>    +       int             (*set_rate_and_parent)(struct clk_hw *hw,
>>
>>    total: 0 errors, 1 warnings, 152 lines checked
> 
> Yup, that one might be a bit aggressive.
> 
> It's a complaint about function pointer declaration style.
> 
> from checkpatch:
> ------------------------------------------------------
> # unnecessary space "type  (*funcptr)(args...)"
> 			elsif ($declare =~ /\s{2,}$/) {
> 				WARN("SPACING",
> 				     "Multiple spaces after return type\n" . $herecurr);
> 			}
> ------------------------------------------------------
> 
> This is warning about style equivalent to declarations like:
> 
> int		foo(int bar);
> 
> checkpatch doesn't warn about declarations of that style,
> so likely checkpatch shouldn't warn about multiple spaces
> after a function pointer return type either.
> 
> I don't have a strong opinion one way or another about it.
> 
> If you think it should be silenced, it could be either
> downgraded to a CHK or removed altogether.

OK, now the warning makes sense.  I was reading "spaces" to mean
the space character instead of white space.

I don't have a strong opinion either, but downgrading to a CHK
would be nice.

It would be less confusing to me (though awkward sounding) to
change the message to "Multiple whitespaces after return type".

-Frank