devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	pawel.moll@arm.com, Arnd Bergmann <arnd@arndb.de>,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] Documentation: devicetree: fix up pl011 clocks
Date: Tue, 11 Feb 2014 11:37:06 +0000	[thread overview]
Message-ID: <1392118632-11312-2-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1392118632-11312-1-git-send-email-mark.rutland@arm.com>

The "arm,pl011" device tree binding only describes the apb_pclk clock
input, which is not sufficient to use the device. Knowledge of the
uartclk clock input is required to be able to change the baud rate, as
the baud rate is derived from the reference uartclk input. On systems
where the uartclk input is not initially enabled, it is also required to
use the device in any fashion.

This patch adds the uartclk input to the pl011 device tree binding. The
clock-names property is also described, as it is an implied requirement
of the primecell binding the pl011 binding is derived from.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
---
 Documentation/devicetree/bindings/serial/pl011.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/pl011.txt b/Documentation/devicetree/bindings/serial/pl011.txt
index 5d2e840..f0a9e77 100644
--- a/Documentation/devicetree/bindings/serial/pl011.txt
+++ b/Documentation/devicetree/bindings/serial/pl011.txt
@@ -8,8 +8,10 @@ Required properties:
 Optional properties:
 - pinctrl: When present, must have one state named "sleep"
 	   and one state named "default"
-- clocks:  When present, must refer to exactly one clock named
-	   "apb_pclk"
+- clocks:  When present, must refer to a clock named
+           "apb_pclk", and optionally "uartclk".
+- clock-names: When present, should include "apb_pclk" and
+	   "uartclk", matching the clocks property.
 - dmas:	   When present, may have one or two dma channels.
 	   The first one must be named "rx", the second one
 	   must be named "tx".
-- 
1.8.1.1

  reply	other threads:[~2014-02-11 11:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 11:37 [PATCH 0/7] primecell: make correct clock parsing possible Mark Rutland
2014-02-11 11:37 ` Mark Rutland [this message]
     [not found] ` <1392118632-11312-1-git-send-email-mark.rutland-5wv7dgnIgG8@public.gmane.org>
2014-02-11 11:37   ` [PATCH 2/7] serial: amba-pl011: attempt to get uartclk by name Mark Rutland
2014-02-11 11:37   ` [PATCH 3/7] Documentation: devicetree: fix up pl022 clocks Mark Rutland
     [not found]     ` <1392118632-11312-4-git-send-email-mark.rutland-5wv7dgnIgG8@public.gmane.org>
2014-02-13 12:55       ` Linus Walleij
2014-02-11 11:37   ` [PATCH 4/7] spi: pl022: attempt to get sspclk by name Mark Rutland
     [not found]     ` <1392118632-11312-5-git-send-email-mark.rutland-5wv7dgnIgG8@public.gmane.org>
2014-02-11 12:06       ` Mark Brown
     [not found]         ` <20140211120645.GH13533-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-11 13:39           ` Mark Rutland
2014-02-11 14:08           ` Arnd Bergmann
     [not found]             ` <201402111508.06267.arnd-r2nGTMty4D4@public.gmane.org>
2014-02-11 15:04               ` Russell King - ARM Linux
     [not found]                 ` <20140211150438.GJ26684-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-02-11 15:48                   ` Arnd Bergmann
2014-02-12 10:33             ` Mark Rutland
     [not found]               ` <20140212103329.GC21992-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-12 10:55                 ` Mark Brown
2014-02-12 11:21                 ` Arnd Bergmann
     [not found]                   ` <201402121221.51233.arnd-r2nGTMty4D4@public.gmane.org>
2014-02-12 11:47                     ` Mark Rutland
     [not found]                       ` <20140212114740.GE21992-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-12 13:03                         ` Arnd Bergmann
2014-02-12 16:12                           ` Mark Rutland
     [not found]                             ` <20140212161206.GD25957-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-12 16:22                               ` Mark Brown
2014-02-12 16:31                               ` Arnd Bergmann
2014-02-24 12:26                                 ` Linus Walleij
2014-02-12 15:13                         ` Mark Brown
2014-02-11 11:37   ` [PATCH 5/7] Documentation: devicetree: fix up pl18x clocks Mark Rutland
2014-02-11 11:37   ` [PATCH 6/7] mmc: arm-mmci: attempt to get mclk by name Mark Rutland
2014-02-11 11:37   ` [PATCH 7/7] Documentation: devicetree: loosen primecell clock requirements Mark Rutland
2014-02-11 12:33   ` [PATCH 0/7] primecell: make correct clock parsing possible Russell King - ARM Linux
     [not found]     ` <20140211123356.GH26684-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-02-11 13:59       ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392118632-11312-2-git-send-email-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).