devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] devicetree: ad7303: Updated documentation
@ 2014-02-12 12:08 Paul Cercueil
       [not found] ` <1392206903-1662-1-git-send-email-paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2014-02-12 12:08 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Lars-Peter Clausen, linux-iio-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Rob Landley,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Paul Cercueil

Added documentation about the "adi,use-external-reference"
property.

Signed-off-by: Paul Cercueil <paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
---
 Documentation/devicetree/bindings/iio/dac/ad7303.txt |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/dac/ad7303.txt b/Documentation/devicetree/bindings/iio/dac/ad7303.txt
index 914610f..de6b32f 100644
--- a/Documentation/devicetree/bindings/iio/dac/ad7303.txt
+++ b/Documentation/devicetree/bindings/iio/dac/ad7303.txt
@@ -7,6 +7,9 @@ Required properties:
 	- Vdd-supply: Phandle to the Vdd power supply
 
 Optional properties:
+	- adi,use-external-reference: If set, the external reference voltage
+	  supply is used. Otherwise, the internal reference voltage supply is
+	  used.
 	- REF-supply: Phandle to the external reference voltage supply. This should
 	  only be set if there is an external reference voltage connected to the REF
 	  pin. If the property is not set Vdd/2 is used as the reference voltage.
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] devicetree: ad7303: Updated documentation
       [not found] ` <1392206903-1662-1-git-send-email-paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
@ 2014-02-12 12:21   ` Mark Rutland
       [not found]     ` <20140212122137.GA25957-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Rutland @ 2014-02-12 12:21 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Jonathan Cameron, Lars-Peter Clausen,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, Pawel Moll,
	Ian Campbell, Kumar Gala, Rob Landley,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Wed, Feb 12, 2014 at 12:08:23PM +0000, Paul Cercueil wrote:
> Added documentation about the "adi,use-external-reference"
> property.
> 
> Signed-off-by: Paul Cercueil <paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/iio/dac/ad7303.txt |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/ad7303.txt b/Documentation/devicetree/bindings/iio/dac/ad7303.txt
> index 914610f..de6b32f 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ad7303.txt
> +++ b/Documentation/devicetree/bindings/iio/dac/ad7303.txt
> @@ -7,6 +7,9 @@ Required properties:
>  	- Vdd-supply: Phandle to the Vdd power supply
>  
>  Optional properties:
> +	- adi,use-external-reference: If set, the external reference voltage
> +	  supply is used. Otherwise, the internal reference voltage supply is
> +	  used.

As I asked for the ad5064 binding document, when would you want to do
this, and why can't the driver decide?

Cheers,
Mark.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] devicetree: ad7303: Updated documentation
       [not found]     ` <20140212122137.GA25957-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
@ 2014-02-12 12:51       ` Lars-Peter Clausen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2014-02-12 12:51 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Paul Cercueil, Jonathan Cameron,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, Pawel Moll,
	Ian Campbell, Kumar Gala, Rob Landley,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On 02/12/2014 01:21 PM, Mark Rutland wrote:
> On Wed, Feb 12, 2014 at 12:08:23PM +0000, Paul Cercueil wrote:
>> Added documentation about the "adi,use-external-reference"
>> property.
>>
>> Signed-off-by: Paul Cercueil <paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
>> ---
>>   Documentation/devicetree/bindings/iio/dac/ad7303.txt |    3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/dac/ad7303.txt b/Documentation/devicetree/bindings/iio/dac/ad7303.txt
>> index 914610f..de6b32f 100644
>> --- a/Documentation/devicetree/bindings/iio/dac/ad7303.txt
>> +++ b/Documentation/devicetree/bindings/iio/dac/ad7303.txt
>> @@ -7,6 +7,9 @@ Required properties:
>>   	- Vdd-supply: Phandle to the Vdd power supply
>>
>>   Optional properties:
>> +	- adi,use-external-reference: If set, the external reference voltage
>> +	  supply is used. Otherwise, the internal reference voltage supply is
>> +	  used.
>
> As I asked for the ad5064 binding document, when would you want to do
> this, and why can't the driver decide?

Hi,

sorry my fault. I got confused with an older version of this driver and the 
version that actually made it upstream. This property is not in the upstream 
driver. The patch can safely be ignored and go to /dev/null. Again, sorry 
for noise.

- Lars

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-12 12:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-12 12:08 [PATCH] devicetree: ad7303: Updated documentation Paul Cercueil
     [not found] ` <1392206903-1662-1-git-send-email-paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2014-02-12 12:21   ` Mark Rutland
     [not found]     ` <20140212122137.GA25957-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-12 12:51       ` Lars-Peter Clausen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).