* [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi @ 2014-02-17 10:44 Wolfram Sang 2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang 2014-02-17 12:06 ` [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Magnus Damm 0 siblings, 2 replies; 13+ messages in thread From: Wolfram Sang @ 2014-02-17 10:44 UTC (permalink / raw) To: linux-sh Cc: linux-arm-kernel, devicetree, Magnus Damm, Simon Horman, Wolfram Sang From: Wolfram Sang <wsa@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> --- arch/arm/boot/dts/r8a7791.dtsi | 69 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index 41194fe..1ab4f3d 100644 --- a/arch/arm/boot/dts/r8a7791.dtsi +++ b/arch/arm/boot/dts/r8a7791.dtsi @@ -19,6 +19,15 @@ #address-cells = <2>; #size-cells = <2>; + aliases { + i2c0 = &i2c0; + i2c1 = &i2c1; + i2c2 = &i2c2; + i2c3 = &i2c3; + i2c4 = &i2c4; + i2c5 = &i2c5; + }; + cpus { #address-cells = <1>; #size-cells = <0>; @@ -170,6 +179,66 @@ <0 17 IRQ_TYPE_LEVEL_HIGH>; }; + i2c0: i2c@e6508000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a7791"; + reg = <0 0xe6508000 0 0x40>; + interrupts = <0 287 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_I2C0>; + status = "disabled"; + }; + + i2c1: i2c@e6518000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a7791"; + reg = <0 0xe6518000 0 0x40>; + interrupts = <0 288 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_I2C1>; + status = "disabled"; + }; + + i2c2: i2c@e6530000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a7791"; + reg = <0 0xe6530000 0 0x40>; + interrupts = <0 286 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_I2C2>; + status = "disabled"; + }; + + i2c3: i2c@e6540000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a7791"; + reg = <0 0xe6540000 0 0x40>; + interrupts = <0 290 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_I2C3>; + status = "disabled"; + }; + + i2c4: i2c@e6520000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a7791"; + reg = <0 0xe6520000 0 0x40>; + interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_I2C4>; + status = "disabled"; + }; + + i2c5: i2c@e6528000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a7791"; + reg = <0 0xe6528000 0 0x40>; + interrupts = <0 20 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_I2C5>; + status = "disabled"; + }; + pfc: pfc@e6060000 { compatible = "renesas,pfc-r8a7791"; reg = <0 0xe6060000 0 0x250>; -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-02-17 10:44 [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Wolfram Sang @ 2014-02-17 10:44 ` Wolfram Sang 2014-02-17 12:07 ` Magnus Damm ` (2 more replies) 2014-02-17 12:06 ` [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Magnus Damm 1 sibling, 3 replies; 13+ messages in thread From: Wolfram Sang @ 2014-02-17 10:44 UTC (permalink / raw) To: linux-sh Cc: linux-arm-kernel, devicetree, Magnus Damm, Simon Horman, Wolfram Sang From: Wolfram Sang <wsa@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> --- arch/arm/boot/dts/r8a7791-koelsch.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index d4b9bba..b3f75d7 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -108,10 +108,29 @@ clock-frequency = <20000000>; }; +&i2c2 { + pinctrl-0 = <&i2c2_pins>; + pinctrl-names = "default"; + + status = "okay"; + clock-frequency = <400000>; + + eeprom@50 { + compatible = "renesas,24c02"; + reg = <0x50>; + pagesize = <16>; + }; +}; + &pfc { pinctrl-0 = <&scif0_pins &scif1_pins>; pinctrl-names = "default"; + i2c2_pins: i2c { + renesas,groups = "i2c2"; + renesas,function = "i2c2"; + }; + scif0_pins: serial0 { renesas,groups = "scif0_data_d"; renesas,function = "scif0"; -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang @ 2014-02-17 12:07 ` Magnus Damm 2014-02-18 0:34 ` Simon Horman 2014-05-08 23:54 ` Sergei Shtylyov 2 siblings, 0 replies; 13+ messages in thread From: Magnus Damm @ 2014-02-17 12:07 UTC (permalink / raw) To: Wolfram Sang Cc: SH-Linux, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Simon Horman, Wolfram Sang On Mon, Feb 17, 2014 at 7:44 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > From: Wolfram Sang <wsa@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Acked-by: Magnus Damm <damm@opensource.se> Thanks, / magnus ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang 2014-02-17 12:07 ` Magnus Damm @ 2014-02-18 0:34 ` Simon Horman 2014-05-08 23:54 ` Sergei Shtylyov 2 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2014-02-18 0:34 UTC (permalink / raw) To: Wolfram Sang Cc: linux-sh, linux-arm-kernel, devicetree, Magnus Damm, Wolfram Sang On Mon, Feb 17, 2014 at 11:44:42AM +0100, Wolfram Sang wrote: > From: Wolfram Sang <wsa@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> Thanks, I have queued up the following after resolving a minor conflict. From: Wolfram Sang <wsa@sang-engineering.com> ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> Acked-by: Magnus Damm <damm@opensource.se> [horms+renesas@verge.net.au: resolved conflict] Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/boot/dts/r8a7791-koelsch.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index f67d2d0..bf6ba0c 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -108,10 +108,29 @@ clock-frequency = <20000000>; }; +&i2c2 { + pinctrl-0 = <&i2c2_pins>; + pinctrl-names = "default"; + + status = "okay"; + clock-frequency = <400000>; + + eeprom@50 { + compatible = "renesas,24c02"; + reg = <0x50>; + pagesize = <16>; + }; +}; + &pfc { pinctrl-0 = <&du_pins &scif0_pins &scif1_pins>; pinctrl-names = "default"; + i2c2_pins: i2c { + renesas,groups = "i2c2"; + renesas,function = "i2c2"; + }; + du_pins: du { renesas,groups = "du_rgb666", "du_sync", "du_clk_out_0"; renesas,function = "du"; -- 1.8.5.2 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang 2014-02-17 12:07 ` Magnus Damm 2014-02-18 0:34 ` Simon Horman @ 2014-05-08 23:54 ` Sergei Shtylyov 2014-05-09 5:06 ` Wolfram Sang 2 siblings, 1 reply; 13+ messages in thread From: Sergei Shtylyov @ 2014-05-08 23:54 UTC (permalink / raw) To: Wolfram Sang, linux-sh Cc: linux-arm-kernel, devicetree, Magnus Damm, Simon Horman, Wolfram Sang Hello. On 02/17/2014 01:44 PM, Wolfram Sang wrote: > From: Wolfram Sang <wsa@sang-engineering.com> > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index d4b9bba..b3f75d7 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -108,10 +108,29 @@ > clock-frequency = <20000000>; > }; > > +&i2c2 { > + pinctrl-0 = <&i2c2_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > + > + eeprom@50 { > + compatible = "renesas,24c02"; This is not quite right: Renesas' part is called differently, and you're carrying the other vendor's naming onto Renesas parts. I'd just say "24c02" (which I'll do in the Henninger board patch). WBR, Sergei ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-05-08 23:54 ` Sergei Shtylyov @ 2014-05-09 5:06 ` Wolfram Sang 2014-05-09 22:59 ` Sergei Shtylyov 0 siblings, 1 reply; 13+ messages in thread From: Wolfram Sang @ 2014-05-09 5:06 UTC (permalink / raw) To: Sergei Shtylyov Cc: linux-sh, linux-arm-kernel, devicetree, Magnus Damm, Simon Horman, Wolfram Sang [-- Attachment #1: Type: text/plain, Size: 295 bytes --] > >+ eeprom@50 { > >+ compatible = "renesas,24c02"; > > This is not quite right: Renesas' part is called differently, and > you're carrying the other vendor's naming onto Renesas parts. I'd > just say "24c02" (which I'll do in the Henninger board patch). What about "generic"? [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-05-09 5:06 ` Wolfram Sang @ 2014-05-09 22:59 ` Sergei Shtylyov [not found] ` <536D5DC3.3070409-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Sergei Shtylyov @ 2014-05-09 22:59 UTC (permalink / raw) To: Wolfram Sang Cc: linux-sh, linux-arm-kernel, devicetree, Magnus Damm, Simon Horman, Wolfram Sang Hello. On 05/09/2014 09:06 AM, Wolfram Sang wrote: >>> + eeprom@50 { >>> + compatible = "renesas,24c02"; >> This is not quite right: Renesas' part is called differently, and >> you're carrying the other vendor's naming onto Renesas parts. I'd >> just say "24c02" (which I'll do in the Henninger board patch). > What about "generic"? I don't know, really. However, you're right in that there should be some vendor prefix -- I've just seen Documentation/devicetree/bindings/eeprom.txt. WBR, Sergei ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <536D5DC3.3070409-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt [not found] ` <536D5DC3.3070409-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2014-05-11 0:08 ` Simon Horman 2014-05-12 7:35 ` Geert Uytterhoeven 0 siblings, 1 reply; 13+ messages in thread From: Simon Horman @ 2014-05-11 0:08 UTC (permalink / raw) To: Sergei Shtylyov Cc: Wolfram Sang, linux-sh-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, Magnus Damm, Wolfram Sang On Sat, May 10, 2014 at 02:59:15AM +0400, Sergei Shtylyov wrote: > Hello. > > On 05/09/2014 09:06 AM, Wolfram Sang wrote: > > >>>+ eeprom@50 { > >>>+ compatible = "renesas,24c02"; > > >> This is not quite right: Renesas' part is called differently, and > >>you're carrying the other vendor's naming onto Renesas parts. I'd > >>just say "24c02" (which I'll do in the Henninger board patch). > > >What about "generic"? > > I don't know, really. However, you're right in that there should > be some vendor prefix -- I've just seen > Documentation/devicetree/bindings/eeprom.txt. A quick survey of arch/arm/boot/dts/ yields: "atmel,24c02" (22 times) "microchip,24c02" (once) "mcp,24c02" (once) So it seems to me that precedence is in favour of using "renesas,24c02". -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-05-11 0:08 ` Simon Horman @ 2014-05-12 7:35 ` Geert Uytterhoeven 2014-05-12 12:10 ` Sergei Shtylyov 2014-05-13 0:07 ` Simon Horman 0 siblings, 2 replies; 13+ messages in thread From: Geert Uytterhoeven @ 2014-05-12 7:35 UTC (permalink / raw) To: Simon Horman Cc: Sergei Shtylyov, Wolfram Sang, Linux-sh list, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Magnus Damm, Wolfram Sang On Sun, May 11, 2014 at 2:08 AM, Simon Horman <horms@verge.net.au> wrote: > On Sat, May 10, 2014 at 02:59:15AM +0400, Sergei Shtylyov wrote: >> Hello. >> >> On 05/09/2014 09:06 AM, Wolfram Sang wrote: >> >> >>>+ eeprom@50 { >> >>>+ compatible = "renesas,24c02"; >> >> >> This is not quite right: Renesas' part is called differently, and >> >>you're carrying the other vendor's naming onto Renesas parts. I'd >> >>just say "24c02" (which I'll do in the Henninger board patch). >> >> >What about "generic"? >> >> I don't know, really. However, you're right in that there should >> be some vendor prefix -- I've just seen >> Documentation/devicetree/bindings/eeprom.txt. > > A quick survey of arch/arm/boot/dts/ yields: > > "atmel,24c02" (22 times) > "microchip,24c02" (once) > "mcp,24c02" (once) > > So it seems to me that precedence is in favour of using "renesas,24c02". Except that the Renesas part is called differently (as Sergei already pointed out), unlike the Atmel and Microchip parts. So it should be: compatible = "renesas,r1ex24002", "<something>,24c02"; Unfortunately the datasheet doesn't mention compatibility with parts from other manufacturers. So let's <something> be "atmel"? BTW, we have a similar issue with Genmai, which has an R1EX24128. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-05-12 7:35 ` Geert Uytterhoeven @ 2014-05-12 12:10 ` Sergei Shtylyov 2014-05-13 0:07 ` Simon Horman 1 sibling, 0 replies; 13+ messages in thread From: Sergei Shtylyov @ 2014-05-12 12:10 UTC (permalink / raw) To: Geert Uytterhoeven, Simon Horman Cc: Wolfram Sang, Linux-sh list, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Magnus Damm, Wolfram Sang Hello. On 05/12/2014 11:35 AM, Geert Uytterhoeven wrote: >>>>>> + eeprom@50 { >>>>>> + compatible = "renesas,24c02"; >>>>> This is not quite right: Renesas' part is called differently, and >>>>> you're carrying the other vendor's naming onto Renesas parts. I'd >>>>> just say "24c02" (which I'll do in the Henninger board patch). >>>> What about "generic"? >>> I don't know, really. However, you're right in that there should >>> be some vendor prefix -- I've just seen >>> Documentation/devicetree/bindings/eeprom.txt. >> A quick survey of arch/arm/boot/dts/ yields: >> "atmel,24c02" (22 times) >> "microchip,24c02" (once) >> "mcp,24c02" (once) >> So it seems to me that precedence is in favour of using "renesas,24c02". > Except that the Renesas part is called differently (as Sergei already pointed > out), unlike the Atmel and Microchip parts. > So it should be: > compatible = "renesas,r1ex24002", "<something>,24c02"; Unfortunately, that way the legacy I2C driver matching used now won't work anymore. :-( > Unfortunately the datasheet doesn't mention compatibility with parts from > other manufacturers. > So let's <something> be "atmel"? Yes, probably. But the "renesas,r1ex24002" part have to be dropped. > Gr{oetje,eeting}s, > Geert WBR, Sergei ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt 2014-05-12 7:35 ` Geert Uytterhoeven 2014-05-12 12:10 ` Sergei Shtylyov @ 2014-05-13 0:07 ` Simon Horman 1 sibling, 0 replies; 13+ messages in thread From: Simon Horman @ 2014-05-13 0:07 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Sergei Shtylyov, Wolfram Sang, Linux-sh list, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Magnus Damm, Wolfram Sang On Mon, May 12, 2014 at 09:35:46AM +0200, Geert Uytterhoeven wrote: > On Sun, May 11, 2014 at 2:08 AM, Simon Horman <horms@verge.net.au> wrote: > > On Sat, May 10, 2014 at 02:59:15AM +0400, Sergei Shtylyov wrote: > >> Hello. > >> > >> On 05/09/2014 09:06 AM, Wolfram Sang wrote: > >> > >> >>>+ eeprom@50 { > >> >>>+ compatible = "renesas,24c02"; > >> > >> >> This is not quite right: Renesas' part is called differently, and > >> >>you're carrying the other vendor's naming onto Renesas parts. I'd > >> >>just say "24c02" (which I'll do in the Henninger board patch). > >> > >> >What about "generic"? > >> > >> I don't know, really. However, you're right in that there should > >> be some vendor prefix -- I've just seen > >> Documentation/devicetree/bindings/eeprom.txt. > > > > A quick survey of arch/arm/boot/dts/ yields: > > > > "atmel,24c02" (22 times) > > "microchip,24c02" (once) > > "mcp,24c02" (once) > > > > So it seems to me that precedence is in favour of using "renesas,24c02". > > Except that the Renesas part is called differently (as Sergei already pointed > out), unlike the Atmel and Microchip parts. > > So it should be: > > compatible = "renesas,r1ex24002", "<something>,24c02"; > > Unfortunately the datasheet doesn't mention compatibility with parts from > other manufacturers. > > So let's <something> be "atmel"? If <something> isn't documented as being compatible then I feel that we should not add it to the list. > BTW, we have a similar issue with Genmai, which has an R1EX24128. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi 2014-02-17 10:44 [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Wolfram Sang 2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang @ 2014-02-17 12:06 ` Magnus Damm 2014-02-18 0:29 ` Simon Horman 1 sibling, 1 reply; 13+ messages in thread From: Magnus Damm @ 2014-02-17 12:06 UTC (permalink / raw) To: Wolfram Sang Cc: SH-Linux, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Simon Horman, Wolfram Sang On Mon, Feb 17, 2014 at 7:44 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > From: Wolfram Sang <wsa@sang-engineering.com> > > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > arch/arm/boot/dts/r8a7791.dtsi | 69 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi > index 41194fe..1ab4f3d 100644 > --- a/arch/arm/boot/dts/r8a7791.dtsi > +++ b/arch/arm/boot/dts/r8a7791.dtsi > @@ -19,6 +19,15 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + }; > + > cpus { > #address-cells = <1>; > #size-cells = <0>; > @@ -170,6 +179,66 @@ > <0 17 IRQ_TYPE_LEVEL_HIGH>; > }; > > + i2c0: i2c@e6508000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,i2c-r8a7791"; V2 of this patch looks good to me, thanks! Acked-by: Magnus Damm <damm@opensource.se> When you have time, please send an incremental patch to add support for the three IIC channels as well. Cheers, / magnus ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi 2014-02-17 12:06 ` [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Magnus Damm @ 2014-02-18 0:29 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2014-02-18 0:29 UTC (permalink / raw) To: Magnus Damm Cc: Wolfram Sang, SH-Linux, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Wolfram Sang On Mon, Feb 17, 2014 at 09:06:23PM +0900, Magnus Damm wrote: > On Mon, Feb 17, 2014 at 7:44 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > > From: Wolfram Sang <wsa@sang-engineering.com> > > > > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> Thanks, I have queued this up. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-05-13 0:07 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-17 10:44 [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Wolfram Sang
2014-02-17 10:44 ` [PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt Wolfram Sang
2014-02-17 12:07 ` Magnus Damm
2014-02-18 0:34 ` Simon Horman
2014-05-08 23:54 ` Sergei Shtylyov
2014-05-09 5:06 ` Wolfram Sang
2014-05-09 22:59 ` Sergei Shtylyov
[not found] ` <536D5DC3.3070409-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-11 0:08 ` Simon Horman
2014-05-12 7:35 ` Geert Uytterhoeven
2014-05-12 12:10 ` Sergei Shtylyov
2014-05-13 0:07 ` Simon Horman
2014-02-17 12:06 ` [PATCH V2 1/2] ARM: shmobile: r8a7791: add i2c master nodes to dtsi Magnus Damm
2014-02-18 0:29 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).