[PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Ashutosh singh]

This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module.

Signed-off-by: Ashutosh singh <ashutosh.s-mS2nBM426Az/PtFMR13I2A@public.gmane.org>
---
 arch/arm/boot/dts/imx6q-phytec-pbab01.dts  |    4 ++++
 arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi |   17 +++++++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
index 7d37ec6..87c3702 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
+++ b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
@@ -25,6 +25,10 @@
 	status = "okay";
 };
 
+&usbotg {
+	status = "okay";
+};
+
 &usdhc2 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
index 1a3b50d..e025ad2 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
@@ -18,6 +18,14 @@
 	memory {
 		reg = <0x10000000 0x80000000>;
 	};
+
+	reg_usb_otg_vbus: regulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_otg_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 15 0>;
+	};
 };
 
 &ecspi3 {
@@ -134,6 +142,7 @@
 				MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x80000000
 				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
 				MX6QDL_PAD_DI0_PIN15__GPIO4_IO17  0x80000000 /* PMIC interrupt */
+				MX6QDL_PAD_KEY_ROW4__GPIO4_IO15   0x80000000 /* USB_OTG_PWR_EN */
 			>;
 		};
 	};
@@ -162,6 +171,14 @@
 	status = "disabled";
 };
 
+&usbotg {
+	vbus-supply = <&reg_usb_otg_vbus>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg_1>;
+	disable-over-current;
+	status = "disabled";
+};
+
 &usdhc2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usdhc2_2>;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/4] Phytec phyFLEX-i.MX6 : Added USB_HOST Support

[Ashutosh singh]

This patch adds support for USB_HOST on Phytec phyFLEX-i.MX6 Quad module.

Signed-off-by: Ashutosh singh <ashutosh.s-mS2nBM426Az/PtFMR13I2A@public.gmane.org>
---
 arch/arm/boot/dts/imx6q-phytec-pbab01.dts  |    4 ++++
 arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi |   14 ++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
index 87c3702..91aecba 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
+++ b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
@@ -25,6 +25,10 @@
 	status = "okay";
 };
 
+&usbh1 {
+	status = "okay";
+};
+
 &usbotg {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
index e025ad2..12a02f7 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
@@ -26,6 +26,14 @@
 		regulator-max-microvolt = <5000000>;
 		gpio = <&gpio4 15 0>;
 	};
+
+	reg_usb_h1_vbus: regulator@1 {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_h1_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio1 0 0>;
+	};
 };
 
 &ecspi3 {
@@ -143,6 +151,7 @@
 				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
 				MX6QDL_PAD_DI0_PIN15__GPIO4_IO17  0x80000000 /* PMIC interrupt */
 				MX6QDL_PAD_KEY_ROW4__GPIO4_IO15   0x80000000 /* USB_OTG_PWR_EN */
+				MX6QDL_PAD_GPIO_0__USB_H1_PWR     0x80000000 /* USB_H1_PWR_EN */
 			>;
 		};
 	};
@@ -171,6 +180,11 @@
 	status = "disabled";
 };
 
+&usbh1 {
+	vbus-supply = <&reg_usb_h1_vbus>;
+	status = "disabled";
+};
+
 &usbotg {
 	vbus-supply = <&reg_usb_otg_vbus>;
 	pinctrl-names = "default";
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/4] Phytec phyFLEX-i.MX6 : Added GPMI-NAND Support

[Ashutosh singh]

This patch adds support for GPMI-NAND on Phytec phyFLEX-i.MX6 Quad module.

Signed-off-by: Ashutosh singh <ashutosh.s-mS2nBM426Az/PtFMR13I2A@public.gmane.org>
---
 arch/arm/boot/dts/imx6q-phytec-pbab01.dts  |    4 ++++
 arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi |    7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
index 91aecba..21c8b37 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
+++ b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
@@ -21,6 +21,10 @@
 	status = "okay";
 };
 
+&gpmi {
+	status = "okay";
+};
+
 &uart4 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
index 12a02f7..32097b4 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
@@ -174,6 +174,13 @@
 	status = "disabled";
 };
 
+&gpmi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_gpmi_nand_1>;
+	nand-on-flash-bbt;
+	status = "disabled";
+};
+
 &uart4 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart4_1>;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 4/4] Phytec phyFLEX-i.MX6 : Added SATA Support

[Ashutosh singh]

This patch adds support for SATA on Phytec phyFLEX-i.MX6 Quad module.

Signed-off-by: Ashutosh singh <ashutosh.s-mS2nBM426Az/PtFMR13I2A@public.gmane.org>
---
 arch/arm/boot/dts/imx6q-phytec-pbab01.dts |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
index 21c8b37..5607c33 100644
--- a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
+++ b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
@@ -25,6 +25,10 @@
 	status = "okay";
 };
 
+&sata {
+	status = "okay";
+};
+
 &uart4 {
 	status = "okay";
 };
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Shawn Guo]

On Tue, Feb 18, 2014 at 07:16:22PM +0530, Ashutosh singh wrote:
> This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module.
> 
> Signed-off-by: Ashutosh singh <ashutosh.s-mS2nBM426Az/PtFMR13I2A@public.gmane.org>

Please have the prefix of patch subject be 'ARM: dts: imx6q-phytec: ...'

> ---
>  arch/arm/boot/dts/imx6q-phytec-pbab01.dts  |    4 ++++
>  arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi |   17 +++++++++++++++++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
> index 7d37ec6..87c3702 100644
> --- a/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
> +++ b/arch/arm/boot/dts/imx6q-phytec-pbab01.dts
> @@ -25,6 +25,10 @@
>  	status = "okay";
>  };
>  
> +&usbotg {
> +	status = "okay";
> +};
> +
>  &usdhc2 {
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
> index 1a3b50d..e025ad2 100644
> --- a/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6q-phytec-pfla02.dtsi
> @@ -18,6 +18,14 @@
>  	memory {
>  		reg = <0x10000000 0x80000000>;
>  	};
> +
> +	reg_usb_otg_vbus: regulator@0 {

You do not have a 'reg' property in the node, so you shouldn't have
'@num' in node name.  You may want to name it 'regulator-0'.

> +		compatible = "regulator-fixed";
> +		regulator-name = "usb_otg_vbus";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		gpio = <&gpio4 15 0>;
> +	};
>  };
>  
>  &ecspi3 {
> @@ -134,6 +142,7 @@
>  				MX6QDL_PAD_EIM_D23__GPIO3_IO23 0x80000000
>  				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
>  				MX6QDL_PAD_DI0_PIN15__GPIO4_IO17  0x80000000 /* PMIC interrupt */
> +				MX6QDL_PAD_KEY_ROW4__GPIO4_IO15   0x80000000 /* USB_OTG_PWR_EN */

Don't add it into hog group.  Define a pinctrl state in above regulator
node for it.

>  			>;
>  		};
>  	};
> @@ -162,6 +171,14 @@
>  	status = "disabled";
>  };
>  
> +&usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usbotg_1>;

pinctrl_usbotg_1 is gone.  Please generate the patch against my for-next
branch below.

 git://git.linaro.org/people/shawnguo/linux-2.6.git for-next

Shawn

> +	disable-over-current;
> +	status = "disabled";
> +};
> +
>  &usdhc2 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usdhc2_2>;
> -- 
> 1.7.9.5
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Shawn Guo]

On Wed, Feb 19, 2014 at 10:23:09AM +0800, Shawn Guo wrote:
> > @@ -18,6 +18,14 @@
> >  	memory {
> >  		reg = <0x10000000 0x80000000>;
> >  	};
> > +
> > +	reg_usb_otg_vbus: regulator@0 {
> 
> You do not have a 'reg' property in the node, so you shouldn't have
> '@num' in node name.  You may want to name it 'regulator-0'.

I just saw the talk between Stephen and Mark [1], and I'm with Stephen
that neither regulator-0 nor regulator_0 is a good name.  Since Mark is
giving up the argument on the container, please follow the way we do in
other IMX dts today.

Shawn

[1] http://thread.gmane.org/gmane.linux.drivers.devicetree/61894/focus=62405

> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "usb_otg_vbus";
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-max-microvolt = <5000000>;
> > +		gpio = <&gpio4 15 0>;
> > +	};
> >  };

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Ashutosh]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

> On Wed, Feb 19, 2014 at 10:23:09AM +0800, Shawn Guo wrote:
>>> @@ -18,6 +18,14 @@
>>>   	memory {
>>>   		reg = <0x10000000 0x80000000>;
>>>   	};
>>> +
>>> +	reg_usb_otg_vbus: regulator@0 {
>> You do not have a 'reg' property in the node, so you shouldn't have
>> '@num' in node name.  You may want to name it 'regulator-0'.
> I just saw the talk between Stephen and Mark [1], and I'm with Stephen
> that neither regulator-0 nor regulator_0 is a good name.  Since Mark is
> giving up the argument on the container, please follow the way we do in
> other IMX dts today.
>
> Shawn
>
> [1] http://thread.gmane.org/gmane.linux.drivers.devicetree/61894/focus=62405
>
By seeing the discussion would the below changes is appropriate

regulators {
                 compatible = "simple-bus";
                 #address-cells = <1>;
                 #size-cells = <0>;

                 reg_usb_otg_vbus: regulator@0 {
                                compatible = "regulator-fixed";
                                 reg = <0>;
                                 regulator-name = "usb_otg_vbus";
                                 regulator-min-microvolt = <5000000>;
                                 regulator-max-microvolt = <5000000>;
                                 gpio = <&gpio4 15 0>;
                 };

But as Mark [1] suggested not to use simple bus. Which one is more 
appropriate ?

[1] http://www.spinics.net/lists/linux-usb/msg101477.html

>>> +		compatible = "regulator-fixed";
>>> +		regulator-name = "usb_otg_vbus";
>>> +		regulator-min-microvolt = <5000000>;
>>> +		regulator-max-microvolt = <5000000>;
>>> +		gpio = <&gpio4 15 0>;
>>> +	};
>>>   };

[-- Attachment #2: Type: text/html, Size: 4112 bytes --]

Re: [PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Singh Ashutosh]

[-- Attachment #1: Type: text/html, Size: 6633 bytes --]

Re: [PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

[Shawn Guo]

Do not send email in html.

On Wed, Feb 19, 2014 at 12:11:41PM +0530, Ashutosh wrote:
> By seeing the discussion would the below changes is appropriate
> 
> regulators {
>                 compatible = "simple-bus";
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> 
>                 reg_usb_otg_vbus: regulator@0 {
>                                compatible = "regulator-fixed";
>                                 reg = <0>;
>                                 regulator-name = "usb_otg_vbus";
>                                 regulator-min-microvolt = <5000000>;
>                                 regulator-max-microvolt = <5000000>;
>                                 gpio = <&gpio4 15 0>;
>                 };
> 
> But as Mark [1] suggested not to use simple bus. Which one is more appropriate
> ?

Since it's already been used so widely and provided us a nice way to use
the generic node name, I believe Mark is giving up his position.

Shawn

> 
> [1] http://www.spinics.net/lists/linux-usb/msg101477.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html